Commit 91a6c4ad authored by Tomasz Majchrzak's avatar Tomasz Majchrzak Committed by Shaohua Li

md: wake up personality thread after array state update

When raid1/raid10 array fails to write to one of the drives, the request
is added to bio_end_io_list and finished by personality thread. The
thread doesn't handle it as long as MD_CHANGE_PENDING flag is set. In
case of external metadata this flag is cleared, however the thread is
not woken up. It causes request to be blocked for few seconds (until
another action on the array wakes up the thread) or to get stuck
indefinitely.

Wake up personality thread once MD_CHANGE_PENDING has been cleared.
Moving 'restart_array' call after the flag is cleared it not a solution
because in read-write mode the call doesn't wake up the thread.
Signed-off-by: default avatarTomasz Majchrzak <tomasz.majchrzak@intel.com>
Signed-off-by: default avatarShaohua Li <shli@fb.com>
parent dcbcb486
...@@ -3922,6 +3922,7 @@ array_state_store(struct mddev *mddev, const char *buf, size_t len) ...@@ -3922,6 +3922,7 @@ array_state_store(struct mddev *mddev, const char *buf, size_t len)
if (st == active) { if (st == active) {
restart_array(mddev); restart_array(mddev);
clear_bit(MD_CHANGE_PENDING, &mddev->flags); clear_bit(MD_CHANGE_PENDING, &mddev->flags);
md_wakeup_thread(mddev->thread);
wake_up(&mddev->sb_wait); wake_up(&mddev->sb_wait);
err = 0; err = 0;
} else /* st == clean */ { } else /* st == clean */ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment