Commit 94b28441 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Mauro Carvalho Chehab

media: rockchip/rga: annotate PM functions as __maybe_unused

The newly added driver has incorrect #ifdef annotations on its
PM functions, leading to a harmless compile-time warning when
CONFIG_PM is disabled:

drivers/media/platform/rockchip/rga/rga.c:760:13: error: 'rga_disable_clocks' defined but not used [-Werror=unused-function]
 static void rga_disable_clocks(struct rockchip_rga *rga)
             ^~~~~~~~~~~~~~~~~~
drivers/media/platform/rockchip/rga/rga.c:728:12: error: 'rga_enable_clocks' defined but not used [-Werror=unused-function]

This removes the #ifdef and marks the functions as __maybe_unused,
so gcc can silently drop all the unused code.

Fixes: f7e7b48e ("[media] rockchip/rga: v4l2 m2m support")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 60757ee6
...@@ -960,8 +960,7 @@ static int rga_remove(struct platform_device *pdev) ...@@ -960,8 +960,7 @@ static int rga_remove(struct platform_device *pdev)
return 0; return 0;
} }
#ifdef CONFIG_PM static int __maybe_unused rga_runtime_suspend(struct device *dev)
static int rga_runtime_suspend(struct device *dev)
{ {
struct rockchip_rga *rga = dev_get_drvdata(dev); struct rockchip_rga *rga = dev_get_drvdata(dev);
...@@ -970,13 +969,12 @@ static int rga_runtime_suspend(struct device *dev) ...@@ -970,13 +969,12 @@ static int rga_runtime_suspend(struct device *dev)
return 0; return 0;
} }
static int rga_runtime_resume(struct device *dev) static int __maybe_unused rga_runtime_resume(struct device *dev)
{ {
struct rockchip_rga *rga = dev_get_drvdata(dev); struct rockchip_rga *rga = dev_get_drvdata(dev);
return rga_enable_clocks(rga); return rga_enable_clocks(rga);
} }
#endif
static const struct dev_pm_ops rga_pm = { static const struct dev_pm_ops rga_pm = {
SET_RUNTIME_PM_OPS(rga_runtime_suspend, SET_RUNTIME_PM_OPS(rga_runtime_suspend,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment