Commit 9581a4ae authored by Jeff Layton's avatar Jeff Layton Committed by Trond Myklebust

nfs: pass string length to pr_notice message about readdir loops

There is no guarantee that the strings in the nfs_cache_array will be
NULL-terminated. In the event that we end up hitting a readdir loop, we
need to ensure that we pass the warning message the length of the
string.
Reported-by: default avatarLachlan McIlroy <lmcilroy@redhat.com>
Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent e911b815
...@@ -313,10 +313,9 @@ int nfs_readdir_search_for_cookie(struct nfs_cache_array *array, nfs_readdir_des ...@@ -313,10 +313,9 @@ int nfs_readdir_search_for_cookie(struct nfs_cache_array *array, nfs_readdir_des
if (printk_ratelimit()) { if (printk_ratelimit()) {
pr_notice("NFS: directory %pD2 contains a readdir loop." pr_notice("NFS: directory %pD2 contains a readdir loop."
"Please contact your server vendor. " "Please contact your server vendor. "
"The file: %s has duplicate cookie %llu\n", "The file: %.*s has duplicate cookie %llu\n",
desc->file, desc->file, array->array[i].string.len,
array->array[i].string.name, array->array[i].string.name, *desc->dir_cookie);
*desc->dir_cookie);
} }
status = -ELOOP; status = -ELOOP;
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment