Commit 99803f17 authored by Hans de Goede's avatar Hans de Goede Committed by Greg Kroah-Hartman

staging: rtl8723bs: Fix Coverity warning in rtw_dbg_port()

Fix the following Coverity warning:

File: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c in function
rtw_dbg_port():

CID 18480: Operands don't affect result (CONSTANT_EXPRESSION_RESULT)
dead_error_condition: The condition (extra_arg & 7U) > 7U cannot be true.

        if ((extra_arg & 0x07) > 0x07)
                padapter->driver_ampdu_spacing = 0xFF;
        else
                padapter->driver_ampdu_spacing = extra_arg;
Reported-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b5a0c29f
...@@ -3096,7 +3096,7 @@ static int rtw_dbg_port(struct net_device *dev, ...@@ -3096,7 +3096,7 @@ static int rtw_dbg_port(struct net_device *dev,
DBG_871X("enable driver ctrl ampdu density = %d\n", extra_arg); DBG_871X("enable driver ctrl ampdu density = %d\n", extra_arg);
if ((extra_arg & 0x07) > 0x07) if (extra_arg > 0x07)
padapter->driver_ampdu_spacing = 0xFF; padapter->driver_ampdu_spacing = 0xFF;
else else
padapter->driver_ampdu_spacing = extra_arg; padapter->driver_ampdu_spacing = extra_arg;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment