Commit 9ae51a32 authored by Luis de Bethencourt's avatar Luis de Bethencourt

befs: use simpler while loop

Replace goto with simpler while loop to make befs_readdir() more readable.
Signed-off-by: default avatarLuis de Bethencourt <luisbg@osg.samsung.com>
parent 50858ef9
...@@ -216,7 +216,7 @@ befs_readdir(struct file *file, struct dir_context *ctx) ...@@ -216,7 +216,7 @@ befs_readdir(struct file *file, struct dir_context *ctx)
befs_debug(sb, "---> %s name %pD, inode %ld, ctx->pos %lld", befs_debug(sb, "---> %s name %pD, inode %ld, ctx->pos %lld",
__func__, file, inode->i_ino, ctx->pos); __func__, file, inode->i_ino, ctx->pos);
more: while (1) {
result = befs_btree_read(sb, ds, ctx->pos, BEFS_NAME_LEN + 1, result = befs_btree_read(sb, ds, ctx->pos, BEFS_NAME_LEN + 1,
keybuf, &keysize, &value); keybuf, &keysize, &value);
...@@ -239,8 +239,10 @@ befs_readdir(struct file *file, struct dir_context *ctx) ...@@ -239,8 +239,10 @@ befs_readdir(struct file *file, struct dir_context *ctx)
if (BEFS_SB(sb)->nls) { if (BEFS_SB(sb)->nls) {
char *nlsname; char *nlsname;
int nlsnamelen; int nlsnamelen;
result = result =
befs_utf2nls(sb, keybuf, keysize, &nlsname, &nlsnamelen); befs_utf2nls(sb, keybuf, keysize, &nlsname,
&nlsnamelen);
if (result < 0) { if (result < 0) {
befs_debug(sb, "<--- %s ERROR", __func__); befs_debug(sb, "<--- %s ERROR", __func__);
return result; return result;
...@@ -257,7 +259,7 @@ befs_readdir(struct file *file, struct dir_context *ctx) ...@@ -257,7 +259,7 @@ befs_readdir(struct file *file, struct dir_context *ctx)
return 0; return 0;
} }
ctx->pos++; ctx->pos++;
goto more; }
} }
static struct inode * static struct inode *
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment