[PATCH] USB: unusual_devs.h update

In view of the comments below, I think we should modify this
unusual_devs.h entry to suppress the warning messages.  Please apply.



On Mon, 28 Jun 2004, Joël Bourquard wrote:

> There seem to be two different flavors of ISD-300 (ie: 05ab,0060)
> devices, one of which needs this entry to work, and the other doesn't.
>
> I have a 2 1/2'' HDD enclosure which (just like your device) doesn't
> need the entry (so when I plug it, I get the same warning as you).
>
> However, I also happen to own two 5 1/4'' CD-ROM enclosures, for which
> this entry *is* necessary. I tried again, very recently to remove my
> unusual_devs.h entry, and it prevented them from working.
>
> So, I think the entry should be kept (it does more good than harm), but
> maybe it could get some tweaking ? If there's a way to recognize these
> "CD-ROM enclosure" bridge chips and exclude the others, I'm all for it.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

drivers/usb/storage/unusual_devs.h

@@ -388,11 +388,15 @@ UNUSUAL_DEV(  0x059f, 0xa601, 0x0200, 0x0200,
 		"USB Hard Disk",
 		US_SC_RBC, US_PR_CB, NULL, 0 ), 
 
-/* Submitted by Jol Bourquard <numlock@freesurf.ch> */
+/* Submitted by Joel Bourquard <numlock@freesurf.ch>
+ * Some versions of this device need the SubClass and Protocol overrides
+ * while others don't.
+ */
 UNUSUAL_DEV(  0x05ab, 0x0060, 0x1104, 0x1110,
 		"In-System",
 		"PyroGate External CD-ROM Enclosure (FCD-523)",
-		US_SC_SCSI, US_PR_BULK, NULL, 0 ),
+		US_SC_SCSI, US_PR_BULK, NULL,
+		US_FL_NEED_OVERRIDE ),
 
 #ifdef CONFIG_USB_STORAGE_ISD200
 UNUSUAL_DEV(  0x05ab, 0x0031, 0x0100, 0x0110,