Commit 9bf94f83 authored by Venkat Prashanth B U's avatar Venkat Prashanth B U Committed by Greg Kroah-Hartman

imu:adis16480: fix debugfs_simple_attr.cocci warnings

Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.

Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().

Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
Signed-off-by: default avatarVenkat Prashanth B U <venkat.prashanth2498@gmail.com>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9aaea09b
...@@ -194,7 +194,7 @@ static int adis16480_show_serial_number(void *arg, u64 *val) ...@@ -194,7 +194,7 @@ static int adis16480_show_serial_number(void *arg, u64 *val)
return 0; return 0;
} }
DEFINE_SIMPLE_ATTRIBUTE(adis16480_serial_number_fops, DEFINE_DEBUGFS_ATTRIBUTE(adis16480_serial_number_fops,
adis16480_show_serial_number, NULL, "0x%.4llx\n"); adis16480_show_serial_number, NULL, "0x%.4llx\n");
static int adis16480_show_product_id(void *arg, u64 *val) static int adis16480_show_product_id(void *arg, u64 *val)
...@@ -212,7 +212,7 @@ static int adis16480_show_product_id(void *arg, u64 *val) ...@@ -212,7 +212,7 @@ static int adis16480_show_product_id(void *arg, u64 *val)
return 0; return 0;
} }
DEFINE_SIMPLE_ATTRIBUTE(adis16480_product_id_fops, DEFINE_DEBUGFS_ATTRIBUTE(adis16480_product_id_fops,
adis16480_show_product_id, NULL, "%llu\n"); adis16480_show_product_id, NULL, "%llu\n");
static int adis16480_show_flash_count(void *arg, u64 *val) static int adis16480_show_flash_count(void *arg, u64 *val)
...@@ -230,24 +230,28 @@ static int adis16480_show_flash_count(void *arg, u64 *val) ...@@ -230,24 +230,28 @@ static int adis16480_show_flash_count(void *arg, u64 *val)
return 0; return 0;
} }
DEFINE_SIMPLE_ATTRIBUTE(adis16480_flash_count_fops, DEFINE_DEBUGFS_ATTRIBUTE(adis16480_flash_count_fops,
adis16480_show_flash_count, NULL, "%lld\n"); adis16480_show_flash_count, NULL, "%lld\n");
static int adis16480_debugfs_init(struct iio_dev *indio_dev) static int adis16480_debugfs_init(struct iio_dev *indio_dev)
{ {
struct adis16480 *adis16480 = iio_priv(indio_dev); struct adis16480 *adis16480 = iio_priv(indio_dev);
debugfs_create_file("firmware_revision", 0400, debugfs_create_file_unsafe("firmware_revision", 0400,
indio_dev->debugfs_dentry, adis16480, indio_dev->debugfs_dentry, adis16480,
&adis16480_firmware_revision_fops); &adis16480_firmware_revision_fops);
debugfs_create_file("firmware_date", 0400, indio_dev->debugfs_dentry, debugfs_create_file_unsafe("firmware_date", 0400,
adis16480, &adis16480_firmware_date_fops); indio_dev->debugfs_dentry, adis16480,
debugfs_create_file("serial_number", 0400, indio_dev->debugfs_dentry, &adis16480_firmware_date_fops);
adis16480, &adis16480_serial_number_fops); debugfs_create_file_unsafe("serial_number", 0400,
debugfs_create_file("product_id", 0400, indio_dev->debugfs_dentry, indio_dev->debugfs_dentry, adis16480,
adis16480, &adis16480_product_id_fops); &adis16480_serial_number_fops);
debugfs_create_file("flash_count", 0400, indio_dev->debugfs_dentry, debugfs_create_file_unsafe("product_id", 0400,
adis16480, &adis16480_flash_count_fops); indio_dev->debugfs_dentry, adis16480,
&adis16480_product_id_fops);
debugfs_create_file_unsafe("flash_count", 0400,
indio_dev->debugfs_dentry, adis16480,
&adis16480_flash_count_fops);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment