Commit 9dec58e6 authored by Julia Lawall's avatar Julia Lawall Committed by Tomi Valkeinen

video: omapdss: delete unneeded of_node_put

Device node iterators perform an of_node_put on each iteration, so putting
an of_node_put before a continue results in a double put.

A simplified version of the semantic match that finds this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator i;
@@

 i(..., child, ...) {
   ... when != of_node_get(child)
*  of_node_put(child);
   ...
*  continue;
}
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 0bcfdba6
...@@ -199,10 +199,8 @@ static int __init omapdss_boot_init(void) ...@@ -199,10 +199,8 @@ static int __init omapdss_boot_init(void)
omapdss_walk_device(dss, true); omapdss_walk_device(dss, true);
for_each_available_child_of_node(dss, child) { for_each_available_child_of_node(dss, child) {
if (!of_find_property(child, "compatible", NULL)) { if (!of_find_property(child, "compatible", NULL))
of_node_put(child);
continue; continue;
}
omapdss_walk_device(child, true); omapdss_walk_device(child, true);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment