Commit a25b77a1 authored by Maxime Ripard's avatar Maxime Ripard

drm/sun4i: hdmi: Fix unitialized variable

The is_double variable is used to store, and possibly returning to the
calling function, whether it needs to double the rate of the parent clock
or not.

In the case where it does, the variable is affected, but in the case where
it doesn't we return some uninitialized value. Fix this.
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@bootlin.com>
Reviewed-by: default avatarGiulio Benetti <giulio.benetti@micronovasrl.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181021163446.29135-1-maxime.ripard@bootlin.com
parent 633873e6
...@@ -35,7 +35,7 @@ static unsigned long sun4i_tmds_calc_divider(unsigned long rate, ...@@ -35,7 +35,7 @@ static unsigned long sun4i_tmds_calc_divider(unsigned long rate,
{ {
unsigned long best_rate = 0; unsigned long best_rate = 0;
u8 best_m = 0, m; u8 best_m = 0, m;
bool is_double; bool is_double = false;
for (m = div_offset ?: 1; m < (16 + div_offset); m++) { for (m = div_offset ?: 1; m < (16 + div_offset); m++) {
u8 d; u8 d;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment