Commit a3c6345e authored by Ioana Ciornei's avatar Ioana Ciornei Committed by Greg Kroah-Hartman

staging: dpaa2-ethsw: move port switchdev notifier per ethsw

Register a different switchdev notifier block per ethsw instance.
When probing multiple dpaa2-ethsw instances, without this the register
will fail.
Signed-off-by: default avatarIoana Ciornei <ioana.ciornei@nxp.com>
Link: https://lore.kernel.org/r/1573491058-24766-3-git-send-email-ioana.ciornei@nxp.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c5e648f8
...@@ -1314,10 +1314,6 @@ static int port_switchdev_blocking_event(struct notifier_block *unused, ...@@ -1314,10 +1314,6 @@ static int port_switchdev_blocking_event(struct notifier_block *unused,
return NOTIFY_DONE; return NOTIFY_DONE;
} }
static struct notifier_block port_switchdev_nb = {
.notifier_call = port_switchdev_event,
};
static struct notifier_block port_switchdev_blocking_nb = { static struct notifier_block port_switchdev_blocking_nb = {
.notifier_call = port_switchdev_blocking_event, .notifier_call = port_switchdev_blocking_event,
}; };
...@@ -1334,7 +1330,8 @@ static int ethsw_register_notifier(struct device *dev) ...@@ -1334,7 +1330,8 @@ static int ethsw_register_notifier(struct device *dev)
return err; return err;
} }
err = register_switchdev_notifier(&port_switchdev_nb); ethsw->port_switchdev_nb.notifier_call = port_switchdev_event;
err = register_switchdev_notifier(&ethsw->port_switchdev_nb);
if (err) { if (err) {
dev_err(dev, "Failed to register switchdev notifier\n"); dev_err(dev, "Failed to register switchdev notifier\n");
goto err_switchdev_nb; goto err_switchdev_nb;
...@@ -1349,7 +1346,7 @@ static int ethsw_register_notifier(struct device *dev) ...@@ -1349,7 +1346,7 @@ static int ethsw_register_notifier(struct device *dev)
return 0; return 0;
err_switchdev_blocking_nb: err_switchdev_blocking_nb:
unregister_switchdev_notifier(&port_switchdev_nb); unregister_switchdev_notifier(&ethsw->port_switchdev_nb);
err_switchdev_nb: err_switchdev_nb:
unregister_netdevice_notifier(&ethsw->port_nb); unregister_netdevice_notifier(&ethsw->port_nb);
return err; return err;
...@@ -1499,7 +1496,7 @@ static void ethsw_unregister_notifier(struct device *dev) ...@@ -1499,7 +1496,7 @@ static void ethsw_unregister_notifier(struct device *dev)
dev_err(dev, dev_err(dev,
"Failed to unregister switchdev blocking notifier (%d)\n", err); "Failed to unregister switchdev blocking notifier (%d)\n", err);
err = unregister_switchdev_notifier(&port_switchdev_nb); err = unregister_switchdev_notifier(&ethsw->port_switchdev_nb);
if (err) if (err)
dev_err(dev, dev_err(dev,
"Failed to unregister switchdev notifier (%d)\n", err); "Failed to unregister switchdev notifier (%d)\n", err);
......
...@@ -68,6 +68,7 @@ struct ethsw_core { ...@@ -68,6 +68,7 @@ struct ethsw_core {
bool learning; bool learning;
struct notifier_block port_nb; struct notifier_block port_nb;
struct notifier_block port_switchdev_nb;
}; };
#endif /* __ETHSW_H */ #endif /* __ETHSW_H */
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment