Commit aafb197f authored by Amitoj Kaur Chawla's avatar Amitoj Kaur Chawla Committed by Thierry Reding

memory: tegra: tegra124-emc: Add missing of_node_put()

for_each_child_of_node() performs an of_node_get() on each iteration, so
to break out of the loop an of_node_put() is required.

Found using Coccinelle. The semantic patch used for this is as follows:

// <smpl>
@@
expression e;
local idexpression n;
@@

 for_each_child_of_node(..., n) {
   ... when != of_node_put(n)
       when != e = n
(
   return n;
|
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>
Signed-off-by: default avatarAmitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 1a695a90
...@@ -970,9 +970,11 @@ static int tegra_emc_load_timings_from_dt(struct tegra_emc *emc, ...@@ -970,9 +970,11 @@ static int tegra_emc_load_timings_from_dt(struct tegra_emc *emc,
timing = &emc->timings[i++]; timing = &emc->timings[i++];
err = load_one_timing_from_dt(emc, timing, child); err = load_one_timing_from_dt(emc, timing, child);
if (err) if (err) {
of_node_put(child);
return err; return err;
} }
}
sort(emc->timings, emc->num_timings, sizeof(*timing), cmp_timings, sort(emc->timings, emc->num_timings, sizeof(*timing), cmp_timings,
NULL); NULL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment