Commit aee37f3d authored by Roi Dayan's avatar Roi Dayan Committed by Saeed Mahameed

net/mlx5: Fix cleaning unmanaged flow tables

Unmanaged flow tables doesn't have a parent and tree_put_node()
assume there is always a parent if cleaning is needed. fix that.

Fixes: 5281a0c9 ("net/mlx5: fs_core: Introduce unmanaged flow tables")
Signed-off-by: default avatarRoi Dayan <roid@mellanox.com>
Reviewed-by: default avatarMark Bloch <markb@mellanox.com>
Reviewed-by: default avatarPaul Blakey <paulb@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent df14ad1e
...@@ -344,14 +344,13 @@ static void tree_put_node(struct fs_node *node, bool locked) ...@@ -344,14 +344,13 @@ static void tree_put_node(struct fs_node *node, bool locked)
if (node->del_hw_func) if (node->del_hw_func)
node->del_hw_func(node); node->del_hw_func(node);
if (parent_node) { if (parent_node) {
/* Only root namespace doesn't have parent and we just
* need to free its node.
*/
down_write_ref_node(parent_node, locked); down_write_ref_node(parent_node, locked);
list_del_init(&node->list); list_del_init(&node->list);
if (node->del_sw_func) if (node->del_sw_func)
node->del_sw_func(node); node->del_sw_func(node);
up_write_ref_node(parent_node, locked); up_write_ref_node(parent_node, locked);
} else if (node->del_sw_func) {
node->del_sw_func(node);
} else { } else {
kfree(node); kfree(node);
} }
...@@ -468,8 +467,10 @@ static void del_sw_flow_table(struct fs_node *node) ...@@ -468,8 +467,10 @@ static void del_sw_flow_table(struct fs_node *node)
fs_get_obj(ft, node); fs_get_obj(ft, node);
rhltable_destroy(&ft->fgs_hash); rhltable_destroy(&ft->fgs_hash);
if (ft->node.parent) {
fs_get_obj(prio, ft->node.parent); fs_get_obj(prio, ft->node.parent);
prio->num_ft--; prio->num_ft--;
}
kfree(ft); kfree(ft);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment