Commit af6f8529 authored by Heinrich Schuchardt's avatar Heinrich Schuchardt Committed by Greg Kroah-Hartman

usb: musb: gadget: misplaced out of bounds check

musb->endpoints[] has array size MUSB_C_NUM_EPS.
We must check array bounds before accessing the array and not afterwards.
Signed-off-by: default avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: default avatarBin Liu <b-liu@ti.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent be9cae24
...@@ -89,15 +89,19 @@ static int service_tx_status_request( ...@@ -89,15 +89,19 @@ static int service_tx_status_request(
} }
is_in = epnum & USB_DIR_IN; is_in = epnum & USB_DIR_IN;
if (is_in) {
epnum &= 0x0f; epnum &= 0x0f;
if (epnum >= MUSB_C_NUM_EPS) {
handled = -EINVAL;
break;
}
if (is_in)
ep = &musb->endpoints[epnum].ep_in; ep = &musb->endpoints[epnum].ep_in;
} else { else
ep = &musb->endpoints[epnum].ep_out; ep = &musb->endpoints[epnum].ep_out;
}
regs = musb->endpoints[epnum].regs; regs = musb->endpoints[epnum].regs;
if (epnum >= MUSB_C_NUM_EPS || !ep->desc) { if (!ep->desc) {
handled = -EINVAL; handled = -EINVAL;
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment