[PATCH] next fixes

here are the next fixes, sorry for the delay, but one of bugs was a really
odd one.

Note:
- here are lot of bugs left, so ISDN is not stable yet but
  I think it's really time to fix it, even if it need some cycles
  to get it right (normally I'm only send patches if it works 100% for
  me).
- I add some additional #warnings to address places which need fixing
  (I hope that some of the other ISDN developer jump in)

drivers/isdn/capi/capi.c

@@ -58,12 +58,16 @@ MODULE_LICENSE("GPL");
 
 int capi_major = 68;		/* allocated */
 #ifdef CONFIG_ISDN_CAPI_MIDDLEWARE
+#define CAPINC_NR_PORTS	32
+#define CAPINC_MAX_PORTS	256
 int capi_ttymajor = 191;
+int capi_ttyminors = CAPINC_NR_PORTS;
 #endif /* CONFIG_ISDN_CAPI_MIDDLEWARE */
 
 MODULE_PARM(capi_major, "i");
 #ifdef CONFIG_ISDN_CAPI_MIDDLEWARE
 MODULE_PARM(capi_ttymajor, "i");
+MODULE_PARM(capi_ttyminors, "i");
 #endif /* CONFIG_ISDN_CAPI_MIDDLEWARE */
 
 /* -------- defines ------------------------------------------------- */
@@ -1262,7 +1266,6 @@ static int capinc_tty_read_proc(char *page, char **start, off_t off,
 	return 0;
 }
 
-#define CAPINC_NR_PORTS 256
 static struct tty_driver *capinc_tty_driver;
 
 static struct tty_operations capinc_ops = {
@@ -1289,8 +1292,14 @@ static struct tty_operations capinc_ops = {
 
 static int capinc_tty_init(void)
 {
-	struct tty_driver *drv = alloc_tty_driver(CAPINC_NR_PORTS);
+	struct tty_driver *drv;
 	
+	if (capi_ttyminors > CAPINC_MAX_PORTS)
+		capi_ttyminors = CAPINC_MAX_PORTS;
+	if (capi_ttyminors <= 0)
+		capi_ttyminors = CAPINC_NR_PORTS;
+
+	drv = alloc_tty_driver(capi_ttyminors);
 	if (!drv)
 		return -ENOMEM;
 
@@ -1454,7 +1463,6 @@ static int __init capi_init(void)
 	char *p;
 	char *compileinfo;
 
-
 	if ((p = strchr(revision, ':')) != 0 && p[1]) {
 		strlcpy(rev, p + 2, sizeof(rev));
 		if ((p = strchr(rev, '$')) != 0 && p > rev)
@@ -1470,8 +1478,6 @@ static int __init capi_init(void)
 	devfs_mk_cdev(MKDEV(capi_major, 0), S_IFCHR | S_IRUSR | S_IWUSR,
 			"isdn/capi20");
 
-	printk(KERN_NOTICE "capi20: started up with major %d\n", capi_major);
-
 #ifdef CONFIG_ISDN_CAPI_MIDDLEWARE
 	if (capinc_tty_init() < 0) {
 		unregister_chrdev(capi_major, "capi20");

drivers/isdn/capi/capidrv.c

@@ -1991,6 +1991,10 @@ static int capidrv_addcontr(u16 contr, struct capi_profile *profp)
 	int i;
 
 	sprintf(id, "capidrv-%d", contr);
+	if (!try_module_get(THIS_MODULE)) {
+		printk(KERN_WARNING "capidrv: (%s) Could not reserve module\n", id);
+		return -1;
+	}
 	if (!(card = (capidrv_contr *) kmalloc(sizeof(capidrv_contr), GFP_ATOMIC))) {
 		printk(KERN_WARNING
 		 "capidrv: (%s) Could not allocate contr-struct.\n", id);
@@ -1998,11 +2002,6 @@ static int capidrv_addcontr(u16 contr, struct capi_profile *profp)
 	}
 	memset(card, 0, sizeof(capidrv_contr));
 	card->owner = THIS_MODULE;
-	if (!try_module_get(card->owner)) {
-		printk(KERN_WARNING "capidrv: (%s) Could not reserve module\n", id);
-		kfree(card);
-		return -1;
-	}
 	init_timer(&card->listentimer);
 	strcpy(card->name, id);
 	card->contrnr = contr;
@@ -2099,6 +2098,7 @@ static int capidrv_delcontr(u16 contr)
 		printk(KERN_ERR "capidrv: delcontr: no contr %u\n", contr);
 		return -1;
 	}
+	#warning FIXME: maybe a race condition the card should be removed here from global list /kkeil
 	spin_unlock_irqrestore(&global_lock, flags);
 
 	del_timer(&card->listentimer);

drivers/isdn/capi/kcapi.c

@@ -77,31 +77,17 @@ static struct work_struct tq_recv_notify;
 static inline struct capi_ctr *
 capi_ctr_get(struct capi_ctr *card)
 {
-	if (try_module_get(card->owner))
-		return card;
+	if (!try_module_get(card->owner))
 		return NULL;
+	DBG("Reserve module: %s", card->owner->name);
+	return card;
 }
 
 static inline void
 capi_ctr_put(struct capi_ctr *card)
 {
 	module_put(card->owner);
-	DBG("MOD_COUNT DEC");
-}
-
-/* -------- own ref counting -------------------------------------- */
-
-static inline void
-kcapi_get_ref(void)
-{
-	if (!try_module_get(THIS_MODULE))
-		printk(KERN_WARNING "%s: cannot reserve module\n", __FUNCTION__);
-}
-
-static inline void
-kcapi_put_ref(void)
-{
-	module_put(THIS_MODULE);
+	DBG("Release module: %s", card->owner->name);
 }
 
 /* ------------------------------------------------------------- */
@@ -224,10 +210,13 @@ static int notify_push(unsigned int cmd, u32 controller,
 {
 	struct capi_notifier *np;
 
-	kcapi_get_ref();
+	if (!try_module_get(THIS_MODULE)) {
+		printk(KERN_WARNING "%s: cannot reserve module\n", __FUNCTION__);
+		return -1;
+	}
 	np = (struct capi_notifier *)kmalloc(sizeof(struct capi_notifier), GFP_ATOMIC);
 	if (!np) {
-		kcapi_put_ref();
+		module_put(THIS_MODULE);
 		return -1;
 	}
 	memset(np, 0, sizeof(struct capi_notifier));
@@ -241,9 +230,9 @@ static int notify_push(unsigned int cmd, u32 controller,
 	 * of devices. Devices can only removed in
 	 * user process, not in bh.
 	 */
-	kcapi_get_ref();
+	__module_get(THIS_MODULE);
 	if (schedule_work(&tq_state_notify) == 0)
-		kcapi_put_ref();
+		module_put(THIS_MODULE);
 	return 0;
 }
 
@@ -301,9 +290,9 @@ static void notify_handler(void *dummy)
 	while ((np = notify_dequeue()) != 0) {
 		notify_doit(np);
 		kfree(np);
-		kcapi_put_ref();
+		module_put(THIS_MODULE);
 	}
-	kcapi_put_ref();
+	module_put(THIS_MODULE);
 }
 	
 /* -------- Receiver ------------------------------------------ */

drivers/isdn/hardware/avm/c4.c

@@ -37,8 +37,8 @@
 static int suppress_pollack;
 
 static struct pci_device_id c4_pci_tbl[] = {
-	{ PCI_VENDOR_ID_DEC, PCI_DEVICE_ID_DEC_21285, PCI_VENDOR_ID_AVM, PCI_DEVICE_ID_AVM_C4, 4 },
-	{ PCI_VENDOR_ID_DEC, PCI_DEVICE_ID_DEC_21285, PCI_VENDOR_ID_AVM, PCI_DEVICE_ID_AVM_C2, 2 },
+	{ PCI_VENDOR_ID_DEC, PCI_DEVICE_ID_DEC_21285, PCI_VENDOR_ID_AVM, PCI_DEVICE_ID_AVM_C4, 0, 0, (unsigned long)4 },
+	{ PCI_VENDOR_ID_DEC, PCI_DEVICE_ID_DEC_21285, PCI_VENDOR_ID_AVM, PCI_DEVICE_ID_AVM_C2, 0, 0, (unsigned long)2 },
 	{ }			/* Terminating entry */
 };
 
@@ -145,6 +145,7 @@ static inline int wait_for_doorbell(avmcard *card, unsigned long t)
 	while (c4inmeml(card->mbase+DOORBELL) != 0xffffffff) {
 		if (!time_before(jiffies, stop))
 			return -1;
+		mb();
 	}
 	return 0;
 }
@@ -297,6 +298,7 @@ static void c4_reset(avmcard *card)
 		if (!time_before(jiffies, stop))
 			return;
 		c4outmeml(card->mbase+DOORBELL, DBELL_ADDR);
+		mb();
 	}
 
 	c4_poke(card, DC21285_ARMCSR_BASE + CHAN_1_CONTROL, 0);
@@ -320,6 +322,7 @@ static int c4_detect(avmcard *card)
 		if (!time_before(jiffies, stop))
 			return 2;
 		c4outmeml(card->mbase+DOORBELL, DBELL_ADDR);
+		mb();
 	}
 
 	c4_poke(card, DC21285_ARMCSR_BASE + CHAN_1_CONTROL, 0);
@@ -899,6 +902,9 @@ static void c4_remove(struct pci_dev *pdev)
 	avmctrl_info *cinfo;
 	u_int i;
 
+	if (!card)
+		return;
+
  	c4_reset(card);
 
         for (i=0; i < card->nr_controllers; i++) {
@@ -910,6 +916,7 @@ static void c4_remove(struct pci_dev *pdev)
 	iounmap(card->mbase);
 	release_region(card->port, AVMB1_PORTLEN);
         avmcard_dma_free(card->dma);
+        pci_set_drvdata(pdev, NULL);
 	b1_free_card(card);
 }
 
@@ -1141,7 +1148,7 @@ static int c4_add_card(struct capicardparams *p, struct pci_dev *dev,
 
 	retval = c4_detect(card);
 	if (retval != 0) {
-		printk(KERN_NOTICE "c4: NO card at 0x%x (%d)\n",
+		printk(KERN_NOTICE "c4: NO card at 0x%x error(%d)\n",
 		       card->port, retval);
 		retval = -EIO;
 		goto err_unmap;
@@ -1185,7 +1192,7 @@ static int c4_add_card(struct capicardparams *p, struct pci_dev *dev,
 	printk(KERN_INFO "c4: AVM C%d at i/o %#x, irq %d, mem %#lx\n",
 	       nr_controllers, card->port, card->irq,
 	       card->membase);
-
+	pci_set_drvdata(dev, card);
 	return 0;
 
  err_free_irq:

drivers/isdn/i4l/isdn_audio.c

@@ -559,7 +559,7 @@ isdn_audio_eval_dtmf(modem_info * info)
 			ISDN_AUDIO_SKB_DLECOUNT(skb) = 0;
 			ISDN_AUDIO_SKB_LOCK(skb) = 0;
 			isdn_tty_queue_tail(info, skb, 2);
-			if ((dev->modempoll) && (info->rcvsched))
+			if (((get_isdn_dev())->modempoll) && (info->rcvsched))
 				mod_timer(&info->read_timer, jiffies + 4);
 		} else
 			kfree_skb(skb);
@@ -670,7 +670,7 @@ isdn_audio_put_dle_code(modem_info * info, u_char code)
 	ISDN_AUDIO_SKB_LOCK(skb) = 0;
 	isdn_tty_queue_tail(info, skb, 2);
 	/* Schedule dequeuing */
-	if ((dev->modempoll) && (info->rcvsched))
+	if (((get_isdn_dev())->modempoll) && (info->rcvsched))
 		mod_timer(&info->read_timer, jiffies + 4);
 }
 

drivers/isdn/i4l/isdn_common.c

@@ -32,15 +32,15 @@ MODULE_DESCRIPTION("ISDN4Linux: link layer");
 MODULE_AUTHOR("Fritz Elfert");
 MODULE_LICENSE("GPL");
 
-isdn_dev *dev;
+static isdn_dev_t *isdndev;
 
-static void isdn_lock_driver(struct isdn_driver *drv);
-static void isdn_unlock_driver(struct isdn_driver *drv);
-
-/* ====================================================================== */
+isdn_dev_t *
+get_isdn_dev(void) {
+	return(isdndev);
+}
 
 /* Description of hardware-level-driver */
-struct isdn_driver {
+typedef struct isdn_driver {
 	int                 di;
 	char                id[20];
 	atomic_t            refcnt;
@@ -55,7 +55,15 @@ struct isdn_driver {
 	spinlock_t          lock;
 	struct isdn_slot   *slots; 
 	struct fsm_inst     fi;
-} driver;
+} isdn_driver_t;
+
+static spinlock_t	drivers_lock = SPIN_LOCK_UNLOCKED;
+static isdn_driver_t	*drivers[ISDN_MAX_DRIVERS];
+
+static void isdn_lock_driver(struct isdn_driver *drv);
+static void isdn_unlock_driver(struct isdn_driver *drv);
+
+/* ====================================================================== */
 
 static void drv_destroy(struct isdn_driver *drv);
 
@@ -332,7 +340,7 @@ slot_icall(struct fsm_inst *fi, int pr, void *arg)
 	isdn_lock_driver(slot->drv);
 	fsm_change_state(fi, ST_SLOT_IN);
 	slot_debug(fi, "ICALL: %s\n", ctrl->parm.num);
-	if (dev->global_flags & ISDN_GLOBAL_STOPPED)
+	if (isdndev->global_flags & ISDN_GLOBAL_STOPPED)
 		return 0;
 	
 	strcpy(slot->num, ctrl->parm.setup.phone);
@@ -461,9 +469,6 @@ static char *drv_st_str[] = {
 
 static int __drv_command(struct isdn_driver *drv, isdn_ctrl *cmd);
 
-static spinlock_t drivers_lock = SPIN_LOCK_UNLOCKED;
-static struct isdn_driver *drivers[ISDN_MAX_DRIVERS];
-
 static int
 isdn_writebuf_skb(struct isdn_slot *slot, struct sk_buff *skb)
 {
@@ -563,14 +568,14 @@ set_global_features(void)
 	unsigned long flags;
 	int drvidx;
 
-	dev->global_features = 0;
+	isdndev->global_features = 0;
 	spin_lock_irqsave(&drivers_lock, flags);
 	for (drvidx = 0; drvidx < ISDN_MAX_DRIVERS; drvidx++) {
 		if (!drivers[drvidx])
 			continue;
 		if (drivers[drvidx]->fi.state != ST_DRV_RUNNING)
 			continue;
-		dev->global_features |= drivers[drvidx]->features;
+		isdndev->global_features |= drivers[drvidx]->features;
 	}
 	spin_unlock_irqrestore(&drivers_lock, flags);
 }
@@ -632,7 +637,7 @@ drv_stat_unload(struct fsm_inst *fi, int pr, void *arg)
 	spin_unlock_irqrestore(&drivers_lock, flags);
 	put_drv(drv);
 
-	dev->channels -= drv->channels;
+	isdndev->channels -= drv->channels;
 
 	isdn_info_update();
 	return 0;
@@ -798,6 +803,7 @@ isdn_status_callback(isdn_ctrl *c)
 		case ISDN_STAT_AUDIO:
 			rc = fsm_event(&drv->fi, EV_STAT_AUDIO, c);
 			break;
+#warning FIXME divert interface
 #if 0
 		case ISDN_STAT_ICALL:
 			/* Find any ttyI, waiting for D-channel setup */
@@ -851,12 +857,6 @@ isdn_status_callback(isdn_ctrl *c)
                         if (divert_if)
 				divert_if->stat_callback(c); 
 			break;
-		case ISDN_STAT_BCONN:
-			break;
-		case ISDN_STAT_BHUP:
-			break;
-#endif
-#if 0 // FIXME
 		case ISDN_STAT_DISCH:
 			save_flags(flags);
 			cli();
@@ -899,7 +899,7 @@ register_isdn(isdn_if *iif)
 	unsigned long flags;
 	int drvidx;
 
-	drv = kmalloc(sizeof(*drv), GFP_KERNEL);
+	drv = kmalloc(sizeof(*drv), GFP_ATOMIC);
 	if (!drv) {
 		printk(KERN_WARNING "register_isdn: out of mem\n");
 		goto fail;
@@ -1264,13 +1264,13 @@ isdn_statstr(void)
 void
 isdn_info_update(void)
 {
-	infostruct *p = dev->infochain;
+	infostruct *p = isdndev->infochain;
 
 	while (p) {
 		*(p->private) = 1;
 		p = (infostruct *) p->next;
 	}
-	wake_up_interruptible(&(dev->info_waitq));
+	wake_up_interruptible(&(isdndev->info_waitq));
 }
 
 static int
@@ -1282,9 +1282,9 @@ isdn_status_open(struct inode *ino, struct file *filep)
 	if (!p)
 		return -ENOMEM;
 
-	p->next = (char *) dev->infochain;
+	p->next = (char *) isdndev->infochain;
 	p->private = (char *) &(filep->private_data);
-	dev->infochain = p;
+	isdndev->infochain = p;
 	/* At opening we allow a single update */
 	filep->private_data = (char *) 1;
 
@@ -1294,7 +1294,7 @@ isdn_status_open(struct inode *ino, struct file *filep)
 static int
 isdn_status_release(struct inode *ino, struct file *filep)
 {
-	infostruct *p = dev->infochain;
+	infostruct *p = isdndev->infochain;
 	infostruct *q = NULL;
 	
 	lock_kernel();
@@ -1304,7 +1304,7 @@ isdn_status_release(struct inode *ino, struct file *filep)
 			if (q)
 				q->next = p->next;
 			else
-				dev->infochain = (infostruct *) (p->next);
+				isdndev->infochain = (infostruct *) (p->next);
 			kfree(p);
 			goto out;
 		}
@@ -1331,7 +1331,7 @@ isdn_status_read(struct file *file, char *buf, size_t count, loff_t * off)
 	if (!file->private_data) {
 		if (file->f_flags & O_NONBLOCK)
 			return  -EAGAIN;
-		interruptible_sleep_on(&(dev->info_waitq));
+		interruptible_sleep_on(&(isdndev->info_waitq));
 	}
 	lock_kernel();
 	p = isdn_statstr();
@@ -1364,7 +1364,7 @@ isdn_status_poll(struct file *file, poll_table *wait)
 {
 	unsigned int mask = 0;
 
-	poll_wait(file, &(dev->info_waitq), wait);
+	poll_wait(file, &(isdndev->info_waitq), wait);
 	lock_kernel();
 	if (file->private_data)
 		mask |= POLLIN | POLLRDNORM;
@@ -1449,8 +1449,8 @@ isdn_ctrl_release(struct inode *ino, struct file *file)
 {
 	struct isdn_slot *slot = file->private_data;
 
-	if (dev->profd == current)
-		dev->profd = NULL;
+	if (isdndev->profd == current)
+		isdndev->profd = NULL;
 
 	isdn_unlock_driver(slot->drv);
 	put_slot(slot);
@@ -1590,15 +1590,15 @@ isdn_ctrl_ioctl(struct inode *inode, struct file *file, uint cmd, ulong arg)
 	case IIOCNETHUP:
 		return isdn_net_ioctl(inode, file, cmd, arg);
 	case IIOCSETVER:
-		dev->net_verbose = arg;
-		printk(KERN_INFO "isdn: Verbose-Level is %d\n", dev->net_verbose);
+		isdndev->net_verbose = arg;
+		printk(KERN_INFO "isdn: Verbose-Level is %d\n", isdndev->net_verbose);
 		return 0;
 	case IIOCSETGST:
 		if (arg) {
-			dev->global_flags |= ISDN_GLOBAL_STOPPED;
+			isdndev->global_flags |= ISDN_GLOBAL_STOPPED;
 			isdn_net_hangup_all();
 		} else {
-			dev->global_flags &= ~ISDN_GLOBAL_STOPPED;
+			isdndev->global_flags &= ~ISDN_GLOBAL_STOPPED;
 		}
 		return 0;
 	case IIOCSETBRJ:
@@ -1622,7 +1622,7 @@ isdn_ctrl_ioctl(struct inode *inode, struct file *file, uint cmd, ulong arg)
 			drivers[drvidx]->flags &= ~DRV_FLAG_REJBUS;
 		return 0;
 	case IIOCSIGPRF:
-		dev->profd = current;
+		isdndev->profd = current;
 		return 0;
 		break;
 	case IIOCGETPRF:
@@ -1738,7 +1738,7 @@ isdn_ctrl_ioctl(struct inode *inode, struct file *file, uint cmd, ulong arg)
 			return -EINVAL;
 	case IIOCDBGVAR:
 		if (arg) {
-			if (copy_to_user((char *) arg, (char *) &dev, sizeof(ulong)))
+			if (copy_to_user((char *) arg, (char *) &isdndev, sizeof(ulong)))
 				return -EFAULT;
 			return 0;
 		} else
@@ -1940,16 +1940,16 @@ isdn_add_channels(struct isdn_driver *drv, int n)
        	if (n < 1)
 		return 0;
 
-	if (dev->channels + n > ISDN_MAX_CHANNELS) {
+	if (isdndev->channels + n > ISDN_MAX_CHANNELS) {
 		printk(KERN_WARNING "register_isdn: Max. %d channels supported\n",
 		       ISDN_MAX_CHANNELS);
 		return -EBUSY;
 	}
-	dev->channels += n;
-	drv->slots = kmalloc(sizeof(struct isdn_slot) * n, GFP_KERNEL);
+	isdndev->channels += n;
+	drv->slots = kmalloc(sizeof(struct isdn_slot) * n, GFP_ATOMIC);
 	if (!drv->slots)
 		return -ENOMEM;
-	
+	memset(drv->slots, 0, sizeof(struct isdn_slot) * n);
 	for (ch = 0; ch < n; ch++) {
 		slot = drv->slots + ch;
 
@@ -1973,36 +1973,44 @@ isdn_add_channels(struct isdn_driver *drv, int n)
 
 #if defined(CONFIG_ISDN_DIVERSION) || defined(CONFIG_ISDN_DIVERSION_MODULE)
 
+/*
+ * map_drvname
+ */
 static char *map_drvname(int di)
 {
 	if ((di < 0) || (di >= ISDN_MAX_DRIVERS)) 
 		return(NULL);
-  return(dev->drvid[di]); /* driver name */
-} /* map_drvname */
+	return(isdndev->drvid[di]); /* driver name */
+}
 
+/*
+ * map_namedrv
+ */
 static int map_namedrv(char *id)
-{  int i;
+{
+	int i;
 
-   for (i = 0; i < ISDN_MAX_DRIVERS; i++)
-    { if (!strcmp(dev->drvid[i],id)) 
+	for (i = 0; i < ISDN_MAX_DRIVERS; i++) {
+		if (!strcmp(dev->drvid[i],id)) 
 			return(i);
 	}
 	return(-1);
-} /* map_namedrv */
+}
 
+/*
+ * DIVERT_REG_NAME
+ */
 int DIVERT_REG_NAME(isdn_divert_if *i_div)
 {
 	if (i_div->if_magic != DIVERT_IF_MAGIC) 
 		return(DIVERT_VER_ERR);
-  switch (i_div->cmd)
-    {
+	switch (i_div->cmd) {
 		case DIVERT_CMD_REL:
 			if (divert_if != i_div) 
 				return(DIVERT_REL_ERR);
 			divert_if = NULL; /* free interface */
 			MOD_DEC_USE_COUNT;
 			return(DIVERT_NO_ERR);
-
 		case DIVERT_CMD_REG:
 			if (divert_if) 
 				return(DIVERT_REG_ERR);
@@ -2012,11 +2020,10 @@ int DIVERT_REG_NAME(isdn_divert_if *i_div)
 			MOD_INC_USE_COUNT;
 			divert_if = i_div; /* remember interface */
 			return(DIVERT_NO_ERR);
-
 		default:
 			return(DIVERT_CMD_ERR);   
 	}
-} /* DIVERT_REG_NAME */
+}
 
 EXPORT_SYMBOL(DIVERT_REG_NAME);
 
@@ -2060,7 +2067,7 @@ isdn_slot_command(struct isdn_slot *slot, int cmd, isdn_ctrl *ctrl)
 		ctrl->arg &= ~0xff; ctrl->arg |= slot->ch;
 		break;
 	case ISDN_CMD_DIAL:
-		if (dev->global_flags & ISDN_GLOBAL_STOPPED)
+		if (isdndev->global_flags & ISDN_GLOBAL_STOPPED)
 			return -EBUSY;
 
 		/* fall through */
@@ -2200,14 +2207,14 @@ static int __init isdn_init(void)
 	if (retval)
 		goto err_slot_fsm;
 
-	dev = vmalloc(sizeof(*dev));
-	if (!dev) {
+	isdndev = vmalloc(sizeof(*isdndev));
+	if (!isdndev) {
 		retval = -ENOMEM;
 		goto err_drv_fsm;
 	}
-	memset(dev, 0, sizeof(*dev));
-	init_MUTEX(&dev->sem);
-	init_waitqueue_head(&dev->info_waitq);
+	memset(isdndev, 0, sizeof(*isdndev));
+	init_MUTEX(&isdndev->sem);
+	init_waitqueue_head(&isdndev->info_waitq);
 
 	retval = register_chrdev(ISDN_MAJOR, "isdn", &isdn_fops);
 	if (retval) {
@@ -2239,7 +2246,7 @@ static int __init isdn_init(void)
 	isdn_cleanup_devfs();
 	unregister_chrdev(ISDN_MAJOR, "isdn");
  err_vfree:
-	vfree(dev);
+	vfree(isdndev);
  err_drv_fsm:
 	fsm_free(&drv_fsm);
  err_slot_fsm:
@@ -2261,7 +2268,7 @@ static void __exit isdn_exit(void)
 	isdn_tty_exit();
 	unregister_chrdev(ISDN_MAJOR, "isdn");
 	isdn_cleanup_devfs();
-	vfree(dev);
+	vfree(isdndev);
 	fsm_free(&drv_fsm);
 	fsm_free(&slot_fsm);
 }

drivers/isdn/i4l/isdn_net_lib.c

@@ -837,7 +837,7 @@ isdn_net_force_hangup(char *name) // FIXME rename?
 	if (!idev)
 		return -ENODEV;
 
-	if (idev->isdn_slot < 0)
+	if (idev->isdn_slot == NULL)
 		return -ENOTCONN;
 
 	isdn_net_hangup(idev);
@@ -1186,7 +1186,7 @@ isdn_net_unbind_channel(isdn_net_dev *idev)
 {
 	isdn_net_local *mlp = idev->mlp;
 
-	if (idev->isdn_slot < 0) {
+	if (idev->isdn_slot == NULL) {
 		isdn_BUG();
 		return;
 	}
@@ -1344,7 +1344,7 @@ isdn_net_autodial(struct sk_buff *skb, struct net_device *ndev)
 		goto discard;
 
 	/* Log packet, which triggered dialing */
-	if (dev->net_verbose)
+	if ((get_isdn_dev())->net_verbose)
 		isdn_net_log_skb(skb, idev);
 
  stop_queue:
@@ -1502,6 +1502,7 @@ isdn_net_find_icall(struct isdn_slot *slot, setup_parm *setup)
 	char		*nr, *eaz;
 	unsigned char	si1, si2;
 	int		retval;
+	int		verbose = (get_isdn_dev())->net_verbose;
 	unsigned long	flags;
 
 	/* fix up calling number */
@@ -1522,14 +1523,14 @@ isdn_net_find_icall(struct isdn_slot *slot, setup_parm *setup)
 	}
 	si1 = setup->si1;
 	si2 = setup->si2;
-	if (dev->net_verbose > 1)
+	if (verbose > 1)
 		printk(KERN_INFO "isdn_net: call from %s,%d,%d -> %s\n", 
 		       nr, si1, si2, eaz);
 	/* check service indicator */
         /* Accept DATA and VOICE calls at this stage
 	   local eaz is checked later for allowed call types */
         if ((si1 != 7) && (si1 != 1)) {
-                if (dev->net_verbose > 1)
+                if (verbose > 1)
                         printk(KERN_INFO "isdn_net: "
 			       "Service-Indicator not 1 or 7, ignored\n");
                 return 0;
@@ -1558,7 +1559,7 @@ isdn_net_find_icall(struct isdn_slot *slot, setup_parm *setup)
 	}
 	spin_unlock_irqrestore(&running_devs_lock, flags);
 	if (!retval) {
-		if (dev->net_verbose)
+		if (verbose)
 			printk(KERN_INFO "isdn_net: call "
 			       "from %s -> %s ignored\n", nr, eaz);
 	}
@@ -2208,7 +2209,7 @@ isdn_net_start_xmit(struct sk_buff *skb, struct net_device *ndev)
 		idev->last_jiffies = jiffies;
 		idev->transcount = 0;
 	}
-	if (dev->net_verbose > 3)
+	if ((get_isdn_dev())->net_verbose > 3)
 		printk(KERN_DEBUG "%s: %d bogocps\n", idev->name, idev->cps);
 
 	if (idev->cps > mlp->triggercps) {

drivers/isdn/i4l/isdn_tty.c

@@ -381,7 +381,7 @@ isdn_tty_rcv_skb(struct isdn_slot *slot, struct sk_buff *skb)
 			    );
 	restore_flags(flags);
 	/* Schedule dequeuing */
-	if (dev->modempoll && info->rcvsched)
+	if ((get_isdn_dev())->modempoll && info->rcvsched)
 		mod_timer(&info->read_timer, jiffies + 4);
 	return 1;
 }
@@ -1735,8 +1735,10 @@ isdn_tty_open(struct tty_struct *tty, struct file *filp)
 	info = &isdn_mdm.info[line];
 	if (isdn_tty_paranoia_check(info, tty->name, "isdn_tty_open"))
 		return -ENODEV;
-	if (!try_module_get(info->owner))
+	if (!try_module_get(info->owner)) {
 		printk(KERN_WARNING "%s: cannot reserve module\n", __FUNCTION__);
+		return -ENODEV;
+	}
 #ifdef ISDN_DEBUG_MODEM_OPEN
 	printk(KERN_DEBUG "isdn_tty_open %s, count = %d\n", tty->name,
 	       info->count);
@@ -1766,7 +1768,7 @@ isdn_tty_open(struct tty_struct *tty, struct file *filp)
 #ifdef ISDN_DEBUG_MODEM_OPEN
 	printk(KERN_DEBUG "isdn_tty_open ttyi%d successful...\n", info->line);
 #endif
-	dev->modempoll++;
+	(get_isdn_dev())->modempoll++;
 #ifdef ISDN_DEBUG_MODEM_OPEN
 	printk(KERN_DEBUG "isdn_tty_open normal exit\n");
 #endif
@@ -1785,6 +1787,7 @@ isdn_tty_close(struct tty_struct *tty, struct file *filp)
 	if (isdn_tty_paranoia_check(info, tty->name, "isdn_tty_close"))
 		goto out;
 
+	#warning need fixing /kkeil
 	save_flags(flags);
 	cli();
 	if (tty_hung_up_p(filp)) {
@@ -1841,7 +1844,7 @@ isdn_tty_close(struct tty_struct *tty, struct file *filp)
 				break;
 		}
 	}
-	dev->modempoll--;
+	(get_isdn_dev())->modempoll--;
 	isdn_tty_shutdown(info);
 	if (tty->driver->flush_buffer)
 		tty->driver->flush_buffer(tty);
@@ -1985,8 +1988,8 @@ modem_write_profile(atemu * m)
 	memcpy(m->profile, m->mdmreg, ISDN_MODEM_NUMREG);
 	memcpy(m->pmsn, m->msn, ISDN_MSNLEN);
 	memcpy(m->plmsn, m->lmsn, ISDN_LMSNLEN);
-	if (dev->profd)
-		kill_pg_info(SIGIO, SEND_SIG_PRIV, dev->profd->pgrp);
+	if ((get_isdn_dev())->profd)
+		kill_pg_info(SIGIO, SEND_SIG_PRIV, (get_isdn_dev())->profd->pgrp);
 }
 
 static struct tty_operations modem_ops = {
@@ -2228,7 +2231,7 @@ isdn_tty_find_icall(struct isdn_slot *slot, setup_parm *setup)
 			printk(KERN_DEBUG "m_fi: match1 wret=%d\n", wret);
 			printk(KERN_DEBUG "m_fi: sl=%d flags=%08lx drv=%d ch=%d usg=%d\n", sl,
 			       info->flags, info->isdn_driver, info->isdn_channel,
-			       dev->usage[idx]);
+			       slot->usage);
 #endif
 			if (
 #ifndef FIX_FILE_TRANSFER
@@ -2504,7 +2507,7 @@ isdn_tty_at_cout(char *msg, modem_info * info)
 		isdn_tty_queue_tail(info, skb, skb->len);
 		restore_flags(flags);
 		/* Schedule dequeuing */
-		if (dev->modempoll && info->rcvsched)
+		if ((get_isdn_dev())->modempoll && info->rcvsched)
 			mod_timer(&info->read_timer, jiffies + 4);
 	} else {
 		restore_flags(flags);
@@ -3289,7 +3292,7 @@ isdn_tty_cmd_PLUSF(char **p, modem_info * info)
 #ifdef CONFIG_ISDN_TTY_FAX
 					case '1':
 						p[0]++;
-						if (!(dev->global_features &
+						if (!((get_isdn_dev())->global_features &
 							ISDN_FEATURE_L3_FCLASS1))
 							PARSE_ERROR1;
 						m->mdmreg[REG_SI1] = 1;
@@ -3300,7 +3303,7 @@ isdn_tty_cmd_PLUSF(char **p, modem_info * info)
 						break;
 					case '2':
 						p[0]++;
-						if (!(dev->global_features &
+						if (!((get_isdn_dev())->global_features &
 							ISDN_FEATURE_L3_FCLASS2))
 							PARSE_ERROR1;
 						m->mdmreg[REG_SI1] = 1;
@@ -3322,10 +3325,10 @@ isdn_tty_cmd_PLUSF(char **p, modem_info * info)
 						p[0]++;
 						strcpy(rs, "\r\n0,");
 #ifdef CONFIG_ISDN_TTY_FAX
-						if (dev->global_features &
+						if ((get_isdn_dev())->global_features &
 							ISDN_FEATURE_L3_FCLASS1)
 							strcat(rs, "1,");
-						if (dev->global_features &
+						if ((get_isdn_dev())->global_features &
 							ISDN_FEATURE_L3_FCLASS2)
 							strcat(rs, "2,");
 #endif

drivers/isdn/icn/icn.h

@@ -162,18 +162,18 @@ typedef struct icn_card {
 	char *msg_buf_end;      /* Pointer to end of statusbuffer   */
 	int sndcount[ICN_BCH];  /* Byte-counters for B-Ch.-send     */
 	int xlen[ICN_BCH];      /* Byte-counters/Flags for sent-ACK */
-	struct sk_buff *xskb[ICN_BCH];
-	                        /* Current transmitted skb          */
-	struct sk_buff_head
-	 spqueue[ICN_BCH];      /* Sendqueue                        */
+	struct sk_buff *xskb[ICN_BCH]; /* Current transmitted skb   */
+	struct sk_buff_head spqueue[ICN_BCH];  /* Sendqueue         */
 	char regname[35];       /* Name used for request_region     */
-	u_char xmit_lock[ICN_BCH];	/* Semaphore for pollbchan_send()   */
+	u_char xmit_lock[ICN_BCH]; /* Semaphore for pollbchan_send()*/
+	spinlock_t lock;        /* protect critical operations      */
 } icn_card;
 
 /*
  * Main driver data
  */
 typedef struct icn_dev {
+	spinlock_t devlock;     /* spinlock to protect this struct  */
 	unsigned long memaddr;	/* Address of memory mapped buffers */
 	icn_shmem *shmem;       /* Pointer to memory-mapped-buffers */
 	int mvalid;             /* IO-shmem has been requested      */

include/linux/isdn.h

@@ -385,9 +385,8 @@ typedef struct {
 } infostruct;
 
 /* Main driver-data */
-typedef struct isdn_devt {
+typedef struct _isdn_dev_t {
 	unsigned short		flags;		/* Bitmapped Flags:           */
-	/*                            */
 	int			channels;	/* Current number of channels */
 	int			net_verbose;	/* Verbose-Flag               */
 	int			modempoll;	/* Flag: tty-read active      */
@@ -399,10 +398,9 @@ typedef struct isdn_devt {
 	struct task_struct	*profd;		/* For iprofd                 */
 	struct semaphore	sem;		/* serialize list access*/
 	unsigned long		global_features; 
-} isdn_dev;
-
-extern isdn_dev *dev;
+} isdn_dev_t;
 
+extern isdn_dev_t	*get_isdn_dev(void);
 
 #endif /* __KERNEL__ */