Commit b3ca74a2 authored by Vladimir Berezniker's avatar Vladimir Berezniker Committed by Ingo Molnar

x86: sanitize user specified e820 memmap values

Sanitize user specified e820 memory ranges, using the same logic that is
applied to the values returned by the BIOS.  This ensures consistent
handling regardless of the source of the memory mappings.

Allows overriding portions of the memory map without specifying one in
it's entirety (memmap=exactmap).

E.g. marking a range of bad RAM as reserved with memmap=48M$528M

BIOS supplied range

BIOS-e820: 0000000000100000 - 000000007fe80000 (usable)

becomes

user: 0000000000100000 - 0000000021000000 (usable)
user: 0000000021000000 - 0000000024000000 (reserved)
user: 0000000024000000 - 000000007fe80000 (usable)

Previously this did not work, as the original BIOS range was left
untouched while the user defined range was appended to the end of the
memory map.

[ tglx: arch/x86 adaptation ]
Signed-off-by: default avatarVladimir Berezniker <vmpn@hitechman.com>
Signed-off-by: default avatarAndi Kleen <ak@suse.de>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent efd1ca52
...@@ -691,6 +691,8 @@ static int __init parse_memmap_opt(char *p) ...@@ -691,6 +691,8 @@ static int __init parse_memmap_opt(char *p)
mem_size = memparse(p, &p); mem_size = memparse(p, &p);
if (p == oldp) if (p == oldp)
return -EINVAL; return -EINVAL;
userdef = 1;
if (*p == '@') { if (*p == '@') {
start_at = memparse(p+1, &p); start_at = memparse(p+1, &p);
add_memory_region(start_at, mem_size, E820_RAM); add_memory_region(start_at, mem_size, E820_RAM);
...@@ -710,6 +712,12 @@ early_param("memmap", parse_memmap_opt); ...@@ -710,6 +712,12 @@ early_param("memmap", parse_memmap_opt);
void __init finish_e820_parsing(void) void __init finish_e820_parsing(void)
{ {
if (userdef) { if (userdef) {
char nr = e820.nr_map;
if (sanitize_e820_map(e820.map, &nr) < 0)
early_panic("Invalid user supplied memory map");
e820.nr_map = nr;
printk(KERN_INFO "user-defined physical RAM map:\n"); printk(KERN_INFO "user-defined physical RAM map:\n");
e820_print_map("user"); e820_print_map("user");
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment