Commit b3cde198 authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Walleij

pinctrl: sunxi: Testing the wrong variable

Smatch complains that we dereference "map" before testing it for NULL
which is true.  We should be testing "*map" instead.  Also on the error
path, we should free *map and set it to NULL.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarMaxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 04d02c7a
...@@ -398,13 +398,14 @@ static int sunxi_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev, ...@@ -398,13 +398,14 @@ static int sunxi_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
* map array * map array
*/ */
*map = krealloc(*map, i * sizeof(struct pinctrl_map), GFP_KERNEL); *map = krealloc(*map, i * sizeof(struct pinctrl_map), GFP_KERNEL);
if (!map) if (!*map)
return -ENOMEM; return -ENOMEM;
return 0; return 0;
err_free_map: err_free_map:
kfree(map); kfree(*map);
*map = NULL;
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment