Commit b5f54b07 authored by André Goddard Rosa's avatar André Goddard Rosa Committed by Linus Torvalds

parser: remove unnecessary strlen()

No functional change.  Cache strlen() result to avoid recalculating it up
to 3 times on the worst case.

Reduces code size a little by 32 bytes:
   text    data     bss     dec     hex filename
   1385       0       0    1385     569 lib/parser.o-BEFORE
   1353       0       0    1353     549 lib/parser.o-AFTER
Signed-off-by: default avatarAndré Goddard Rosa <andre.goddard@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e7d2860b
...@@ -56,13 +56,16 @@ static int match_one(char *s, const char *p, substring_t args[]) ...@@ -56,13 +56,16 @@ static int match_one(char *s, const char *p, substring_t args[])
args[argc].from = s; args[argc].from = s;
switch (*p++) { switch (*p++) {
case 's': case 's': {
if (strlen(s) == 0) size_t str_len = strlen(s);
if (str_len == 0)
return 0; return 0;
else if (len == -1 || len > strlen(s)) if (len == -1 || len > str_len)
len = strlen(s); len = str_len;
args[argc].to = s + len; args[argc].to = s + len;
break; break;
}
case 'd': case 'd':
simple_strtol(s, &args[argc].to, 0); simple_strtol(s, &args[argc].to, 0);
goto num; goto num;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment