Commit b7df4d1b authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Rusty Russell

module: Use __module_address() for module_address_lookup()

Use the generic __module_address() addr to struct module lookup
instead of open coding it once more.

Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent 6c9692e2
...@@ -3671,19 +3671,15 @@ const char *module_address_lookup(unsigned long addr, ...@@ -3671,19 +3671,15 @@ const char *module_address_lookup(unsigned long addr,
char **modname, char **modname,
char *namebuf) char *namebuf)
{ {
struct module *mod;
const char *ret = NULL; const char *ret = NULL;
struct module *mod;
preempt_disable(); preempt_disable();
list_for_each_entry_rcu(mod, &modules, list) { mod = __module_address(addr);
if (mod->state == MODULE_STATE_UNFORMED) if (mod) {
continue;
if (within_module(addr, mod)) {
if (modname) if (modname)
*modname = mod->name; *modname = mod->name;
ret = get_ksymbol(mod, addr, size, offset); ret = get_ksymbol(mod, addr, size, offset);
break;
}
} }
/* Make a copy in here where it's safe */ /* Make a copy in here where it's safe */
if (ret) { if (ret) {
...@@ -3691,6 +3687,7 @@ const char *module_address_lookup(unsigned long addr, ...@@ -3691,6 +3687,7 @@ const char *module_address_lookup(unsigned long addr,
ret = namebuf; ret = namebuf;
} }
preempt_enable(); preempt_enable();
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment