Commit bb132083 authored by Navid Emamdoost's avatar Navid Emamdoost Committed by David S. Miller

allocate_flower_entry: should check for null deref

allocate_flower_entry does not check for allocation success, but tries
to deref the result. I only moved the spin_lock under null check, because
 the caller is checking allocation's status at line 652.
Signed-off-by: default avatarNavid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4803d010
...@@ -67,6 +67,7 @@ static struct ch_tc_pedit_fields pedits[] = { ...@@ -67,6 +67,7 @@ static struct ch_tc_pedit_fields pedits[] = {
static struct ch_tc_flower_entry *allocate_flower_entry(void) static struct ch_tc_flower_entry *allocate_flower_entry(void)
{ {
struct ch_tc_flower_entry *new = kzalloc(sizeof(*new), GFP_KERNEL); struct ch_tc_flower_entry *new = kzalloc(sizeof(*new), GFP_KERNEL);
if (new)
spin_lock_init(&new->lock); spin_lock_init(&new->lock);
return new; return new;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment