Skip to content

L
linux
Commit bb887688 authored by Tony Lindgren's avatar Tony Lindgren
Browse files
Options

Merge branch 'for_3.4/cleanup/sr' of... 

Merge branch 'for_3.4/cleanup/sr' of git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm into sr
parents 149f1d5c 63371faf
Hide whitespace changes
Inline Side-by-side
Showing with 229 additions and 72 deletions
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
View file @ bb887688
...@@ -29,6 +29,7 @@ ...@@ -29,6 +29,7 @@
#include "omap_hwmod_common_data.h" #include "omap_hwmod_common_data.h"
#include "smartreflex.h"
#include "prm-regbits-34xx.h" #include "prm-regbits-34xx.h"
#include "cm-regbits-34xx.h" #include "cm-regbits-34xx.h"
#include "wd_timer.h" #include "wd_timer.h"
...@@ -376,6 +377,16 @@ static struct omap_hwmod_ocp_if omap3_l4_core__i2c3 = { ...@@ -376,6 +377,16 @@ static struct omap_hwmod_ocp_if omap3_l4_core__i2c3 = {
.user = OCP_USER_MPU | OCP_USER_SDMA, .user = OCP_USER_MPU | OCP_USER_SDMA,
}; };
static struct omap_hwmod_irq_info omap3_smartreflex_mpu_irqs[] = {
{ .irq = 18},
{ .irq = -1 }
};
static struct omap_hwmod_irq_info omap3_smartreflex_core_irqs[] = {
{ .irq = 19},
{ .irq = -1 }
};
/* L4 CORE -> SR1 interface */ /* L4 CORE -> SR1 interface */
static struct omap_hwmod_addr_space omap3_sr1_addr_space[] = { static struct omap_hwmod_addr_space omap3_sr1_addr_space[] = {
{ {
...@@ -2664,6 +2675,10 @@ static struct omap_hwmod_class omap36xx_smartreflex_hwmod_class = { ...@@ -2664,6 +2675,10 @@ static struct omap_hwmod_class omap36xx_smartreflex_hwmod_class = {
}; };
/* SR1 */ /* SR1 */
static struct omap_smartreflex_dev_attr sr1_dev_attr = {
.sensor_voltdm_name = "mpu_iva",
};
static struct omap_hwmod_ocp_if *omap3_sr1_slaves[] = { static struct omap_hwmod_ocp_if *omap3_sr1_slaves[] = {
&omap3_l4_core__sr1, &omap3_l4_core__sr1,
}; };
...@@ -2672,7 +2687,6 @@ static struct omap_hwmod omap34xx_sr1_hwmod = { ...@@ -2672,7 +2687,6 @@ static struct omap_hwmod omap34xx_sr1_hwmod = {
.name = "sr1_hwmod", .name = "sr1_hwmod",
.class = &omap34xx_smartreflex_hwmod_class, .class = &omap34xx_smartreflex_hwmod_class,
.main_clk = "sr1_fck", .main_clk = "sr1_fck",
.vdd_name = "mpu_iva",
.prcm = { .prcm = {
.omap2 = { .omap2 = {
.prcm_reg_id = 1, .prcm_reg_id = 1,
...@@ -2684,6 +2698,8 @@ static struct omap_hwmod omap34xx_sr1_hwmod = { ...@@ -2684,6 +2698,8 @@ static struct omap_hwmod omap34xx_sr1_hwmod = {
}, },
.slaves = omap3_sr1_slaves, .slaves = omap3_sr1_slaves,
.slaves_cnt = ARRAY_SIZE(omap3_sr1_slaves), .slaves_cnt = ARRAY_SIZE(omap3_sr1_slaves),
.dev_attr = &sr1_dev_attr,
.mpu_irqs = omap3_smartreflex_mpu_irqs,
.flags = HWMOD_SET_DEFAULT_CLOCKACT, .flags = HWMOD_SET_DEFAULT_CLOCKACT,
}; };
...@@ -2691,7 +2707,6 @@ static struct omap_hwmod omap36xx_sr1_hwmod = { ...@@ -2691,7 +2707,6 @@ static struct omap_hwmod omap36xx_sr1_hwmod = {
.name = "sr1_hwmod", .name = "sr1_hwmod",
.class = &omap36xx_smartreflex_hwmod_class, .class = &omap36xx_smartreflex_hwmod_class,
.main_clk = "sr1_fck", .main_clk = "sr1_fck",
.vdd_name = "mpu_iva",
.prcm = { .prcm = {
.omap2 = { .omap2 = {
.prcm_reg_id = 1, .prcm_reg_id = 1,
...@@ -2703,9 +2718,15 @@ static struct omap_hwmod omap36xx_sr1_hwmod = { ...@@ -2703,9 +2718,15 @@ static struct omap_hwmod omap36xx_sr1_hwmod = {
}, },
.slaves = omap3_sr1_slaves, .slaves = omap3_sr1_slaves,
.slaves_cnt = ARRAY_SIZE(omap3_sr1_slaves), .slaves_cnt = ARRAY_SIZE(omap3_sr1_slaves),
.dev_attr = &sr1_dev_attr,
.mpu_irqs = omap3_smartreflex_mpu_irqs,
}; };
/* SR2 */ /* SR2 */
static struct omap_smartreflex_dev_attr sr2_dev_attr = {
.sensor_voltdm_name = "core",
};
static struct omap_hwmod_ocp_if *omap3_sr2_slaves[] = { static struct omap_hwmod_ocp_if *omap3_sr2_slaves[] = {
&omap3_l4_core__sr2, &omap3_l4_core__sr2,
}; };
...@@ -2714,7 +2735,6 @@ static struct omap_hwmod omap34xx_sr2_hwmod = { ...@@ -2714,7 +2735,6 @@ static struct omap_hwmod omap34xx_sr2_hwmod = {
.name = "sr2_hwmod", .name = "sr2_hwmod",
.class = &omap34xx_smartreflex_hwmod_class, .class = &omap34xx_smartreflex_hwmod_class,
.main_clk = "sr2_fck", .main_clk = "sr2_fck",
.vdd_name = "core",
.prcm = { .prcm = {
.omap2 = { .omap2 = {
.prcm_reg_id = 1, .prcm_reg_id = 1,
...@@ -2726,6 +2746,8 @@ static struct omap_hwmod omap34xx_sr2_hwmod = { ...@@ -2726,6 +2746,8 @@ static struct omap_hwmod omap34xx_sr2_hwmod = {
}, },
.slaves = omap3_sr2_slaves, .slaves = omap3_sr2_slaves,
.slaves_cnt = ARRAY_SIZE(omap3_sr2_slaves), .slaves_cnt = ARRAY_SIZE(omap3_sr2_slaves),
.dev_attr = &sr2_dev_attr,
.mpu_irqs = omap3_smartreflex_core_irqs,
.flags = HWMOD_SET_DEFAULT_CLOCKACT, .flags = HWMOD_SET_DEFAULT_CLOCKACT,
}; };
...@@ -2733,7 +2755,6 @@ static struct omap_hwmod omap36xx_sr2_hwmod = { ...@@ -2733,7 +2755,6 @@ static struct omap_hwmod omap36xx_sr2_hwmod = {
.name = "sr2_hwmod", .name = "sr2_hwmod",
.class = &omap36xx_smartreflex_hwmod_class, .class = &omap36xx_smartreflex_hwmod_class,
.main_clk = "sr2_fck", .main_clk = "sr2_fck",
.vdd_name = "core",
.prcm = { .prcm = {
.omap2 = { .omap2 = {
.prcm_reg_id = 1, .prcm_reg_id = 1,
...@@ -2745,6 +2766,8 @@ static struct omap_hwmod omap36xx_sr2_hwmod = { ...@@ -2745,6 +2766,8 @@ static struct omap_hwmod omap36xx_sr2_hwmod = {
}, },
.slaves = omap3_sr2_slaves, .slaves = omap3_sr2_slaves,
.slaves_cnt = ARRAY_SIZE(omap3_sr2_slaves), .slaves_cnt = ARRAY_SIZE(omap3_sr2_slaves),
.dev_attr = &sr2_dev_attr,
.mpu_irqs = omap3_smartreflex_core_irqs,
}; };
/* /*
......
arch/arm/mach-omap2/omap_hwmod_44xx_data.c
View file @ bb887688
...@@ -34,6 +34,7 @@ ...@@ -34,6 +34,7 @@
#include "omap_hwmod_common_data.h" #include "omap_hwmod_common_data.h"
#include "smartreflex.h"
#include "cm1_44xx.h" #include "cm1_44xx.h"
#include "cm2_44xx.h" #include "cm2_44xx.h"
#include "prm44xx.h" #include "prm44xx.h"
...@@ -3963,6 +3964,10 @@ static struct omap_hwmod_class omap44xx_smartreflex_hwmod_class = { ...@@ -3963,6 +3964,10 @@ static struct omap_hwmod_class omap44xx_smartreflex_hwmod_class = {
}; };
/* smartreflex_core */ /* smartreflex_core */
static struct omap_smartreflex_dev_attr smartreflex_core_dev_attr = {
.sensor_voltdm_name = "core",
};
static struct omap_hwmod omap44xx_smartreflex_core_hwmod; static struct omap_hwmod omap44xx_smartreflex_core_hwmod;
static struct omap_hwmod_irq_info omap44xx_smartreflex_core_irqs[] = { static struct omap_hwmod_irq_info omap44xx_smartreflex_core_irqs[] = {
{ .irq = 19 + OMAP44XX_IRQ_GIC_START }, { .irq = 19 + OMAP44XX_IRQ_GIC_START },
...@@ -3999,7 +4004,6 @@ static struct omap_hwmod omap44xx_smartreflex_core_hwmod = { ...@@ -3999,7 +4004,6 @@ static struct omap_hwmod omap44xx_smartreflex_core_hwmod = {
.mpu_irqs = omap44xx_smartreflex_core_irqs, .mpu_irqs = omap44xx_smartreflex_core_irqs,
.main_clk = "smartreflex_core_fck", .main_clk = "smartreflex_core_fck",
.vdd_name = "core",
.prcm = { .prcm = {
.omap4 = { .omap4 = {
.clkctrl_offs = OMAP4_CM_ALWON_SR_CORE_CLKCTRL_OFFSET, .clkctrl_offs = OMAP4_CM_ALWON_SR_CORE_CLKCTRL_OFFSET,
...@@ -4009,9 +4013,14 @@ static struct omap_hwmod omap44xx_smartreflex_core_hwmod = { ...@@ -4009,9 +4013,14 @@ static struct omap_hwmod omap44xx_smartreflex_core_hwmod = {
}, },
.slaves = omap44xx_smartreflex_core_slaves, .slaves = omap44xx_smartreflex_core_slaves,
.slaves_cnt = ARRAY_SIZE(omap44xx_smartreflex_core_slaves), .slaves_cnt = ARRAY_SIZE(omap44xx_smartreflex_core_slaves),
.dev_attr = &smartreflex_core_dev_attr,
}; };
/* smartreflex_iva */ /* smartreflex_iva */
static struct omap_smartreflex_dev_attr smartreflex_iva_dev_attr = {
.sensor_voltdm_name = "iva",
};
static struct omap_hwmod omap44xx_smartreflex_iva_hwmod; static struct omap_hwmod omap44xx_smartreflex_iva_hwmod;
static struct omap_hwmod_irq_info omap44xx_smartreflex_iva_irqs[] = { static struct omap_hwmod_irq_info omap44xx_smartreflex_iva_irqs[] = {
{ .irq = 102 + OMAP44XX_IRQ_GIC_START }, { .irq = 102 + OMAP44XX_IRQ_GIC_START },
...@@ -4047,7 +4056,6 @@ static struct omap_hwmod omap44xx_smartreflex_iva_hwmod = { ...@@ -4047,7 +4056,6 @@ static struct omap_hwmod omap44xx_smartreflex_iva_hwmod = {
.clkdm_name = "l4_ao_clkdm", .clkdm_name = "l4_ao_clkdm",
.mpu_irqs = omap44xx_smartreflex_iva_irqs, .mpu_irqs = omap44xx_smartreflex_iva_irqs,
.main_clk = "smartreflex_iva_fck", .main_clk = "smartreflex_iva_fck",
.vdd_name = "iva",
.prcm = { .prcm = {
.omap4 = { .omap4 = {
.clkctrl_offs = OMAP4_CM_ALWON_SR_IVA_CLKCTRL_OFFSET, .clkctrl_offs = OMAP4_CM_ALWON_SR_IVA_CLKCTRL_OFFSET,
...@@ -4057,9 +4065,14 @@ static struct omap_hwmod omap44xx_smartreflex_iva_hwmod = { ...@@ -4057,9 +4065,14 @@ static struct omap_hwmod omap44xx_smartreflex_iva_hwmod = {
}, },
.slaves = omap44xx_smartreflex_iva_slaves, .slaves = omap44xx_smartreflex_iva_slaves,
.slaves_cnt = ARRAY_SIZE(omap44xx_smartreflex_iva_slaves), .slaves_cnt = ARRAY_SIZE(omap44xx_smartreflex_iva_slaves),
.dev_attr = &smartreflex_iva_dev_attr,
}; };
/* smartreflex_mpu */ /* smartreflex_mpu */
static struct omap_smartreflex_dev_attr smartreflex_mpu_dev_attr = {
.sensor_voltdm_name = "mpu",
};
static struct omap_hwmod omap44xx_smartreflex_mpu_hwmod; static struct omap_hwmod omap44xx_smartreflex_mpu_hwmod;
static struct omap_hwmod_irq_info omap44xx_smartreflex_mpu_irqs[] = { static struct omap_hwmod_irq_info omap44xx_smartreflex_mpu_irqs[] = {
{ .irq = 18 + OMAP44XX_IRQ_GIC_START }, { .irq = 18 + OMAP44XX_IRQ_GIC_START },
...@@ -4095,7 +4108,6 @@ static struct omap_hwmod omap44xx_smartreflex_mpu_hwmod = { ...@@ -4095,7 +4108,6 @@ static struct omap_hwmod omap44xx_smartreflex_mpu_hwmod = {
.clkdm_name = "l4_ao_clkdm", .clkdm_name = "l4_ao_clkdm",
.mpu_irqs = omap44xx_smartreflex_mpu_irqs, .mpu_irqs = omap44xx_smartreflex_mpu_irqs,
.main_clk = "smartreflex_mpu_fck", .main_clk = "smartreflex_mpu_fck",
.vdd_name = "mpu",
.prcm = { .prcm = {
.omap4 = { .omap4 = {
.clkctrl_offs = OMAP4_CM_ALWON_SR_MPU_CLKCTRL_OFFSET, .clkctrl_offs = OMAP4_CM_ALWON_SR_MPU_CLKCTRL_OFFSET,
...@@ -4105,6 +4117,7 @@ static struct omap_hwmod omap44xx_smartreflex_mpu_hwmod = { ...@@ -4105,6 +4117,7 @@ static struct omap_hwmod omap44xx_smartreflex_mpu_hwmod = {
}, },
.slaves = omap44xx_smartreflex_mpu_slaves, .slaves = omap44xx_smartreflex_mpu_slaves,
.slaves_cnt = ARRAY_SIZE(omap44xx_smartreflex_mpu_slaves), .slaves_cnt = ARRAY_SIZE(omap44xx_smartreflex_mpu_slaves),
.dev_attr = &smartreflex_mpu_dev_attr,
}; };
/* /*
......
arch/arm/mach-omap2/smartreflex-class3.c
View file @ bb887688
...@@ -29,6 +29,7 @@ static int sr_class3_enable(struct voltagedomain *voltdm) ...@@ -29,6 +29,7 @@ static int sr_class3_enable(struct voltagedomain *voltdm)
static int sr_class3_disable(struct voltagedomain *voltdm, int is_volt_reset) static int sr_class3_disable(struct voltagedomain *voltdm, int is_volt_reset)
{ {
sr_disable_errgen(voltdm);
omap_vp_disable(voltdm); omap_vp_disable(voltdm);
sr_disable(voltdm); sr_disable(voltdm);
if (is_volt_reset) if (is_volt_reset)
......
arch/arm/mach-omap2/smartreflex.c
View file @ bb887688
...@@ -36,6 +36,12 @@ ...@@ -36,6 +36,12 @@
#define SR_DISABLE_TIMEOUT 200 #define SR_DISABLE_TIMEOUT 200
struct omap_sr { struct omap_sr {
struct list_head node;
struct platform_device *pdev;
struct omap_sr_nvalue_table *nvalue_table;
struct voltagedomain *voltdm;
struct dentry *dbg_dir;
unsigned int irq;
int srid; int srid;
int ip_type; int ip_type;
int nvalue_count; int nvalue_count;
...@@ -49,13 +55,7 @@ struct omap_sr { ...@@ -49,13 +55,7 @@ struct omap_sr {
u32 senp_avgweight; u32 senp_avgweight;
u32 senp_mod; u32 senp_mod;
u32 senn_mod; u32 senn_mod;
unsigned int irq;
void __iomem *base; void __iomem *base;
struct platform_device *pdev;
struct list_head node;
struct omap_sr_nvalue_table *nvalue_table;
struct voltagedomain *voltdm;
struct dentry *dbg_dir;
}; };
/* sr_list contains all the instances of smartreflex module */ /* sr_list contains all the instances of smartreflex module */
...@@ -74,10 +74,6 @@ static inline void sr_modify_reg(struct omap_sr *sr, unsigned offset, u32 mask, ...@@ -74,10 +74,6 @@ static inline void sr_modify_reg(struct omap_sr *sr, unsigned offset, u32 mask,
u32 value) u32 value)
{ {
u32 reg_val; u32 reg_val;
u32 errconfig_offs = 0, errconfig_mask = 0;
reg_val = __raw_readl(sr->base + offset);
reg_val &= ~mask;
/* /*
* Smartreflex error config register is special as it contains * Smartreflex error config register is special as it contains
...@@ -88,16 +84,15 @@ static inline void sr_modify_reg(struct omap_sr *sr, unsigned offset, u32 mask, ...@@ -88,16 +84,15 @@ static inline void sr_modify_reg(struct omap_sr *sr, unsigned offset, u32 mask,
* if they are currently set, but does allow the caller to write * if they are currently set, but does allow the caller to write
* those bits. * those bits.
*/ */
if (sr->ip_type == SR_TYPE_V1) { if (sr->ip_type == SR_TYPE_V1 && offset == ERRCONFIG_V1)
errconfig_offs = ERRCONFIG_V1; mask |= ERRCONFIG_STATUS_V1_MASK;
errconfig_mask = ERRCONFIG_STATUS_V1_MASK; else if (sr->ip_type == SR_TYPE_V2 && offset == ERRCONFIG_V2)
} else if (sr->ip_type == SR_TYPE_V2) { mask |= ERRCONFIG_VPBOUNDINTST_V2;
errconfig_offs = ERRCONFIG_V2;
errconfig_mask = ERRCONFIG_VPBOUNDINTST_V2; reg_val = __raw_readl(sr->base + offset);
} reg_val &= ~mask;
if (offset == errconfig_offs) value &= mask;
reg_val &= ~errconfig_mask;
reg_val |= value; reg_val |= value;
...@@ -128,21 +123,28 @@ static struct omap_sr *_sr_lookup(struct voltagedomain *voltdm) ...@@ -128,21 +123,28 @@ static struct omap_sr *_sr_lookup(struct voltagedomain *voltdm)
static irqreturn_t sr_interrupt(int irq, void *data) static irqreturn_t sr_interrupt(int irq, void *data)
{ {
struct omap_sr *sr_info = (struct omap_sr *)data; struct omap_sr *sr_info = data;
u32 status = 0; u32 status = 0;
if (sr_info->ip_type == SR_TYPE_V1) { switch (sr_info->ip_type) {
case SR_TYPE_V1:
/* Read the status bits */ /* Read the status bits */
status = sr_read_reg(sr_info, ERRCONFIG_V1); status = sr_read_reg(sr_info, ERRCONFIG_V1);
/* Clear them by writing back */ /* Clear them by writing back */
sr_write_reg(sr_info, ERRCONFIG_V1, status); sr_write_reg(sr_info, ERRCONFIG_V1, status);
} else if (sr_info->ip_type == SR_TYPE_V2) { break;
case SR_TYPE_V2:
/* Read the status bits */ /* Read the status bits */
status = sr_read_reg(sr_info, IRQSTATUS); status = sr_read_reg(sr_info, IRQSTATUS);
/* Clear them by writing back */ /* Clear them by writing back */
sr_write_reg(sr_info, IRQSTATUS, status); sr_write_reg(sr_info, IRQSTATUS, status);
break;
default:
dev_err(&sr_info->pdev->dev, "UNKNOWN IP type %d\n",
sr_info->ip_type);
return IRQ_NONE;
} }
if (sr_class->notify) if (sr_class->notify)
...@@ -166,6 +168,7 @@ static void sr_set_clk_length(struct omap_sr *sr) ...@@ -166,6 +168,7 @@ static void sr_set_clk_length(struct omap_sr *sr)
__func__); __func__);
return; return;
} }
sys_clk_speed = clk_get_rate(sys_ck); sys_clk_speed = clk_get_rate(sys_ck);
clk_put(sys_ck); clk_put(sys_ck);
...@@ -267,7 +270,7 @@ static int sr_late_init(struct omap_sr *sr_info) ...@@ -267,7 +270,7 @@ static int sr_late_init(struct omap_sr *sr_info)
goto error; goto error;
} }
ret = request_irq(sr_info->irq, sr_interrupt, ret = request_irq(sr_info->irq, sr_interrupt,
0, name, (void *)sr_info); 0, name, sr_info);
if (ret) if (ret)
goto error; goto error;
disable_irq(sr_info->irq); disable_irq(sr_info->irq);
...@@ -288,12 +291,15 @@ static int sr_late_init(struct omap_sr *sr_info) ...@@ -288,12 +291,15 @@ static int sr_late_init(struct omap_sr *sr_info)
"not function as desired\n", __func__); "not function as desired\n", __func__);
kfree(name); kfree(name);
kfree(sr_info); kfree(sr_info);
return ret; return ret;
} }
static void sr_v1_disable(struct omap_sr *sr) static void sr_v1_disable(struct omap_sr *sr)
{ {
int timeout = 0; int timeout = 0;
int errconf_val = ERRCONFIG_MCUACCUMINTST | ERRCONFIG_MCUVALIDINTST |
ERRCONFIG_MCUBOUNDINTST;
/* Enable MCUDisableAcknowledge interrupt */ /* Enable MCUDisableAcknowledge interrupt */
sr_modify_reg(sr, ERRCONFIG_V1, sr_modify_reg(sr, ERRCONFIG_V1,
...@@ -302,13 +308,13 @@ static void sr_v1_disable(struct omap_sr *sr) ...@@ -302,13 +308,13 @@ static void sr_v1_disable(struct omap_sr *sr)
/* SRCONFIG - disable SR */ /* SRCONFIG - disable SR */
sr_modify_reg(sr, SRCONFIG, SRCONFIG_SRENABLE, 0x0); sr_modify_reg(sr, SRCONFIG, SRCONFIG_SRENABLE, 0x0);
/* Disable all other SR interrupts and clear the status */ /* Disable all other SR interrupts and clear the status as needed */
if (sr_read_reg(sr, ERRCONFIG_V1) & ERRCONFIG_VPBOUNDINTST_V1)
errconf_val |= ERRCONFIG_VPBOUNDINTST_V1;
sr_modify_reg(sr, ERRCONFIG_V1, sr_modify_reg(sr, ERRCONFIG_V1,
(ERRCONFIG_MCUACCUMINTEN | ERRCONFIG_MCUVALIDINTEN | (ERRCONFIG_MCUACCUMINTEN | ERRCONFIG_MCUVALIDINTEN |
ERRCONFIG_MCUBOUNDINTEN | ERRCONFIG_VPBOUNDINTEN_V1), ERRCONFIG_MCUBOUNDINTEN | ERRCONFIG_VPBOUNDINTEN_V1),
(ERRCONFIG_MCUACCUMINTST | ERRCONFIG_MCUVALIDINTST | errconf_val);
ERRCONFIG_MCUBOUNDINTST |
ERRCONFIG_VPBOUNDINTST_V1));
/* /*
* Wait for SR to be disabled. * Wait for SR to be disabled.
...@@ -337,9 +343,17 @@ static void sr_v2_disable(struct omap_sr *sr) ...@@ -337,9 +343,17 @@ static void sr_v2_disable(struct omap_sr *sr)
/* SRCONFIG - disable SR */ /* SRCONFIG - disable SR */
sr_modify_reg(sr, SRCONFIG, SRCONFIG_SRENABLE, 0x0); sr_modify_reg(sr, SRCONFIG, SRCONFIG_SRENABLE, 0x0);
/* Disable all other SR interrupts and clear the status */ /*
sr_modify_reg(sr, ERRCONFIG_V2, ERRCONFIG_VPBOUNDINTEN_V2, * Disable all other SR interrupts and clear the status
* write to status register ONLY on need basis - only if status
* is set.
*/
if (sr_read_reg(sr, ERRCONFIG_V2) & ERRCONFIG_VPBOUNDINTST_V2)
sr_modify_reg(sr, ERRCONFIG_V2, ERRCONFIG_VPBOUNDINTEN_V2,
ERRCONFIG_VPBOUNDINTST_V2); ERRCONFIG_VPBOUNDINTST_V2);
else
sr_modify_reg(sr, ERRCONFIG_V2, ERRCONFIG_VPBOUNDINTEN_V2,
0x0);
sr_write_reg(sr, IRQENABLE_CLR, (IRQENABLE_MCUACCUMINT | sr_write_reg(sr, IRQENABLE_CLR, (IRQENABLE_MCUACCUMINT |
IRQENABLE_MCUVALIDINT | IRQENABLE_MCUVALIDINT |
IRQENABLE_MCUBOUNDSINT)); IRQENABLE_MCUBOUNDSINT));
...@@ -398,15 +412,16 @@ static u32 sr_retrieve_nvalue(struct omap_sr *sr, u32 efuse_offs) ...@@ -398,15 +412,16 @@ static u32 sr_retrieve_nvalue(struct omap_sr *sr, u32 efuse_offs)
*/ */
int sr_configure_errgen(struct voltagedomain *voltdm) int sr_configure_errgen(struct voltagedomain *voltdm)
{ {
u32 sr_config, sr_errconfig, errconfig_offs, vpboundint_en; u32 sr_config, sr_errconfig, errconfig_offs;
u32 vpboundint_st, senp_en = 0, senn_en = 0; u32 vpboundint_en, vpboundint_st;
u32 senp_en = 0, senn_en = 0;
u8 senp_shift, senn_shift; u8 senp_shift, senn_shift;
struct omap_sr *sr = _sr_lookup(voltdm); struct omap_sr *sr = _sr_lookup(voltdm);
if (IS_ERR(sr)) { if (IS_ERR(sr)) {
pr_warning("%s: omap_sr struct for sr_%s not found\n", pr_warning("%s: omap_sr struct for sr_%s not found\n",
__func__, voltdm->name); __func__, voltdm->name);
return -EINVAL; return PTR_ERR(sr);
} }
if (!sr->clk_length) if (!sr->clk_length)
...@@ -418,20 +433,23 @@ int sr_configure_errgen(struct voltagedomain *voltdm) ...@@ -418,20 +433,23 @@ int sr_configure_errgen(struct voltagedomain *voltdm)
sr_config = (sr->clk_length << SRCONFIG_SRCLKLENGTH_SHIFT) | sr_config = (sr->clk_length << SRCONFIG_SRCLKLENGTH_SHIFT) |
SRCONFIG_SENENABLE | SRCONFIG_ERRGEN_EN; SRCONFIG_SENENABLE | SRCONFIG_ERRGEN_EN;
if (sr->ip_type == SR_TYPE_V1) { switch (sr->ip_type) {
case SR_TYPE_V1:
sr_config |= SRCONFIG_DELAYCTRL; sr_config |= SRCONFIG_DELAYCTRL;
senn_shift = SRCONFIG_SENNENABLE_V1_SHIFT; senn_shift = SRCONFIG_SENNENABLE_V1_SHIFT;
senp_shift = SRCONFIG_SENPENABLE_V1_SHIFT; senp_shift = SRCONFIG_SENPENABLE_V1_SHIFT;
errconfig_offs = ERRCONFIG_V1; errconfig_offs = ERRCONFIG_V1;
vpboundint_en = ERRCONFIG_VPBOUNDINTEN_V1; vpboundint_en = ERRCONFIG_VPBOUNDINTEN_V1;
vpboundint_st = ERRCONFIG_VPBOUNDINTST_V1; vpboundint_st = ERRCONFIG_VPBOUNDINTST_V1;
} else if (sr->ip_type == SR_TYPE_V2) { break;
case SR_TYPE_V2:
senn_shift = SRCONFIG_SENNENABLE_V2_SHIFT; senn_shift = SRCONFIG_SENNENABLE_V2_SHIFT;
senp_shift = SRCONFIG_SENPENABLE_V2_SHIFT; senp_shift = SRCONFIG_SENPENABLE_V2_SHIFT;
errconfig_offs = ERRCONFIG_V2; errconfig_offs = ERRCONFIG_V2;
vpboundint_en = ERRCONFIG_VPBOUNDINTEN_V2; vpboundint_en = ERRCONFIG_VPBOUNDINTEN_V2;
vpboundint_st = ERRCONFIG_VPBOUNDINTST_V2; vpboundint_st = ERRCONFIG_VPBOUNDINTST_V2;
} else { break;
default:
dev_err(&sr->pdev->dev, "%s: Trying to Configure smartreflex" dev_err(&sr->pdev->dev, "%s: Trying to Configure smartreflex"
"module without specifying the ip\n", __func__); "module without specifying the ip\n", __func__);
return -EINVAL; return -EINVAL;
...@@ -447,8 +465,55 @@ int sr_configure_errgen(struct voltagedomain *voltdm) ...@@ -447,8 +465,55 @@ int sr_configure_errgen(struct voltagedomain *voltdm)
sr_errconfig); sr_errconfig);
/* Enabling the interrupts if the ERROR module is used */ /* Enabling the interrupts if the ERROR module is used */
sr_modify_reg(sr, errconfig_offs, sr_modify_reg(sr, errconfig_offs, (vpboundint_en | vpboundint_st),
vpboundint_en, (vpboundint_en | vpboundint_st)); vpboundint_en);
return 0;
}
/**
* sr_disable_errgen() - Disables SmartReflex AVS module's errgen component
* @voltdm: VDD pointer to which the SR module to be configured belongs to.
*
* This API is to be called from the smartreflex class driver to
* disable the error generator module inside the smartreflex module.
*
* Returns 0 on success and error value in case of failure.
*/
int sr_disable_errgen(struct voltagedomain *voltdm)
{
u32 errconfig_offs;
u32 vpboundint_en, vpboundint_st;
struct omap_sr *sr = _sr_lookup(voltdm);
if (IS_ERR(sr)) {
pr_warning("%s: omap_sr struct for sr_%s not found\n",
__func__, voltdm->name);
return PTR_ERR(sr);
}
switch (sr->ip_type) {
case SR_TYPE_V1:
errconfig_offs = ERRCONFIG_V1;
vpboundint_en = ERRCONFIG_VPBOUNDINTEN_V1;
vpboundint_st = ERRCONFIG_VPBOUNDINTST_V1;
break;
case SR_TYPE_V2:
errconfig_offs = ERRCONFIG_V2;
vpboundint_en = ERRCONFIG_VPBOUNDINTEN_V2;
vpboundint_st = ERRCONFIG_VPBOUNDINTST_V2;
break;
default:
dev_err(&sr->pdev->dev, "%s: Trying to Configure smartreflex"
"module without specifying the ip\n", __func__);
return -EINVAL;
}
/* Disable the interrupts of ERROR module */
sr_modify_reg(sr, errconfig_offs, vpboundint_en | vpboundint_st, 0);
/* Disable the Sensor and errorgen */
sr_modify_reg(sr, SRCONFIG, SRCONFIG_SENENABLE | SRCONFIG_ERRGEN_EN, 0);
return 0; return 0;
} }
...@@ -475,7 +540,7 @@ int sr_configure_minmax(struct voltagedomain *voltdm) ...@@ -475,7 +540,7 @@ int sr_configure_minmax(struct voltagedomain *voltdm)
if (IS_ERR(sr)) { if (IS_ERR(sr)) {
pr_warning("%s: omap_sr struct for sr_%s not found\n", pr_warning("%s: omap_sr struct for sr_%s not found\n",
__func__, voltdm->name); __func__, voltdm->name);
return -EINVAL; return PTR_ERR(sr);
} }
if (!sr->clk_length) if (!sr->clk_length)
...@@ -488,14 +553,17 @@ int sr_configure_minmax(struct voltagedomain *voltdm) ...@@ -488,14 +553,17 @@ int sr_configure_minmax(struct voltagedomain *voltdm)
SRCONFIG_SENENABLE | SRCONFIG_SENENABLE |
(sr->accum_data << SRCONFIG_ACCUMDATA_SHIFT); (sr->accum_data << SRCONFIG_ACCUMDATA_SHIFT);
if (sr->ip_type == SR_TYPE_V1) { switch (sr->ip_type) {
case SR_TYPE_V1:
sr_config |= SRCONFIG_DELAYCTRL; sr_config |= SRCONFIG_DELAYCTRL;
senn_shift = SRCONFIG_SENNENABLE_V1_SHIFT; senn_shift = SRCONFIG_SENNENABLE_V1_SHIFT;
senp_shift = SRCONFIG_SENPENABLE_V1_SHIFT; senp_shift = SRCONFIG_SENPENABLE_V1_SHIFT;
} else if (sr->ip_type == SR_TYPE_V2) { break;
case SR_TYPE_V2:
senn_shift = SRCONFIG_SENNENABLE_V2_SHIFT; senn_shift = SRCONFIG_SENNENABLE_V2_SHIFT;
senp_shift = SRCONFIG_SENPENABLE_V2_SHIFT; senp_shift = SRCONFIG_SENPENABLE_V2_SHIFT;
} else { break;
default:
dev_err(&sr->pdev->dev, "%s: Trying to Configure smartreflex" dev_err(&sr->pdev->dev, "%s: Trying to Configure smartreflex"
"module without specifying the ip\n", __func__); "module without specifying the ip\n", __func__);
return -EINVAL; return -EINVAL;
...@@ -511,20 +579,27 @@ int sr_configure_minmax(struct voltagedomain *voltdm) ...@@ -511,20 +579,27 @@ int sr_configure_minmax(struct voltagedomain *voltdm)
* Enabling the interrupts if MINMAXAVG module is used. * Enabling the interrupts if MINMAXAVG module is used.
* TODO: check if all the interrupts are mandatory * TODO: check if all the interrupts are mandatory
*/ */
if (sr->ip_type == SR_TYPE_V1) { switch (sr->ip_type) {
case SR_TYPE_V1:
sr_modify_reg(sr, ERRCONFIG_V1, sr_modify_reg(sr, ERRCONFIG_V1,
(ERRCONFIG_MCUACCUMINTEN | ERRCONFIG_MCUVALIDINTEN | (ERRCONFIG_MCUACCUMINTEN | ERRCONFIG_MCUVALIDINTEN |
ERRCONFIG_MCUBOUNDINTEN), ERRCONFIG_MCUBOUNDINTEN),
(ERRCONFIG_MCUACCUMINTEN | ERRCONFIG_MCUACCUMINTST | (ERRCONFIG_MCUACCUMINTEN | ERRCONFIG_MCUACCUMINTST |
ERRCONFIG_MCUVALIDINTEN | ERRCONFIG_MCUVALIDINTST | ERRCONFIG_MCUVALIDINTEN | ERRCONFIG_MCUVALIDINTST |
ERRCONFIG_MCUBOUNDINTEN | ERRCONFIG_MCUBOUNDINTST)); ERRCONFIG_MCUBOUNDINTEN | ERRCONFIG_MCUBOUNDINTST));
} else if (sr->ip_type == SR_TYPE_V2) { break;
case SR_TYPE_V2:
sr_write_reg(sr, IRQSTATUS, sr_write_reg(sr, IRQSTATUS,
IRQSTATUS_MCUACCUMINT | IRQSTATUS_MCVALIDINT | IRQSTATUS_MCUACCUMINT | IRQSTATUS_MCVALIDINT |
IRQSTATUS_MCBOUNDSINT | IRQSTATUS_MCUDISABLEACKINT); IRQSTATUS_MCBOUNDSINT | IRQSTATUS_MCUDISABLEACKINT);
sr_write_reg(sr, IRQENABLE_SET, sr_write_reg(sr, IRQENABLE_SET,
IRQENABLE_MCUACCUMINT | IRQENABLE_MCUVALIDINT | IRQENABLE_MCUACCUMINT | IRQENABLE_MCUVALIDINT |
IRQENABLE_MCUBOUNDSINT | IRQENABLE_MCUDISABLEACKINT); IRQENABLE_MCUBOUNDSINT | IRQENABLE_MCUDISABLEACKINT);
break;
default:
dev_err(&sr->pdev->dev, "%s: Trying to Configure smartreflex"
"module without specifying the ip\n", __func__);
return -EINVAL;
} }
return 0; return 0;
...@@ -543,15 +618,15 @@ int sr_configure_minmax(struct voltagedomain *voltdm) ...@@ -543,15 +618,15 @@ int sr_configure_minmax(struct voltagedomain *voltdm)
*/ */
int sr_enable(struct voltagedomain *voltdm, unsigned long volt) int sr_enable(struct voltagedomain *voltdm, unsigned long volt)
{ {
u32 nvalue_reciprocal;
struct omap_volt_data *volt_data; struct omap_volt_data *volt_data;
struct omap_sr *sr = _sr_lookup(voltdm); struct omap_sr *sr = _sr_lookup(voltdm);
u32 nvalue_reciprocal;
int ret; int ret;
if (IS_ERR(sr)) { if (IS_ERR(sr)) {
pr_warning("%s: omap_sr struct for sr_%s not found\n", pr_warning("%s: omap_sr struct for sr_%s not found\n",
__func__, voltdm->name); __func__, voltdm->name);
return -EINVAL; return PTR_ERR(sr);
} }
volt_data = omap_voltage_get_voltdata(sr->voltdm, volt); volt_data = omap_voltage_get_voltdata(sr->voltdm, volt);
...@@ -559,7 +634,7 @@ int sr_enable(struct voltagedomain *voltdm, unsigned long volt) ...@@ -559,7 +634,7 @@ int sr_enable(struct voltagedomain *voltdm, unsigned long volt)
if (IS_ERR(volt_data)) { if (IS_ERR(volt_data)) {
dev_warn(&sr->pdev->dev, "%s: Unable to get voltage table" dev_warn(&sr->pdev->dev, "%s: Unable to get voltage table"
"for nominal voltage %ld\n", __func__, volt); "for nominal voltage %ld\n", __func__, volt);
return -ENODATA; return PTR_ERR(volt_data);
} }
nvalue_reciprocal = sr_retrieve_nvalue(sr, volt_data->sr_efuse_offs); nvalue_reciprocal = sr_retrieve_nvalue(sr, volt_data->sr_efuse_offs);
...@@ -617,10 +692,17 @@ void sr_disable(struct voltagedomain *voltdm) ...@@ -617,10 +692,17 @@ void sr_disable(struct voltagedomain *voltdm)
* disable the clocks. * disable the clocks.
*/ */
if (sr_read_reg(sr, SRCONFIG) & SRCONFIG_SRENABLE) { if (sr_read_reg(sr, SRCONFIG) & SRCONFIG_SRENABLE) {
if (sr->ip_type == SR_TYPE_V1) switch (sr->ip_type) {
case SR_TYPE_V1:
sr_v1_disable(sr); sr_v1_disable(sr);
else if (sr->ip_type == SR_TYPE_V2) break;
case SR_TYPE_V2:
sr_v2_disable(sr); sr_v2_disable(sr);
break;
default:
dev_err(&sr->pdev->dev, "UNKNOWN IP type %d\n",
sr->ip_type);
}
} }
pm_runtime_put_sync_suspend(&sr->pdev->dev); pm_runtime_put_sync_suspend(&sr->pdev->dev);
...@@ -779,10 +861,10 @@ void omap_sr_register_pmic(struct omap_sr_pmic_data *pmic_data) ...@@ -779,10 +861,10 @@ void omap_sr_register_pmic(struct omap_sr_pmic_data *pmic_data)
sr_pmic_data = pmic_data; sr_pmic_data = pmic_data;
} }
/* PM Debug Fs enteries to enable disable smartreflex. */ /* PM Debug FS entries to enable and disable smartreflex. */
static int omap_sr_autocomp_show(void *data, u64 *val) static int omap_sr_autocomp_show(void *data, u64 *val)
{ {
struct omap_sr *sr_info = (struct omap_sr *) data; struct omap_sr *sr_info = data;
if (!sr_info) { if (!sr_info) {
pr_warning("%s: omap_sr struct not found\n", __func__); pr_warning("%s: omap_sr struct not found\n", __func__);
...@@ -796,7 +878,7 @@ static int omap_sr_autocomp_show(void *data, u64 *val) ...@@ -796,7 +878,7 @@ static int omap_sr_autocomp_show(void *data, u64 *val)
static int omap_sr_autocomp_store(void *data, u64 val) static int omap_sr_autocomp_store(void *data, u64 val)
{ {
struct omap_sr *sr_info = (struct omap_sr *) data; struct omap_sr *sr_info = data;
if (!sr_info) { if (!sr_info) {
pr_warning("%s: omap_sr struct not found\n", __func__); pr_warning("%s: omap_sr struct not found\n", __func__);
...@@ -804,7 +886,7 @@ static int omap_sr_autocomp_store(void *data, u64 val) ...@@ -804,7 +886,7 @@ static int omap_sr_autocomp_store(void *data, u64 val)
} }
/* Sanity check */ /* Sanity check */
if (val && (val != 1)) { if (val > 1) {
pr_warning("%s: Invalid argument %lld\n", __func__, val); pr_warning("%s: Invalid argument %lld\n", __func__, val);
return -EINVAL; return -EINVAL;
} }
...@@ -821,11 +903,11 @@ static int omap_sr_autocomp_store(void *data, u64 val) ...@@ -821,11 +903,11 @@ static int omap_sr_autocomp_store(void *data, u64 val)
} }
DEFINE_SIMPLE_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, DEFINE_SIMPLE_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show,
omap_sr_autocomp_store, "%llu\n"); omap_sr_autocomp_store, "%llu\n");
static int __init omap_sr_probe(struct platform_device *pdev) static int __init omap_sr_probe(struct platform_device *pdev)
{ {
struct omap_sr *sr_info = kzalloc(sizeof(struct omap_sr), GFP_KERNEL); struct omap_sr *sr_info;
struct omap_sr_data *pdata = pdev->dev.platform_data; struct omap_sr_data *pdata = pdev->dev.platform_data;
struct resource *mem, *irq; struct resource *mem, *irq;
struct dentry *nvalue_dir; struct dentry *nvalue_dir;
...@@ -833,12 +915,15 @@ static int __init omap_sr_probe(struct platform_device *pdev) ...@@ -833,12 +915,15 @@ static int __init omap_sr_probe(struct platform_device *pdev)
int i, ret = 0; int i, ret = 0;
char *name; char *name;
sr_info = kzalloc(sizeof(struct omap_sr), GFP_KERNEL);
if (!sr_info) { if (!sr_info) {
dev_err(&pdev->dev, "%s: unable to allocate sr_info\n", dev_err(&pdev->dev, "%s: unable to allocate sr_info\n",
__func__); __func__);
return -ENOMEM; return -ENOMEM;
} }
platform_set_drvdata(pdev, sr_info);
if (!pdata) { if (!pdata) {
dev_err(&pdev->dev, "%s: platform data missing\n", __func__); dev_err(&pdev->dev, "%s: platform data missing\n", __func__);
ret = -EINVAL; ret = -EINVAL;
...@@ -904,7 +989,7 @@ static int __init omap_sr_probe(struct platform_device *pdev) ...@@ -904,7 +989,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
dev_info(&pdev->dev, "%s: SmartReflex driver initialized\n", __func__); dev_info(&pdev->dev, "%s: SmartReflex driver initialized\n", __func__);
if (!sr_dbg_dir) { if (!sr_dbg_dir) {
sr_dbg_dir = debugfs_create_dir("smartreflex", NULL); sr_dbg_dir = debugfs_create_dir("smartreflex", NULL);
if (!sr_dbg_dir) { if (IS_ERR_OR_NULL(sr_dbg_dir)) {
ret = PTR_ERR(sr_dbg_dir); ret = PTR_ERR(sr_dbg_dir);
pr_err("%s:sr debugfs dir creation failed(%d)\n", pr_err("%s:sr debugfs dir creation failed(%d)\n",
__func__, ret); __func__, ret);
...@@ -921,7 +1006,7 @@ static int __init omap_sr_probe(struct platform_device *pdev) ...@@ -921,7 +1006,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
} }
sr_info->dbg_dir = debugfs_create_dir(name, sr_dbg_dir); sr_info->dbg_dir = debugfs_create_dir(name, sr_dbg_dir);
kfree(name); kfree(name);
if (IS_ERR(sr_info->dbg_dir)) { if (IS_ERR_OR_NULL(sr_info->dbg_dir)) {
dev_err(&pdev->dev, "%s: Unable to create debugfs directory\n", dev_err(&pdev->dev, "%s: Unable to create debugfs directory\n",
__func__); __func__);
ret = PTR_ERR(sr_info->dbg_dir); ret = PTR_ERR(sr_info->dbg_dir);
...@@ -938,7 +1023,7 @@ static int __init omap_sr_probe(struct platform_device *pdev) ...@@ -938,7 +1023,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
&sr_info->err_minlimit); &sr_info->err_minlimit);
nvalue_dir = debugfs_create_dir("nvalue", sr_info->dbg_dir); nvalue_dir = debugfs_create_dir("nvalue", sr_info->dbg_dir);
if (IS_ERR(nvalue_dir)) { if (IS_ERR_OR_NULL(nvalue_dir)) {
dev_err(&pdev->dev, "%s: Unable to create debugfs directory" dev_err(&pdev->dev, "%s: Unable to create debugfs directory"
"for n-values\n", __func__); "for n-values\n", __func__);
ret = PTR_ERR(nvalue_dir); ret = PTR_ERR(nvalue_dir);
...@@ -994,7 +1079,7 @@ static int __devexit omap_sr_remove(struct platform_device *pdev) ...@@ -994,7 +1079,7 @@ static int __devexit omap_sr_remove(struct platform_device *pdev)
if (IS_ERR(sr_info)) { if (IS_ERR(sr_info)) {
dev_warn(&pdev->dev, "%s: omap_sr struct not found\n", dev_warn(&pdev->dev, "%s: omap_sr struct not found\n",
__func__); __func__);
return -EINVAL; return PTR_ERR(sr_info);
} }
if (sr_info->autocomp_active) if (sr_info->autocomp_active)
...@@ -1011,8 +1096,32 @@ static int __devexit omap_sr_remove(struct platform_device *pdev) ...@@ -1011,8 +1096,32 @@ static int __devexit omap_sr_remove(struct platform_device *pdev)
return 0; return 0;
} }
static void __devexit omap_sr_shutdown(struct platform_device *pdev)
{
struct omap_sr_data *pdata = pdev->dev.platform_data;
struct omap_sr *sr_info;
if (!pdata) {
dev_err(&pdev->dev, "%s: platform data missing\n", __func__);
return;
}
sr_info = _sr_lookup(pdata->voltdm);
if (IS_ERR(sr_info)) {
dev_warn(&pdev->dev, "%s: omap_sr struct not found\n",
__func__);
return;
}
if (sr_info->autocomp_active)
sr_stop_vddautocomp(sr_info);
return;
}
static struct platform_driver smartreflex_driver = { static struct platform_driver smartreflex_driver = {
.remove = __devexit_p(omap_sr_remove), .remove = __devexit_p(omap_sr_remove),
.shutdown = __devexit_p(omap_sr_shutdown),
.driver = { .driver = {
.name = "smartreflex", .name = "smartreflex",
}, },
...@@ -1042,12 +1151,12 @@ static int __init sr_init(void) ...@@ -1042,12 +1151,12 @@ static int __init sr_init(void)
return 0; return 0;
} }
late_initcall(sr_init);
static void __exit sr_exit(void) static void __exit sr_exit(void)
{ {
platform_driver_unregister(&smartreflex_driver); platform_driver_unregister(&smartreflex_driver);
} }
late_initcall(sr_init);
module_exit(sr_exit); module_exit(sr_exit);
MODULE_DESCRIPTION("OMAP Smartreflex Driver"); MODULE_DESCRIPTION("OMAP Smartreflex Driver");
......
arch/arm/mach-omap2/smartreflex.h
View file @ bb887688
...@@ -152,6 +152,15 @@ struct omap_sr_pmic_data { ...@@ -152,6 +152,15 @@ struct omap_sr_pmic_data {
void (*sr_pmic_init) (void); void (*sr_pmic_init) (void);
}; };
/**
* struct omap_smartreflex_dev_attr - Smartreflex Device attribute.
*
* @sensor_voltdm_name: Name of voltdomain of SR instance
*/
struct omap_smartreflex_dev_attr {
const char *sensor_voltdm_name;
};
#ifdef CONFIG_OMAP_SMARTREFLEX #ifdef CONFIG_OMAP_SMARTREFLEX
/* /*
* The smart reflex driver supports CLASS1 CLASS2 and CLASS3 SR. * The smart reflex driver supports CLASS1 CLASS2 and CLASS3 SR.
...@@ -231,6 +240,7 @@ void omap_sr_register_pmic(struct omap_sr_pmic_data *pmic_data); ...@@ -231,6 +240,7 @@ void omap_sr_register_pmic(struct omap_sr_pmic_data *pmic_data);
int sr_enable(struct voltagedomain *voltdm, unsigned long volt); int sr_enable(struct voltagedomain *voltdm, unsigned long volt);
void sr_disable(struct voltagedomain *voltdm); void sr_disable(struct voltagedomain *voltdm);
int sr_configure_errgen(struct voltagedomain *voltdm); int sr_configure_errgen(struct voltagedomain *voltdm);
int sr_disable_errgen(struct voltagedomain *voltdm);
int sr_configure_minmax(struct voltagedomain *voltdm); int sr_configure_minmax(struct voltagedomain *voltdm);
/* API to register the smartreflex class driver with the smartreflex driver */ /* API to register the smartreflex class driver with the smartreflex driver */
......
arch/arm/mach-omap2/sr_device.c
View file @ bb887688
...@@ -74,6 +74,7 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user) ...@@ -74,6 +74,7 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user)
struct omap_sr_data *sr_data; struct omap_sr_data *sr_data;
struct platform_device *pdev; struct platform_device *pdev;
struct omap_volt_data *volt_data; struct omap_volt_data *volt_data;
struct omap_smartreflex_dev_attr *sr_dev_attr;
char *name = "smartreflex"; char *name = "smartreflex";
static int i; static int i;
...@@ -84,9 +85,11 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user) ...@@ -84,9 +85,11 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user)
return -ENOMEM; return -ENOMEM;
} }
if (!oh->vdd_name) { sr_dev_attr = (struct omap_smartreflex_dev_attr *)oh->dev_attr;
if (!sr_dev_attr || !sr_dev_attr->sensor_voltdm_name) {
pr_err("%s: No voltage domain specified for %s." pr_err("%s: No voltage domain specified for %s."
"Cannot initialize\n", __func__, oh->name); "Cannot initialize\n", __func__,
oh->name);
goto exit; goto exit;
} }
...@@ -94,10 +97,10 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user) ...@@ -94,10 +97,10 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user)
sr_data->senn_mod = 0x1; sr_data->senn_mod = 0x1;
sr_data->senp_mod = 0x1; sr_data->senp_mod = 0x1;
sr_data->voltdm = voltdm_lookup(oh->vdd_name); sr_data->voltdm = voltdm_lookup(sr_dev_attr->sensor_voltdm_name);
if (IS_ERR(sr_data->voltdm)) { if (IS_ERR(sr_data->voltdm)) {
pr_err("%s: Unable to get voltage domain pointer for VDD %s\n", pr_err("%s: Unable to get voltage domain pointer for VDD %s\n",
__func__, oh->vdd_name); __func__, sr_dev_attr->sensor_voltdm_name);
goto exit; goto exit;
} }
......
arch/arm/plat-omap/include/plat/omap_hwmod.h
View file @ bb887688
...@@ -484,7 +484,6 @@ struct omap_hwmod_class { ...@@ -484,7 +484,6 @@ struct omap_hwmod_class {
* @main_clk: main clock: OMAP clock name * @main_clk: main clock: OMAP clock name
* @_clk: pointer to the main struct clk (filled in at runtime) * @_clk: pointer to the main struct clk (filled in at runtime)
* @opt_clks: other device clocks that drivers can request (0..*) * @opt_clks: other device clocks that drivers can request (0..*)
* @vdd_name: voltage domain name
* @voltdm: pointer to voltage domain (filled in at runtime) * @voltdm: pointer to voltage domain (filled in at runtime)
* @masters: ptr to array of OCP ifs that this hwmod can initiate on * @masters: ptr to array of OCP ifs that this hwmod can initiate on
* @slaves: ptr to array of OCP ifs that this hwmod can respond on * @slaves: ptr to array of OCP ifs that this hwmod can respond on
...@@ -528,7 +527,6 @@ struct omap_hwmod { ...@@ -528,7 +527,6 @@ struct omap_hwmod {
struct omap_hwmod_opt_clk *opt_clks; struct omap_hwmod_opt_clk *opt_clks;
char *clkdm_name; char *clkdm_name;
struct clockdomain *clkdm; struct clockdomain *clkdm;
char *vdd_name;
struct omap_hwmod_ocp_if **masters; /* connect to *_IA */ struct omap_hwmod_ocp_if **masters; /* connect to *_IA */
struct omap_hwmod_ocp_if **slaves; /* connect to *_TA */ struct omap_hwmod_ocp_if **slaves; /* connect to *_TA */
void *dev_attr; void *dev_attr;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7