Commit bdcb2c9e authored by Alexander Gordeev's avatar Alexander Gordeev Committed by Kalle Valo

ath10k: Get rid of superfluous call to pci_disable_msi()

The documentation states that pci_enable_msi_block() returns the number of
requests 'could have been allocated', not 'could allocate'. IOW, MSIs are *not*
enabled if a positive value returned.

kvalo: add commit log based on Alexander's email
Signed-off-by: default avatarAlexander Gordeev <agordeev@redhat.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 716ae53c
...@@ -2532,8 +2532,6 @@ static int ath10k_pci_init_irq(struct ath10k *ar) ...@@ -2532,8 +2532,6 @@ static int ath10k_pci_init_irq(struct ath10k *ar)
ret = pci_enable_msi_block(ar_pci->pdev, ar_pci->num_msi_intrs); ret = pci_enable_msi_block(ar_pci->pdev, ar_pci->num_msi_intrs);
if (ret == 0) if (ret == 0)
return 0; return 0;
if (ret > 0)
pci_disable_msi(ar_pci->pdev);
/* fall-through */ /* fall-through */
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment