Commit c3a5c77a authored by Wei Yang's avatar Wei Yang Committed by Linus Torvalds

lib/show_mem.c: drop pgdat_resize_lock in show_mem()

Function show_mem() is used to print system memory status when user
requires or fail to allocate memory.  Generally, this is a best effort
information so any races with memory hotplug (or very theoretically an
early initialization) should be tolerable and the worst that could happen
is to print an imprecise node state.

Drop the resize lock because this is the only place which might hold the
lock from the interrupt context and so all other callers might use a
simple spinlock.  Even though this doesn't solve any real issue it makes
the code easier to follow and tiny more effective.

Link: http://lkml.kernel.org/r/20181129235532.9328-1-richard.weiyang@gmail.comSigned-off-by: default avatarWei Yang <richard.weiyang@gmail.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Reviewed-by: default avatarOscar Salvador <osalvador@suse.de>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0ecea993
...@@ -18,10 +18,8 @@ void show_mem(unsigned int filter, nodemask_t *nodemask) ...@@ -18,10 +18,8 @@ void show_mem(unsigned int filter, nodemask_t *nodemask)
show_free_areas(filter, nodemask); show_free_areas(filter, nodemask);
for_each_online_pgdat(pgdat) { for_each_online_pgdat(pgdat) {
unsigned long flags;
int zoneid; int zoneid;
pgdat_resize_lock(pgdat, &flags);
for (zoneid = 0; zoneid < MAX_NR_ZONES; zoneid++) { for (zoneid = 0; zoneid < MAX_NR_ZONES; zoneid++) {
struct zone *zone = &pgdat->node_zones[zoneid]; struct zone *zone = &pgdat->node_zones[zoneid];
if (!populated_zone(zone)) if (!populated_zone(zone))
...@@ -33,7 +31,6 @@ void show_mem(unsigned int filter, nodemask_t *nodemask) ...@@ -33,7 +31,6 @@ void show_mem(unsigned int filter, nodemask_t *nodemask)
if (is_highmem_idx(zoneid)) if (is_highmem_idx(zoneid))
highmem += zone->present_pages; highmem += zone->present_pages;
} }
pgdat_resize_unlock(pgdat, &flags);
} }
printk("%lu pages RAM\n", total); printk("%lu pages RAM\n", total);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment