Commit c436f68b authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Miquel Raynal

mtd: rawnand: oxnas: Add of_node_put()

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a goto from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put under a new goto to put
the node at a loop exit.
Issue found with Coccinelle.
Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent 4902e87f
...@@ -116,7 +116,7 @@ static int oxnas_nand_probe(struct platform_device *pdev) ...@@ -116,7 +116,7 @@ static int oxnas_nand_probe(struct platform_device *pdev)
GFP_KERNEL); GFP_KERNEL);
if (!chip) { if (!chip) {
err = -ENOMEM; err = -ENOMEM;
goto err_clk_unprepare; goto err_release_child;
} }
chip->controller = &oxnas->base; chip->controller = &oxnas->base;
...@@ -137,12 +137,12 @@ static int oxnas_nand_probe(struct platform_device *pdev) ...@@ -137,12 +137,12 @@ static int oxnas_nand_probe(struct platform_device *pdev)
/* Scan to find existence of the device */ /* Scan to find existence of the device */
err = nand_scan(chip, 1); err = nand_scan(chip, 1);
if (err) if (err)
goto err_clk_unprepare; goto err_release_child;
err = mtd_device_register(mtd, NULL, 0); err = mtd_device_register(mtd, NULL, 0);
if (err) { if (err) {
nand_release(chip); nand_release(chip);
goto err_clk_unprepare; goto err_release_child;
} }
oxnas->chips[nchips] = chip; oxnas->chips[nchips] = chip;
...@@ -159,6 +159,8 @@ static int oxnas_nand_probe(struct platform_device *pdev) ...@@ -159,6 +159,8 @@ static int oxnas_nand_probe(struct platform_device *pdev)
return 0; return 0;
err_release_child:
of_node_put(nand_np);
err_clk_unprepare: err_clk_unprepare:
clk_disable_unprepare(oxnas->clk); clk_disable_unprepare(oxnas->clk);
return err; return err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment