Commit c85c35f8 authored by Steve French's avatar Steve French

Fix warning on impossible comparison

workstation_RFC1001_name is part of the struct and can't be null,
remove impossible comparison (array vs. null)

Pointed out by Coverity (CID 140095)
Signed-off-by: default avatarSteve French <smfrench@gmail.com>
Reviewed-by: default avatarJeff Layton <jlayton@samba.org>
parent 064bcc07
...@@ -2917,8 +2917,7 @@ ip_rfc1001_connect(struct TCP_Server_Info *server) ...@@ -2917,8 +2917,7 @@ ip_rfc1001_connect(struct TCP_Server_Info *server)
* calling name ends in null (byte 16) from old smb * calling name ends in null (byte 16) from old smb
* convention. * convention.
*/ */
if (server->workstation_RFC1001_name && if (server->workstation_RFC1001_name[0] != 0)
server->workstation_RFC1001_name[0] != 0)
rfc1002mangle(ses_init_buf->trailer. rfc1002mangle(ses_init_buf->trailer.
session_req.calling_name, session_req.calling_name,
server->workstation_RFC1001_name, server->workstation_RFC1001_name,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment