Commit cb106d2a authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

qxl: check for kmap failures

commit f4cceb2a upstream.

If kmap fails, it leads to memory corruption.

Fixes: f64122c1 ('drm: add new QXL driver. (v1.4)')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20160711084633.GA31411@mwandaSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3010fb28
...@@ -136,6 +136,8 @@ static int qxl_palette_create_1bit(struct qxl_bo *palette_bo, ...@@ -136,6 +136,8 @@ static int qxl_palette_create_1bit(struct qxl_bo *palette_bo,
* correctly globaly, since that would require * correctly globaly, since that would require
* tracking all of our palettes. */ * tracking all of our palettes. */
ret = qxl_bo_kmap(palette_bo, (void **)&pal); ret = qxl_bo_kmap(palette_bo, (void **)&pal);
if (ret)
return ret;
pal->num_ents = 2; pal->num_ents = 2;
pal->unique = unique++; pal->unique = unique++;
if (visual == FB_VISUAL_TRUECOLOR || visual == FB_VISUAL_DIRECTCOLOR) { if (visual == FB_VISUAL_TRUECOLOR || visual == FB_VISUAL_DIRECTCOLOR) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment