Commit ccb8470e authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds

[PATCH] readahead: cleanup blockable_page_cache_readahead()

I think that do_page_cache_readahead() can be inlined in
blockable_page_cache_readahead(), this makes the code a bit more readable in
my opinion.

Also makes check_ra_success() static inline.
Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent b07c7787
...@@ -348,8 +348,8 @@ int force_page_cache_readahead(struct address_space *mapping, struct file *filp, ...@@ -348,8 +348,8 @@ int force_page_cache_readahead(struct address_space *mapping, struct file *filp,
* readahead isn't helping. * readahead isn't helping.
* *
*/ */
int check_ra_success(struct file_ra_state *ra, unsigned long nr_to_read, static inline int check_ra_success(struct file_ra_state *ra,
unsigned long actual) unsigned long nr_to_read, unsigned long actual)
{ {
if (actual == 0) { if (actual == 0) {
ra->cache_hit += nr_to_read; ra->cache_hit += nr_to_read;
...@@ -394,15 +394,11 @@ blockable_page_cache_readahead(struct address_space *mapping, struct file *filp, ...@@ -394,15 +394,11 @@ blockable_page_cache_readahead(struct address_space *mapping, struct file *filp,
{ {
int actual; int actual;
if (block) { if (!block && bdi_read_congested(mapping->backing_dev_info))
actual = __do_page_cache_readahead(mapping, filp,
offset, nr_to_read);
} else {
actual = do_page_cache_readahead(mapping, filp,
offset, nr_to_read);
if (actual == -1)
return 0; return 0;
}
actual = __do_page_cache_readahead(mapping, filp, offset, nr_to_read);
return check_ra_success(ra, nr_to_read, actual); return check_ra_success(ra, nr_to_read, actual);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment