Commit cf7e44da authored by Kaaira Gupta's avatar Kaaira Gupta Committed by Greg Kroah-Hartman

staging: qlge: add braces on all arms of if-else

fix all checkpatch.pl warnings of 'braces {} should be used on all arms
of this statement' in the file qlge_ethtool.c by adding the braces.
Acked-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarKaaira Gupta <kgupta@es.iitr.ac.in>
Link: https://lore.kernel.org/r/20200221202904.GA19627@kaaira-HP-Pavilion-NotebookSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 86c468a4
...@@ -259,8 +259,9 @@ static void ql_update_stats(struct ql_adapter *qdev) ...@@ -259,8 +259,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
"Error reading status register 0x%.04x.\n", "Error reading status register 0x%.04x.\n",
i); i);
goto end; goto end;
} else } else {
*iter = data; *iter = data;
}
iter++; iter++;
} }
...@@ -273,8 +274,9 @@ static void ql_update_stats(struct ql_adapter *qdev) ...@@ -273,8 +274,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
"Error reading status register 0x%.04x.\n", "Error reading status register 0x%.04x.\n",
i); i);
goto end; goto end;
} else } else {
*iter = data; *iter = data;
}
iter++; iter++;
} }
...@@ -290,8 +292,9 @@ static void ql_update_stats(struct ql_adapter *qdev) ...@@ -290,8 +292,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
"Error reading status register 0x%.04x.\n", "Error reading status register 0x%.04x.\n",
i); i);
goto end; goto end;
} else } else {
*iter = data; *iter = data;
}
iter++; iter++;
} }
...@@ -304,8 +307,9 @@ static void ql_update_stats(struct ql_adapter *qdev) ...@@ -304,8 +307,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
"Error reading status register 0x%.04x.\n", "Error reading status register 0x%.04x.\n",
i); i);
goto end; goto end;
} else } else {
*iter = data; *iter = data;
}
iter++; iter++;
} }
...@@ -316,8 +320,9 @@ static void ql_update_stats(struct ql_adapter *qdev) ...@@ -316,8 +320,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
netif_err(qdev, drv, qdev->ndev, netif_err(qdev, drv, qdev->ndev,
"Error reading status register 0x%.04x.\n", i); "Error reading status register 0x%.04x.\n", i);
goto end; goto end;
} else } else {
*iter = data; *iter = data;
}
end: end:
ql_sem_unlock(qdev, qdev->xg_sem_mask); ql_sem_unlock(qdev, qdev->xg_sem_mask);
quit: quit:
...@@ -488,8 +493,9 @@ static int ql_start_loopback(struct ql_adapter *qdev) ...@@ -488,8 +493,9 @@ static int ql_start_loopback(struct ql_adapter *qdev)
if (netif_carrier_ok(qdev->ndev)) { if (netif_carrier_ok(qdev->ndev)) {
set_bit(QL_LB_LINK_UP, &qdev->flags); set_bit(QL_LB_LINK_UP, &qdev->flags);
netif_carrier_off(qdev->ndev); netif_carrier_off(qdev->ndev);
} else } else {
clear_bit(QL_LB_LINK_UP, &qdev->flags); clear_bit(QL_LB_LINK_UP, &qdev->flags);
}
qdev->link_config |= CFG_LOOPBACK_PCS; qdev->link_config |= CFG_LOOPBACK_PCS;
return ql_mb_set_port_cfg(qdev); return ql_mb_set_port_cfg(qdev);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment