Commit d284feaf authored by Fuqian Huang's avatar Fuqian Huang Committed by Jonathan Cameron

iio: imu: mpu6050: Replace devm_add_action() followed by failure action with...

iio: imu: mpu6050: Replace devm_add_action() followed by failure action with devm_add_action_or_reset()

devm_add_action_or_reset() is introduced as a helper function which
internally calls devm_add_action(). If devm_add_action() fails
then it will execute the action mentioned and return the error code.
This reduce source code size (avoid writing the action twice)
and reduce the likelyhood of bugs.
Signed-off-by: default avatarFuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 46916ded
...@@ -1096,10 +1096,9 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, ...@@ -1096,10 +1096,9 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name,
if (result) if (result)
return result; return result;
result = devm_add_action(dev, inv_mpu_core_disable_regulator_action, result = devm_add_action_or_reset(dev, inv_mpu_core_disable_regulator_action,
st); st);
if (result) { if (result) {
inv_mpu_core_disable_regulator_action(st);
dev_err(dev, "Failed to setup regulator cleanup action %d\n", dev_err(dev, "Failed to setup regulator cleanup action %d\n",
result); result);
return result; return result;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment