Commit d28d8513 authored by Dan Williams's avatar Dan Williams Committed by Chris Wright

[PATCH] arm: fix handling of svc mode undefined instructions

Now that do_undefinstr handles kernel and user mode undefined
instruction exceptions it must not assume that interrupts are enabled at
entry.

Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
Signed-off-by: default avatarChris Wright <chrisw@sous-sol.org>
parent dc470419
...@@ -273,6 +273,7 @@ asmlinkage void do_undefinstr(struct pt_regs *regs) ...@@ -273,6 +273,7 @@ asmlinkage void do_undefinstr(struct pt_regs *regs)
struct undef_hook *hook; struct undef_hook *hook;
siginfo_t info; siginfo_t info;
void __user *pc; void __user *pc;
unsigned long flags;
/* /*
* According to the ARM ARM, PC is 2 or 4 bytes ahead, * According to the ARM ARM, PC is 2 or 4 bytes ahead,
...@@ -291,7 +292,7 @@ asmlinkage void do_undefinstr(struct pt_regs *regs) ...@@ -291,7 +292,7 @@ asmlinkage void do_undefinstr(struct pt_regs *regs)
get_user(instr, (u32 __user *)pc); get_user(instr, (u32 __user *)pc);
} }
spin_lock_irq(&undef_lock); spin_lock_irqsave(&undef_lock, flags);
list_for_each_entry(hook, &undef_hook, node) { list_for_each_entry(hook, &undef_hook, node) {
if ((instr & hook->instr_mask) == hook->instr_val && if ((instr & hook->instr_mask) == hook->instr_val &&
(regs->ARM_cpsr & hook->cpsr_mask) == hook->cpsr_val) { (regs->ARM_cpsr & hook->cpsr_mask) == hook->cpsr_val) {
...@@ -301,7 +302,7 @@ asmlinkage void do_undefinstr(struct pt_regs *regs) ...@@ -301,7 +302,7 @@ asmlinkage void do_undefinstr(struct pt_regs *regs)
} }
} }
} }
spin_unlock_irq(&undef_lock); spin_unlock_irqrestore(&undef_lock, flags);
#ifdef CONFIG_DEBUG_USER #ifdef CONFIG_DEBUG_USER
if (user_debug & UDBG_UNDEFINED) { if (user_debug & UDBG_UNDEFINED) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment