Commit d35b8dd9 authored by Gui Jianfeng's avatar Gui Jianfeng Committed by Avi Kivity

KVM: Fix mmu shrinker error

kvm_mmu_remove_one_alloc_mmu_page() assumes kvm_mmu_zap_page() only reclaims
only one sp, but that's not the case. This will cause mmu shrinker returns
a wrong number. This patch fix the counting error.
Signed-off-by: default avatarGui Jianfeng <guijianfeng@cn.fujitsu.com>
Signed-off-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
parent 5a7388c2
...@@ -2902,13 +2902,13 @@ void kvm_mmu_zap_all(struct kvm *kvm) ...@@ -2902,13 +2902,13 @@ void kvm_mmu_zap_all(struct kvm *kvm)
kvm_flush_remote_tlbs(kvm); kvm_flush_remote_tlbs(kvm);
} }
static void kvm_mmu_remove_one_alloc_mmu_page(struct kvm *kvm) static int kvm_mmu_remove_some_alloc_mmu_pages(struct kvm *kvm)
{ {
struct kvm_mmu_page *page; struct kvm_mmu_page *page;
page = container_of(kvm->arch.active_mmu_pages.prev, page = container_of(kvm->arch.active_mmu_pages.prev,
struct kvm_mmu_page, link); struct kvm_mmu_page, link);
kvm_mmu_zap_page(kvm, page); return kvm_mmu_zap_page(kvm, page) + 1;
} }
static int mmu_shrink(int nr_to_scan, gfp_t gfp_mask) static int mmu_shrink(int nr_to_scan, gfp_t gfp_mask)
...@@ -2920,7 +2920,7 @@ static int mmu_shrink(int nr_to_scan, gfp_t gfp_mask) ...@@ -2920,7 +2920,7 @@ static int mmu_shrink(int nr_to_scan, gfp_t gfp_mask)
spin_lock(&kvm_lock); spin_lock(&kvm_lock);
list_for_each_entry(kvm, &vm_list, vm_list) { list_for_each_entry(kvm, &vm_list, vm_list) {
int npages, idx; int npages, idx, freed_pages;
idx = srcu_read_lock(&kvm->srcu); idx = srcu_read_lock(&kvm->srcu);
spin_lock(&kvm->mmu_lock); spin_lock(&kvm->mmu_lock);
...@@ -2928,8 +2928,8 @@ static int mmu_shrink(int nr_to_scan, gfp_t gfp_mask) ...@@ -2928,8 +2928,8 @@ static int mmu_shrink(int nr_to_scan, gfp_t gfp_mask)
kvm->arch.n_free_mmu_pages; kvm->arch.n_free_mmu_pages;
cache_count += npages; cache_count += npages;
if (!kvm_freed && nr_to_scan > 0 && npages > 0) { if (!kvm_freed && nr_to_scan > 0 && npages > 0) {
kvm_mmu_remove_one_alloc_mmu_page(kvm); freed_pages = kvm_mmu_remove_some_alloc_mmu_pages(kvm);
cache_count--; cache_count -= freed_pages;
kvm_freed = kvm; kvm_freed = kvm;
} }
nr_to_scan--; nr_to_scan--;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment