Commit d6156218 authored by David Sterba's avatar David Sterba

btrfs: make locking assertion helpers static inline

I've noticed that none of the btrfs_assert_*lock* debugging helpers is
inlined, despite they're short and mostly a value update. Making them
inline shaves 67 from the text size, reduces stack consumption and
perhaps also slightly improves the performance due to avoiding
unnecessary calls.
Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent c9eb55db
...@@ -14,55 +14,55 @@ ...@@ -14,55 +14,55 @@
#include "locking.h" #include "locking.h"
#ifdef CONFIG_BTRFS_DEBUG #ifdef CONFIG_BTRFS_DEBUG
static void btrfs_assert_spinning_writers_get(struct extent_buffer *eb) static inline void btrfs_assert_spinning_writers_get(struct extent_buffer *eb)
{ {
WARN_ON(eb->spinning_writers); WARN_ON(eb->spinning_writers);
eb->spinning_writers++; eb->spinning_writers++;
} }
static void btrfs_assert_spinning_writers_put(struct extent_buffer *eb) static inline void btrfs_assert_spinning_writers_put(struct extent_buffer *eb)
{ {
WARN_ON(eb->spinning_writers != 1); WARN_ON(eb->spinning_writers != 1);
eb->spinning_writers--; eb->spinning_writers--;
} }
static void btrfs_assert_no_spinning_writers(struct extent_buffer *eb) static inline void btrfs_assert_no_spinning_writers(struct extent_buffer *eb)
{ {
WARN_ON(eb->spinning_writers); WARN_ON(eb->spinning_writers);
} }
static void btrfs_assert_spinning_readers_get(struct extent_buffer *eb) static inline void btrfs_assert_spinning_readers_get(struct extent_buffer *eb)
{ {
atomic_inc(&eb->spinning_readers); atomic_inc(&eb->spinning_readers);
} }
static void btrfs_assert_spinning_readers_put(struct extent_buffer *eb) static inline void btrfs_assert_spinning_readers_put(struct extent_buffer *eb)
{ {
WARN_ON(atomic_read(&eb->spinning_readers) == 0); WARN_ON(atomic_read(&eb->spinning_readers) == 0);
atomic_dec(&eb->spinning_readers); atomic_dec(&eb->spinning_readers);
} }
static void btrfs_assert_tree_read_locks_get(struct extent_buffer *eb) static inline void btrfs_assert_tree_read_locks_get(struct extent_buffer *eb)
{ {
atomic_inc(&eb->read_locks); atomic_inc(&eb->read_locks);
} }
static void btrfs_assert_tree_read_locks_put(struct extent_buffer *eb) static inline void btrfs_assert_tree_read_locks_put(struct extent_buffer *eb)
{ {
atomic_dec(&eb->read_locks); atomic_dec(&eb->read_locks);
} }
static void btrfs_assert_tree_read_locked(struct extent_buffer *eb) static inline void btrfs_assert_tree_read_locked(struct extent_buffer *eb)
{ {
BUG_ON(!atomic_read(&eb->read_locks)); BUG_ON(!atomic_read(&eb->read_locks));
} }
static void btrfs_assert_tree_write_locks_get(struct extent_buffer *eb) static inline void btrfs_assert_tree_write_locks_get(struct extent_buffer *eb)
{ {
eb->write_locks++; eb->write_locks++;
} }
static void btrfs_assert_tree_write_locks_put(struct extent_buffer *eb) static inline void btrfs_assert_tree_write_locks_put(struct extent_buffer *eb)
{ {
eb->write_locks--; eb->write_locks--;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment