Commit da9c43dc authored by Sumera Priyadarsini's avatar Sumera Priyadarsini Committed by Stephen Boyd

clk: versatile: Add of_node_put() before return statement

Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a return
or break or goto, there is no decrement thus ultimately resulting in
a memory leak.

Fix a potential memory leak in clk-impd1.c by inserting
of_node_put() before a return statement.

Issue found with Coccinelle.
Signed-off-by: default avatarSumera Priyadarsini <sylphrenadin@gmail.com>
Link: https://lore.kernel.org/r/20200829175704.GA10998@KaladinReviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 73a203b0
...@@ -109,9 +109,11 @@ static int integrator_impd1_clk_probe(struct platform_device *pdev) ...@@ -109,9 +109,11 @@ static int integrator_impd1_clk_probe(struct platform_device *pdev)
for_each_available_child_of_node(np, child) { for_each_available_child_of_node(np, child) {
ret = integrator_impd1_clk_spawn(dev, np, child); ret = integrator_impd1_clk_spawn(dev, np, child);
if (ret) if (ret) {
of_node_put(child);
break; break;
} }
}
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment