Commit de3cae1c authored by Tim Gardner's avatar Tim Gardner Committed by Willy Tarreau

be2iscsi: Fix bogus WARN_ON length check

commit dd29dae0 upstream.

drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
  WARN_ON(!length > 0);

gcc version 5.2.1
Signed-off-by: default avatarTim Gardner <tim.gardner@canonical.com>
Cc: Jayamohan Kallickal <jayamohan.kallickal@avagotech.com>
Cc: Minh Tran <minh.tran@avagotech.com>
Cc: John Soni Jose <sony.john-n@avagotech.com>
Cc: "James E.J. Bottomley" <JBottomley@odin.com>
Reported-by: default avatarJoel Stanley <joel@jms.id.au>
Reviewed-by: default avatarManoj Kumar <manoj@linux.vnet.ibm.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarWilly Tarreau <w@1wt.eu>
parent fa20cb40
...@@ -2978,7 +2978,7 @@ be_sgl_create_contiguous(void *virtual_address, ...@@ -2978,7 +2978,7 @@ be_sgl_create_contiguous(void *virtual_address,
{ {
WARN_ON(!virtual_address); WARN_ON(!virtual_address);
WARN_ON(!physical_address); WARN_ON(!physical_address);
WARN_ON(!length > 0); WARN_ON(!length);
WARN_ON(!sgl); WARN_ON(!sgl);
sgl->va = virtual_address; sgl->va = virtual_address;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment