Commit e4715f01 authored by Glauber Costa's avatar Glauber Costa Committed by Linus Torvalds

memcg: avoid dangling reference count in creation failure.

When use_hierarchy is enabled, we acquire an extra reference count in
our parent during cgroup creation.  We don't release it, though, if any
failure exist in the creation process.
Signed-off-by: default avatarGlauber Costa <glommer@parallels.com>
Reported-by: default avatarMichal Hocko <mhocko@suse.cz>
Acked-by: default avatarMichal Hocko <mhocko@suse.cz>
Cc: Tejun Heo <tj@kernel.org>
Cc: Hiroyuki Kamezawa <kamezawa.hiroyuki@gmail.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 692e89ab
...@@ -6196,6 +6196,8 @@ mem_cgroup_css_online(struct cgroup *cont) ...@@ -6196,6 +6196,8 @@ mem_cgroup_css_online(struct cgroup *cont)
* call __mem_cgroup_free, so return directly * call __mem_cgroup_free, so return directly
*/ */
mem_cgroup_put(memcg); mem_cgroup_put(memcg);
if (parent->use_hierarchy)
mem_cgroup_put(parent);
} }
return error; return error;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment