Commit e8644e4c authored by Alexander Shishkin's avatar Alexander Shishkin

intel_th: pti: Create sysfs attributes using core driver's facility

The core intel_th driver allows subdevices to bring in their sysfs
attributes. Use this instead of taking care of them in probe and
remove.
Signed-off-by: default avatarAlexander Shishkin <alexander.shishkin@linux.intel.com>
Reviewed-by: default avatarLaurent Fert <laurent.fert@intel.com>
parent 9d482aed
...@@ -200,7 +200,6 @@ static int intel_th_pti_probe(struct intel_th_device *thdev) ...@@ -200,7 +200,6 @@ static int intel_th_pti_probe(struct intel_th_device *thdev)
struct resource *res; struct resource *res;
struct pti_device *pti; struct pti_device *pti;
void __iomem *base; void __iomem *base;
int ret;
res = intel_th_device_get_resource(thdev, IORESOURCE_MEM, 0); res = intel_th_device_get_resource(thdev, IORESOURCE_MEM, 0);
if (!res) if (!res)
...@@ -219,10 +218,6 @@ static int intel_th_pti_probe(struct intel_th_device *thdev) ...@@ -219,10 +218,6 @@ static int intel_th_pti_probe(struct intel_th_device *thdev)
read_hw_config(pti); read_hw_config(pti);
ret = sysfs_create_group(&dev->kobj, &pti_output_group);
if (ret)
return ret;
dev_set_drvdata(dev, pti); dev_set_drvdata(dev, pti);
return 0; return 0;
...@@ -230,7 +225,6 @@ static int intel_th_pti_probe(struct intel_th_device *thdev) ...@@ -230,7 +225,6 @@ static int intel_th_pti_probe(struct intel_th_device *thdev)
static void intel_th_pti_remove(struct intel_th_device *thdev) static void intel_th_pti_remove(struct intel_th_device *thdev)
{ {
sysfs_remove_group(&thdev->dev.kobj, &pti_output_group);
} }
static struct intel_th_driver intel_th_pti_driver = { static struct intel_th_driver intel_th_pti_driver = {
...@@ -238,6 +232,7 @@ static struct intel_th_driver intel_th_pti_driver = { ...@@ -238,6 +232,7 @@ static struct intel_th_driver intel_th_pti_driver = {
.remove = intel_th_pti_remove, .remove = intel_th_pti_remove,
.activate = intel_th_pti_activate, .activate = intel_th_pti_activate,
.deactivate = intel_th_pti_deactivate, .deactivate = intel_th_pti_deactivate,
.attr_group = &pti_output_group,
.driver = { .driver = {
.name = "pti", .name = "pti",
.owner = THIS_MODULE, .owner = THIS_MODULE,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment