Commit e9ae9dab authored by Brian King's avatar Brian King Committed by Benjamin Herrenschmidt

powerpc: Remove redundant xics badness warning

While testing cpu offlining, we are regularly seeing the WARN_ON go off
in xics_ipi_dispatch. It can occur when an IPI gets sent to the CPU while
it is going offline. There is already a similar WARN_ON in the handlers
for PPC_MSG_CALL_FUNCTION and PPC_MSG_CALL_FUNC_SINGLE, so the warning
is not needed in that path. The debugger handler handles this case by
simply ignoring IPIs for offline CPUs, so no warning is needed there.
And the reschedule IPI, which is what is occurring in our test environment,
can be safely ignored, so we can simply remove the WARN_ON from xics_ipi_dispatch.
Signed-off-by: default avatarBrian King <brking@linux.vnet.ibm.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 67238fb7
...@@ -549,8 +549,6 @@ static irqreturn_t xics_ipi_dispatch(int cpu) ...@@ -549,8 +549,6 @@ static irqreturn_t xics_ipi_dispatch(int cpu)
{ {
unsigned long *tgt = &per_cpu(xics_ipi_message, cpu); unsigned long *tgt = &per_cpu(xics_ipi_message, cpu);
WARN_ON(cpu_is_offline(cpu));
mb(); /* order mmio clearing qirr */ mb(); /* order mmio clearing qirr */
while (*tgt) { while (*tgt) {
if (test_and_clear_bit(PPC_MSG_CALL_FUNCTION, tgt)) { if (test_and_clear_bit(PPC_MSG_CALL_FUNCTION, tgt)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment