Commit ea099adf authored by Boris Brezillon's avatar Boris Brezillon

drm/bridge: Rename bridge helpers targeting a bridge chain

Change the prefix of bridge helpers targeting a bridge chain from
drm_bridge_ to drm_bridge_chain_ to better reflect the fact that
the operation will happen on all elements of chain, starting at the
bridge passed in argument.
Signed-off-by: default avatarBoris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191203141515.3597631-2-boris.brezillon@collabora.com
parent 64e62bdf
...@@ -435,7 +435,8 @@ mode_fixup(struct drm_atomic_state *state) ...@@ -435,7 +435,8 @@ mode_fixup(struct drm_atomic_state *state)
encoder = new_conn_state->best_encoder; encoder = new_conn_state->best_encoder;
funcs = encoder->helper_private; funcs = encoder->helper_private;
ret = drm_bridge_mode_fixup(encoder->bridge, &new_crtc_state->mode, ret = drm_bridge_chain_mode_fixup(encoder->bridge,
&new_crtc_state->mode,
&new_crtc_state->adjusted_mode); &new_crtc_state->adjusted_mode);
if (!ret) { if (!ret) {
DRM_DEBUG_ATOMIC("Bridge fixup failed\n"); DRM_DEBUG_ATOMIC("Bridge fixup failed\n");
...@@ -501,7 +502,7 @@ static enum drm_mode_status mode_valid_path(struct drm_connector *connector, ...@@ -501,7 +502,7 @@ static enum drm_mode_status mode_valid_path(struct drm_connector *connector,
return ret; return ret;
} }
ret = drm_bridge_mode_valid(encoder->bridge, mode); ret = drm_bridge_chain_mode_valid(encoder->bridge, mode);
if (ret != MODE_OK) { if (ret != MODE_OK) {
DRM_DEBUG_ATOMIC("[BRIDGE] mode_valid() failed\n"); DRM_DEBUG_ATOMIC("[BRIDGE] mode_valid() failed\n");
return ret; return ret;
...@@ -1020,7 +1021,7 @@ disable_outputs(struct drm_device *dev, struct drm_atomic_state *old_state) ...@@ -1020,7 +1021,7 @@ disable_outputs(struct drm_device *dev, struct drm_atomic_state *old_state)
* Each encoder has at most one connector (since we always steal * Each encoder has at most one connector (since we always steal
* it away), so we won't call disable hooks twice. * it away), so we won't call disable hooks twice.
*/ */
drm_atomic_bridge_disable(encoder->bridge, old_state); drm_atomic_bridge_chain_disable(encoder->bridge, old_state);
/* Right function depends upon target state. */ /* Right function depends upon target state. */
if (funcs) { if (funcs) {
...@@ -1034,7 +1035,8 @@ disable_outputs(struct drm_device *dev, struct drm_atomic_state *old_state) ...@@ -1034,7 +1035,8 @@ disable_outputs(struct drm_device *dev, struct drm_atomic_state *old_state)
funcs->dpms(encoder, DRM_MODE_DPMS_OFF); funcs->dpms(encoder, DRM_MODE_DPMS_OFF);
} }
drm_atomic_bridge_post_disable(encoder->bridge, old_state); drm_atomic_bridge_chain_post_disable(encoder->bridge,
old_state);
} }
for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_state, i) { for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_state, i) {
...@@ -1215,7 +1217,8 @@ crtc_set_mode(struct drm_device *dev, struct drm_atomic_state *old_state) ...@@ -1215,7 +1217,8 @@ crtc_set_mode(struct drm_device *dev, struct drm_atomic_state *old_state)
funcs->mode_set(encoder, mode, adjusted_mode); funcs->mode_set(encoder, mode, adjusted_mode);
} }
drm_bridge_mode_set(encoder->bridge, mode, adjusted_mode); drm_bridge_chain_mode_set(encoder->bridge, mode,
adjusted_mode);
} }
} }
...@@ -1332,7 +1335,7 @@ void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev, ...@@ -1332,7 +1335,7 @@ void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev,
* Each encoder has at most one connector (since we always steal * Each encoder has at most one connector (since we always steal
* it away), so we won't call enable hooks twice. * it away), so we won't call enable hooks twice.
*/ */
drm_atomic_bridge_pre_enable(encoder->bridge, old_state); drm_atomic_bridge_chain_pre_enable(encoder->bridge, old_state);
if (funcs) { if (funcs) {
if (funcs->atomic_enable) if (funcs->atomic_enable)
...@@ -1343,7 +1346,7 @@ void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev, ...@@ -1343,7 +1346,7 @@ void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev,
funcs->commit(encoder); funcs->commit(encoder);
} }
drm_atomic_bridge_enable(encoder->bridge, old_state); drm_atomic_bridge_chain_enable(encoder->bridge, old_state);
} }
drm_atomic_helper_commit_writebacks(dev, old_state); drm_atomic_helper_commit_writebacks(dev, old_state);
......
This diff is collapsed.
...@@ -112,7 +112,7 @@ drm_mode_validate_pipeline(struct drm_display_mode *mode, ...@@ -112,7 +112,7 @@ drm_mode_validate_pipeline(struct drm_display_mode *mode,
continue; continue;
} }
ret = drm_bridge_mode_valid(encoder->bridge, mode); ret = drm_bridge_chain_mode_valid(encoder->bridge, mode);
if (ret != MODE_OK) { if (ret != MODE_OK) {
/* There is also no point in continuing for crtc check /* There is also no point in continuing for crtc check
* here. */ * here. */
......
...@@ -1390,7 +1390,7 @@ static void exynos_dsi_enable(struct drm_encoder *encoder) ...@@ -1390,7 +1390,7 @@ static void exynos_dsi_enable(struct drm_encoder *encoder)
if (ret < 0) if (ret < 0)
goto err_put_sync; goto err_put_sync;
} else { } else {
drm_bridge_pre_enable(dsi->out_bridge); drm_bridge_chain_pre_enable(dsi->out_bridge);
} }
exynos_dsi_set_display_mode(dsi); exynos_dsi_set_display_mode(dsi);
...@@ -1401,7 +1401,7 @@ static void exynos_dsi_enable(struct drm_encoder *encoder) ...@@ -1401,7 +1401,7 @@ static void exynos_dsi_enable(struct drm_encoder *encoder)
if (ret < 0) if (ret < 0)
goto err_display_disable; goto err_display_disable;
} else { } else {
drm_bridge_enable(dsi->out_bridge); drm_bridge_chain_enable(dsi->out_bridge);
} }
dsi->state |= DSIM_STATE_VIDOUT_AVAILABLE; dsi->state |= DSIM_STATE_VIDOUT_AVAILABLE;
...@@ -1426,10 +1426,10 @@ static void exynos_dsi_disable(struct drm_encoder *encoder) ...@@ -1426,10 +1426,10 @@ static void exynos_dsi_disable(struct drm_encoder *encoder)
dsi->state &= ~DSIM_STATE_VIDOUT_AVAILABLE; dsi->state &= ~DSIM_STATE_VIDOUT_AVAILABLE;
drm_panel_disable(dsi->panel); drm_panel_disable(dsi->panel);
drm_bridge_disable(dsi->out_bridge); drm_bridge_chain_disable(dsi->out_bridge);
exynos_dsi_set_display_enable(dsi, false); exynos_dsi_set_display_enable(dsi, false);
drm_panel_unprepare(dsi->panel); drm_panel_unprepare(dsi->panel);
drm_bridge_post_disable(dsi->out_bridge); drm_bridge_chain_post_disable(dsi->out_bridge);
dsi->state &= ~DSIM_STATE_ENABLED; dsi->state &= ~DSIM_STATE_ENABLED;
pm_runtime_put_sync(dsi->dev); pm_runtime_put_sync(dsi->dev);
} }
......
...@@ -1247,7 +1247,7 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn, ...@@ -1247,7 +1247,7 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
struct drm_display_mode adjusted_mode; struct drm_display_mode adjusted_mode;
drm_mode_copy(&adjusted_mode, mode); drm_mode_copy(&adjusted_mode, mode);
if (!drm_bridge_mode_fixup(hdmi->bridge.next, mode, if (!drm_bridge_chain_mode_fixup(hdmi->bridge.next, mode,
&adjusted_mode)) &adjusted_mode))
return MODE_BAD; return MODE_BAD;
} }
......
...@@ -753,9 +753,9 @@ static void vc4_dsi_encoder_disable(struct drm_encoder *encoder) ...@@ -753,9 +753,9 @@ static void vc4_dsi_encoder_disable(struct drm_encoder *encoder)
struct vc4_dsi *dsi = vc4_encoder->dsi; struct vc4_dsi *dsi = vc4_encoder->dsi;
struct device *dev = &dsi->pdev->dev; struct device *dev = &dsi->pdev->dev;
drm_bridge_disable(dsi->bridge); drm_bridge_chain_disable(dsi->bridge);
vc4_dsi_ulps(dsi, true); vc4_dsi_ulps(dsi, true);
drm_bridge_post_disable(dsi->bridge); drm_bridge_chain_post_disable(dsi->bridge);
clk_disable_unprepare(dsi->pll_phy_clock); clk_disable_unprepare(dsi->pll_phy_clock);
clk_disable_unprepare(dsi->escape_clock); clk_disable_unprepare(dsi->escape_clock);
...@@ -1055,7 +1055,7 @@ static void vc4_dsi_encoder_enable(struct drm_encoder *encoder) ...@@ -1055,7 +1055,7 @@ static void vc4_dsi_encoder_enable(struct drm_encoder *encoder)
vc4_dsi_ulps(dsi, false); vc4_dsi_ulps(dsi, false);
drm_bridge_pre_enable(dsi->bridge); drm_bridge_chain_pre_enable(dsi->bridge);
if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO) { if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO) {
DSI_PORT_WRITE(DISP0_CTRL, DSI_PORT_WRITE(DISP0_CTRL,
...@@ -1072,7 +1072,7 @@ static void vc4_dsi_encoder_enable(struct drm_encoder *encoder) ...@@ -1072,7 +1072,7 @@ static void vc4_dsi_encoder_enable(struct drm_encoder *encoder)
DSI_DISP0_ENABLE); DSI_DISP0_ENABLE);
} }
drm_bridge_enable(dsi->bridge); drm_bridge_chain_enable(dsi->bridge);
if (debug_dump_regs) { if (debug_dump_regs) {
struct drm_printer p = drm_info_printer(&dsi->pdev->dev); struct drm_printer p = drm_info_printer(&dsi->pdev->dev);
......
...@@ -254,9 +254,10 @@ struct drm_bridge_funcs { ...@@ -254,9 +254,10 @@ struct drm_bridge_funcs {
* there is one) when this callback is called. * there is one) when this callback is called.
* *
* Note that this function will only be invoked in the context of an * Note that this function will only be invoked in the context of an
* atomic commit. It will not be invoked from &drm_bridge_pre_enable. It * atomic commit. It will not be invoked from
* would be prudent to also provide an implementation of @pre_enable if * &drm_bridge_chain_pre_enable. It would be prudent to also provide an
* you are expecting driver calls into &drm_bridge_pre_enable. * implementation of @pre_enable if you are expecting driver calls into
* &drm_bridge_chain_pre_enable.
* *
* The @atomic_pre_enable callback is optional. * The @atomic_pre_enable callback is optional.
*/ */
...@@ -279,9 +280,9 @@ struct drm_bridge_funcs { ...@@ -279,9 +280,9 @@ struct drm_bridge_funcs {
* chain if there is one. * chain if there is one.
* *
* Note that this function will only be invoked in the context of an * Note that this function will only be invoked in the context of an
* atomic commit. It will not be invoked from &drm_bridge_enable. It * atomic commit. It will not be invoked from &drm_bridge_chain_enable.
* would be prudent to also provide an implementation of @enable if * It would be prudent to also provide an implementation of @enable if
* you are expecting driver calls into &drm_bridge_enable. * you are expecting driver calls into &drm_bridge_chain_enable.
* *
* The @atomic_enable callback is optional. * The @atomic_enable callback is optional.
*/ */
...@@ -301,9 +302,10 @@ struct drm_bridge_funcs { ...@@ -301,9 +302,10 @@ struct drm_bridge_funcs {
* signals) feeding it is still running when this callback is called. * signals) feeding it is still running when this callback is called.
* *
* Note that this function will only be invoked in the context of an * Note that this function will only be invoked in the context of an
* atomic commit. It will not be invoked from &drm_bridge_disable. It * atomic commit. It will not be invoked from
* would be prudent to also provide an implementation of @disable if * &drm_bridge_chain_disable. It would be prudent to also provide an
* you are expecting driver calls into &drm_bridge_disable. * implementation of @disable if you are expecting driver calls into
* &drm_bridge_chain_disable.
* *
* The @atomic_disable callback is optional. * The @atomic_disable callback is optional.
*/ */
...@@ -325,10 +327,11 @@ struct drm_bridge_funcs { ...@@ -325,10 +327,11 @@ struct drm_bridge_funcs {
* called. * called.
* *
* Note that this function will only be invoked in the context of an * Note that this function will only be invoked in the context of an
* atomic commit. It will not be invoked from &drm_bridge_post_disable. * atomic commit. It will not be invoked from
* &drm_bridge_chain_post_disable.
* It would be prudent to also provide an implementation of * It would be prudent to also provide an implementation of
* @post_disable if you are expecting driver calls into * @post_disable if you are expecting driver calls into
* &drm_bridge_post_disable. * &drm_bridge_chain_post_disable.
* *
* The @atomic_post_disable callback is optional. * The @atomic_post_disable callback is optional.
*/ */
...@@ -406,26 +409,27 @@ struct drm_bridge *of_drm_find_bridge(struct device_node *np); ...@@ -406,26 +409,27 @@ struct drm_bridge *of_drm_find_bridge(struct device_node *np);
int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge, int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
struct drm_bridge *previous); struct drm_bridge *previous);
bool drm_bridge_mode_fixup(struct drm_bridge *bridge, bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge,
const struct drm_display_mode *mode, const struct drm_display_mode *mode,
struct drm_display_mode *adjusted_mode); struct drm_display_mode *adjusted_mode);
enum drm_mode_status drm_bridge_mode_valid(struct drm_bridge *bridge, enum drm_mode_status
drm_bridge_chain_mode_valid(struct drm_bridge *bridge,
const struct drm_display_mode *mode); const struct drm_display_mode *mode);
void drm_bridge_disable(struct drm_bridge *bridge); void drm_bridge_chain_disable(struct drm_bridge *bridge);
void drm_bridge_post_disable(struct drm_bridge *bridge); void drm_bridge_chain_post_disable(struct drm_bridge *bridge);
void drm_bridge_mode_set(struct drm_bridge *bridge, void drm_bridge_chain_mode_set(struct drm_bridge *bridge,
const struct drm_display_mode *mode, const struct drm_display_mode *mode,
const struct drm_display_mode *adjusted_mode); const struct drm_display_mode *adjusted_mode);
void drm_bridge_pre_enable(struct drm_bridge *bridge); void drm_bridge_chain_pre_enable(struct drm_bridge *bridge);
void drm_bridge_enable(struct drm_bridge *bridge); void drm_bridge_chain_enable(struct drm_bridge *bridge);
void drm_atomic_bridge_disable(struct drm_bridge *bridge, void drm_atomic_bridge_chain_disable(struct drm_bridge *bridge,
struct drm_atomic_state *state); struct drm_atomic_state *state);
void drm_atomic_bridge_post_disable(struct drm_bridge *bridge, void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge,
struct drm_atomic_state *state); struct drm_atomic_state *state);
void drm_atomic_bridge_pre_enable(struct drm_bridge *bridge, void drm_atomic_bridge_chain_pre_enable(struct drm_bridge *bridge,
struct drm_atomic_state *state); struct drm_atomic_state *state);
void drm_atomic_bridge_enable(struct drm_bridge *bridge, void drm_atomic_bridge_chain_enable(struct drm_bridge *bridge,
struct drm_atomic_state *state); struct drm_atomic_state *state);
#ifdef CONFIG_DRM_PANEL_BRIDGE #ifdef CONFIG_DRM_PANEL_BRIDGE
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment