Commit eb7b5493 authored by Jeff Dike's avatar Jeff Dike Committed by Linus Torvalds

[PATCH] uml: small vsyscall fixes

From: Bodo Stroesser <bstroesser@fujitsu-siemens.com>

As Jeff pointed out, the check for address wrapping in access_ok_skas
was wrong. Also, change vsyscall_ehdr and vsyscall_end to be
unsigned long and export them, since modules need them for access_ok_skas
Signed-off-by: default avatarBodo Stroesser <bstroesser@fujitsu-siemens.com>
Signed-off-by: default avatarJeff Dike <jdike@addtoit.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent c0436bdd
...@@ -14,9 +14,9 @@ ...@@ -14,9 +14,9 @@
(((unsigned long) (addr) < TASK_SIZE) && \ (((unsigned long) (addr) < TASK_SIZE) && \
((unsigned long) (addr) + (size) <= TASK_SIZE)) || \ ((unsigned long) (addr) + (size) <= TASK_SIZE)) || \
((type == VERIFY_READ ) && \ ((type == VERIFY_READ ) && \
(size <= (FIXADDR_USER_END - FIXADDR_USER_START)) && \
((unsigned long) (addr) >= FIXADDR_USER_START) && \ ((unsigned long) (addr) >= FIXADDR_USER_START) && \
((unsigned long) (addr) + (size) <= FIXADDR_USER_END))) ((unsigned long) (addr) + (size) <= FIXADDR_USER_END) && \
((unsigned long) (addr) + (size) >= (unsigned long)(addr))))
static inline int verify_area_skas(int type, const void * addr, static inline int verify_area_skas(int type, const void * addr,
unsigned long size) unsigned long size)
......
...@@ -20,10 +20,10 @@ typedef Elf64_auxv_t elf_auxv_t; ...@@ -20,10 +20,10 @@ typedef Elf64_auxv_t elf_auxv_t;
char * elf_aux_platform; char * elf_aux_platform;
long elf_aux_hwcap; long elf_aux_hwcap;
long vsyscall_ehdr; unsigned long vsyscall_ehdr;
long vsyscall_end; unsigned long vsyscall_end;
long __kernel_vsyscall; unsigned long __kernel_vsyscall;
__init void scan_elf_aux( char **envp) __init void scan_elf_aux( char **envp)
......
...@@ -26,6 +26,9 @@ EXPORT_SYMBOL(printf); ...@@ -26,6 +26,9 @@ EXPORT_SYMBOL(printf);
EXPORT_SYMBOL(strstr); EXPORT_SYMBOL(strstr);
EXPORT_SYMBOL(vsyscall_ehdr);
EXPORT_SYMBOL(vsyscall_end);
/* Here, instead, I can provide a fake prototype. Yes, someone cares: genksyms. /* Here, instead, I can provide a fake prototype. Yes, someone cares: genksyms.
* However, the modules will use the CRC defined *here*, no matter if it is * However, the modules will use the CRC defined *here*, no matter if it is
* good; so the versions of these symbols will always match * good; so the versions of these symbols will always match
......
...@@ -58,9 +58,9 @@ typedef elf_greg_t elf_gregset_t[ELF_NGREG]; ...@@ -58,9 +58,9 @@ typedef elf_greg_t elf_gregset_t[ELF_NGREG];
} while(0); } while(0);
extern long vsyscall_ehdr; extern unsigned long vsyscall_ehdr;
extern long vsyscall_end; extern unsigned long vsyscall_end;
extern long __kernel_vsyscall; extern unsigned long __kernel_vsyscall;
#define VSYSCALL_BASE vsyscall_ehdr #define VSYSCALL_BASE vsyscall_ehdr
#define VSYSCALL_END vsyscall_end #define VSYSCALL_END vsyscall_end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment