Commit ee1a95b3 authored by Chuck Lever's avatar Chuck Lever Committed by J. Bruce Fields

NFSD: Use unsigned length argument for decode_filename

Clean up: file name lengths are unsigned on the wire, negative lengths
are not meaningful natively either.
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Acked-By: default avatarNeilBrown <neilb@suse.de>
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
parent 48df020a
...@@ -88,10 +88,10 @@ encode_fh(__be32 *p, struct svc_fh *fhp) ...@@ -88,10 +88,10 @@ encode_fh(__be32 *p, struct svc_fh *fhp)
* no slashes or null bytes. * no slashes or null bytes.
*/ */
static __be32 * static __be32 *
decode_filename(__be32 *p, char **namp, int *lenp) decode_filename(__be32 *p, char **namp, unsigned int *lenp)
{ {
char *name; char *name;
int i; unsigned int i;
if ((p = xdr_decode_string_inplace(p, namp, lenp, NFS3_MAXNAMLEN)) != NULL) { if ((p = xdr_decode_string_inplace(p, namp, lenp, NFS3_MAXNAMLEN)) != NULL) {
for (i = 0, name = *namp; i < *lenp; i++, name++) { for (i = 0, name = *namp; i < *lenp; i++, name++) {
......
...@@ -62,10 +62,10 @@ encode_fh(__be32 *p, struct svc_fh *fhp) ...@@ -62,10 +62,10 @@ encode_fh(__be32 *p, struct svc_fh *fhp)
* no slashes or null bytes. * no slashes or null bytes.
*/ */
static __be32 * static __be32 *
decode_filename(__be32 *p, char **namp, int *lenp) decode_filename(__be32 *p, char **namp, unsigned int *lenp)
{ {
char *name; char *name;
int i; unsigned int i;
if ((p = xdr_decode_string_inplace(p, namp, lenp, NFS_MAXNAMLEN)) != NULL) { if ((p = xdr_decode_string_inplace(p, namp, lenp, NFS_MAXNAMLEN)) != NULL) {
for (i = 0, name = *namp; i < *lenp; i++, name++) { for (i = 0, name = *namp; i < *lenp; i++, name++) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment