Commit efe22c12 authored by YueHaibing's avatar YueHaibing Committed by Greg Kroah-Hartman

net: cavium: fix return type of ndo_start_xmit function

[ Upstream commit ac1172de ]

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.

Found by coccinelle.
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 279a4f77
...@@ -2324,7 +2324,7 @@ static inline int send_nic_timestamp_pkt(struct octeon_device *oct, ...@@ -2324,7 +2324,7 @@ static inline int send_nic_timestamp_pkt(struct octeon_device *oct,
* @returns whether the packet was transmitted to the device okay or not * @returns whether the packet was transmitted to the device okay or not
* (NETDEV_TX_OK or NETDEV_TX_BUSY) * (NETDEV_TX_OK or NETDEV_TX_BUSY)
*/ */
static int liquidio_xmit(struct sk_buff *skb, struct net_device *netdev) static netdev_tx_t liquidio_xmit(struct sk_buff *skb, struct net_device *netdev)
{ {
struct lio *lio; struct lio *lio;
struct octnet_buf_free_info *finfo; struct octnet_buf_free_info *finfo;
......
...@@ -1390,7 +1390,7 @@ static int send_nic_timestamp_pkt(struct octeon_device *oct, ...@@ -1390,7 +1390,7 @@ static int send_nic_timestamp_pkt(struct octeon_device *oct,
* @returns whether the packet was transmitted to the device okay or not * @returns whether the packet was transmitted to the device okay or not
* (NETDEV_TX_OK or NETDEV_TX_BUSY) * (NETDEV_TX_OK or NETDEV_TX_BUSY)
*/ */
static int liquidio_xmit(struct sk_buff *skb, struct net_device *netdev) static netdev_tx_t liquidio_xmit(struct sk_buff *skb, struct net_device *netdev)
{ {
struct octnet_buf_free_info *finfo; struct octnet_buf_free_info *finfo;
union octnic_cmd_setup cmdsetup; union octnic_cmd_setup cmdsetup;
......
...@@ -31,7 +31,8 @@ ...@@ -31,7 +31,8 @@
static int lio_vf_rep_open(struct net_device *ndev); static int lio_vf_rep_open(struct net_device *ndev);
static int lio_vf_rep_stop(struct net_device *ndev); static int lio_vf_rep_stop(struct net_device *ndev);
static int lio_vf_rep_pkt_xmit(struct sk_buff *skb, struct net_device *ndev); static netdev_tx_t lio_vf_rep_pkt_xmit(struct sk_buff *skb,
struct net_device *ndev);
static void lio_vf_rep_tx_timeout(struct net_device *netdev); static void lio_vf_rep_tx_timeout(struct net_device *netdev);
static int lio_vf_rep_phys_port_name(struct net_device *dev, static int lio_vf_rep_phys_port_name(struct net_device *dev,
char *buf, size_t len); char *buf, size_t len);
...@@ -382,7 +383,7 @@ lio_vf_rep_packet_sent_callback(struct octeon_device *oct, ...@@ -382,7 +383,7 @@ lio_vf_rep_packet_sent_callback(struct octeon_device *oct,
netif_wake_queue(ndev); netif_wake_queue(ndev);
} }
static int static netdev_tx_t
lio_vf_rep_pkt_xmit(struct sk_buff *skb, struct net_device *ndev) lio_vf_rep_pkt_xmit(struct sk_buff *skb, struct net_device *ndev)
{ {
struct lio_vf_rep_desc *vf_rep = netdev_priv(ndev); struct lio_vf_rep_desc *vf_rep = netdev_priv(ndev);
......
...@@ -1268,12 +1268,13 @@ static int octeon_mgmt_stop(struct net_device *netdev) ...@@ -1268,12 +1268,13 @@ static int octeon_mgmt_stop(struct net_device *netdev)
return 0; return 0;
} }
static int octeon_mgmt_xmit(struct sk_buff *skb, struct net_device *netdev) static netdev_tx_t
octeon_mgmt_xmit(struct sk_buff *skb, struct net_device *netdev)
{ {
struct octeon_mgmt *p = netdev_priv(netdev); struct octeon_mgmt *p = netdev_priv(netdev);
union mgmt_port_ring_entry re; union mgmt_port_ring_entry re;
unsigned long flags; unsigned long flags;
int rv = NETDEV_TX_BUSY; netdev_tx_t rv = NETDEV_TX_BUSY;
re.d64 = 0; re.d64 = 0;
re.s.tstamp = ((skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP) != 0); re.s.tstamp = ((skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP) != 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment