Commit f4e7bd81 authored by Joachim Eastwood's avatar Joachim Eastwood Committed by David S. Miller

stmmac: let remove/resume/suspend functions take device pointer

Change stmmac_remove/resume/suspend to take a device pointer so
they can be used directly by drivers that doesn't need to perform
anything device specific.

This lets us remove the PCI pm functions and later simplifiy the
platform drivers.
Signed-off-by: default avatarJoachim Eastwood <manabian@gmail.com>
Tested-by: default avatarMarek Vasut <marex@denx.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e03179fe
...@@ -148,9 +148,9 @@ void stmmac_set_ethtool_ops(struct net_device *netdev); ...@@ -148,9 +148,9 @@ void stmmac_set_ethtool_ops(struct net_device *netdev);
int stmmac_ptp_register(struct stmmac_priv *priv); int stmmac_ptp_register(struct stmmac_priv *priv);
void stmmac_ptp_unregister(struct stmmac_priv *priv); void stmmac_ptp_unregister(struct stmmac_priv *priv);
int stmmac_resume(struct net_device *ndev); int stmmac_resume(struct device *dev);
int stmmac_suspend(struct net_device *ndev); int stmmac_suspend(struct device *dev);
int stmmac_dvr_remove(struct net_device *ndev); int stmmac_dvr_remove(struct device *dev);
int stmmac_dvr_probe(struct device *device, int stmmac_dvr_probe(struct device *device,
struct plat_stmmacenet_data *plat_dat, struct plat_stmmacenet_data *plat_dat,
struct stmmac_resources *res); struct stmmac_resources *res);
......
...@@ -3350,12 +3350,13 @@ EXPORT_SYMBOL_GPL(stmmac_dvr_probe); ...@@ -3350,12 +3350,13 @@ EXPORT_SYMBOL_GPL(stmmac_dvr_probe);
/** /**
* stmmac_dvr_remove * stmmac_dvr_remove
* @ndev: net device pointer * @dev: device pointer
* Description: this function resets the TX/RX processes, disables the MAC RX/TX * Description: this function resets the TX/RX processes, disables the MAC RX/TX
* changes the link status, releases the DMA descriptor rings. * changes the link status, releases the DMA descriptor rings.
*/ */
int stmmac_dvr_remove(struct net_device *ndev) int stmmac_dvr_remove(struct device *dev)
{ {
struct net_device *ndev = dev_get_drvdata(dev);
struct stmmac_priv *priv = netdev_priv(ndev); struct stmmac_priv *priv = netdev_priv(ndev);
pr_info("%s:\n\tremoving driver", __func__); pr_info("%s:\n\tremoving driver", __func__);
...@@ -3381,13 +3382,14 @@ EXPORT_SYMBOL_GPL(stmmac_dvr_remove); ...@@ -3381,13 +3382,14 @@ EXPORT_SYMBOL_GPL(stmmac_dvr_remove);
/** /**
* stmmac_suspend - suspend callback * stmmac_suspend - suspend callback
* @ndev: net device pointer * @dev: device pointer
* Description: this is the function to suspend the device and it is called * Description: this is the function to suspend the device and it is called
* by the platform driver to stop the network queue, release the resources, * by the platform driver to stop the network queue, release the resources,
* program the PMT register (for WoL), clean and release driver resources. * program the PMT register (for WoL), clean and release driver resources.
*/ */
int stmmac_suspend(struct net_device *ndev) int stmmac_suspend(struct device *dev)
{ {
struct net_device *ndev = dev_get_drvdata(dev);
struct stmmac_priv *priv = netdev_priv(ndev); struct stmmac_priv *priv = netdev_priv(ndev);
unsigned long flags; unsigned long flags;
...@@ -3430,12 +3432,13 @@ EXPORT_SYMBOL_GPL(stmmac_suspend); ...@@ -3430,12 +3432,13 @@ EXPORT_SYMBOL_GPL(stmmac_suspend);
/** /**
* stmmac_resume - resume callback * stmmac_resume - resume callback
* @ndev: net device pointer * @dev: device pointer
* Description: when resume this function is invoked to setup the DMA and CORE * Description: when resume this function is invoked to setup the DMA and CORE
* in a usable state. * in a usable state.
*/ */
int stmmac_resume(struct net_device *ndev) int stmmac_resume(struct device *dev)
{ {
struct net_device *ndev = dev_get_drvdata(dev);
struct stmmac_priv *priv = netdev_priv(ndev); struct stmmac_priv *priv = netdev_priv(ndev);
unsigned long flags; unsigned long flags;
......
...@@ -231,30 +231,10 @@ static int stmmac_pci_probe(struct pci_dev *pdev, ...@@ -231,30 +231,10 @@ static int stmmac_pci_probe(struct pci_dev *pdev,
*/ */
static void stmmac_pci_remove(struct pci_dev *pdev) static void stmmac_pci_remove(struct pci_dev *pdev)
{ {
struct net_device *ndev = pci_get_drvdata(pdev); stmmac_dvr_remove(&pdev->dev);
stmmac_dvr_remove(ndev);
}
#ifdef CONFIG_PM_SLEEP
static int stmmac_pci_suspend(struct device *dev)
{
struct pci_dev *pdev = to_pci_dev(dev);
struct net_device *ndev = pci_get_drvdata(pdev);
return stmmac_suspend(ndev);
}
static int stmmac_pci_resume(struct device *dev)
{
struct pci_dev *pdev = to_pci_dev(dev);
struct net_device *ndev = pci_get_drvdata(pdev);
return stmmac_resume(ndev);
} }
#endif
static SIMPLE_DEV_PM_OPS(stmmac_pm_ops, stmmac_pci_suspend, stmmac_pci_resume); static SIMPLE_DEV_PM_OPS(stmmac_pm_ops, stmmac_suspend, stmmac_resume);
#define STMMAC_VENDOR_ID 0x700 #define STMMAC_VENDOR_ID 0x700
#define STMMAC_QUARK_ID 0x0937 #define STMMAC_QUARK_ID 0x0937
......
...@@ -386,7 +386,7 @@ int stmmac_pltfr_remove(struct platform_device *pdev) ...@@ -386,7 +386,7 @@ int stmmac_pltfr_remove(struct platform_device *pdev)
{ {
struct net_device *ndev = platform_get_drvdata(pdev); struct net_device *ndev = platform_get_drvdata(pdev);
struct stmmac_priv *priv = netdev_priv(ndev); struct stmmac_priv *priv = netdev_priv(ndev);
int ret = stmmac_dvr_remove(ndev); int ret = stmmac_dvr_remove(&pdev->dev);
if (priv->plat->exit) if (priv->plat->exit)
priv->plat->exit(pdev, priv->plat->bsp_priv); priv->plat->exit(pdev, priv->plat->bsp_priv);
...@@ -410,7 +410,7 @@ static int stmmac_pltfr_suspend(struct device *dev) ...@@ -410,7 +410,7 @@ static int stmmac_pltfr_suspend(struct device *dev)
struct stmmac_priv *priv = netdev_priv(ndev); struct stmmac_priv *priv = netdev_priv(ndev);
struct platform_device *pdev = to_platform_device(dev); struct platform_device *pdev = to_platform_device(dev);
ret = stmmac_suspend(ndev); ret = stmmac_suspend(dev);
if (priv->plat->exit) if (priv->plat->exit)
priv->plat->exit(pdev, priv->plat->bsp_priv); priv->plat->exit(pdev, priv->plat->bsp_priv);
...@@ -433,7 +433,7 @@ static int stmmac_pltfr_resume(struct device *dev) ...@@ -433,7 +433,7 @@ static int stmmac_pltfr_resume(struct device *dev)
if (priv->plat->init) if (priv->plat->init)
priv->plat->init(pdev, priv->plat->bsp_priv); priv->plat->init(pdev, priv->plat->bsp_priv);
return stmmac_resume(ndev); return stmmac_resume(dev);
} }
#endif /* CONFIG_PM_SLEEP */ #endif /* CONFIG_PM_SLEEP */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment