Commit f5a6d958 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Greg Kroah-Hartman

PM: Remove WARN_ON from device_pm_add

PM: Remove WARN_ON from device_pm_add

Fix message in device_pm_add() saying that the device will not be
added to dpm_list, although in fact the device is going to be added
to the list regardless of the ordering violation.

Remove the WARN_ON(true) triggered in that situation, because it is
hit by USB very often and spams the users' logs.

This patch fixes bug #11263
Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent c906a48a
...@@ -74,11 +74,9 @@ void device_pm_add(struct device *dev) ...@@ -74,11 +74,9 @@ void device_pm_add(struct device *dev)
kobject_name(&dev->kobj)); kobject_name(&dev->kobj));
mutex_lock(&dpm_list_mtx); mutex_lock(&dpm_list_mtx);
if (dev->parent) { if (dev->parent) {
if (dev->parent->power.status >= DPM_SUSPENDING) { if (dev->parent->power.status >= DPM_SUSPENDING)
dev_warn(dev, "parent %s is sleeping, will not add\n", dev_warn(dev, "parent %s should not be sleeping\n",
dev->parent->bus_id); dev->parent->bus_id);
WARN_ON(true);
}
} else if (transition_started) { } else if (transition_started) {
/* /*
* We refuse to register parentless devices while a PM * We refuse to register parentless devices while a PM
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment