Commit f6082333 authored by Alexander Lobakin's avatar Alexander Lobakin Committed by Khalid Elmously

virtio: virtio_console: add missing MODULE_DEVICE_TABLE() for rproc serial

BugLink: https://bugs.launchpad.net/bugs/1888690

commit 897c44f0 upstream.

rproc_serial_id_table lacks an exposure to module devicetable, so
when remoteproc firmware requests VIRTIO_ID_RPROC_SERIAL, no uevent
is generated and no module autoloading occurs.
Add missing MODULE_DEVICE_TABLE() annotation and move the existing
one for VIRTIO_ID_CONSOLE right to the table itself.

Fixes: 1b637046 ("virtio_console: Add support for remoteproc serial")
Cc: <stable@vger.kernel.org> # v3.8+
Signed-off-by: default avatarAlexander Lobakin <alobakin@pm.me>
Reviewed-by: default avatarAmit Shah <amit@kernel.org>
Link: https://lore.kernel.org/r/x7C_CbeJtoGMy258nwAXASYz3xgFMFpyzmUvOyZzRnQrgWCREBjaqBOpAUS7ol4NnZYvSVwmTsCG0Ohyfvta-ygw6HMHcoeKK0C3QFiAO_Q=@pm.meSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
parent ca33b53b
...@@ -2155,6 +2155,7 @@ static struct virtio_device_id id_table[] = { ...@@ -2155,6 +2155,7 @@ static struct virtio_device_id id_table[] = {
{ VIRTIO_ID_CONSOLE, VIRTIO_DEV_ANY_ID }, { VIRTIO_ID_CONSOLE, VIRTIO_DEV_ANY_ID },
{ 0 }, { 0 },
}; };
MODULE_DEVICE_TABLE(virtio, id_table);
static unsigned int features[] = { static unsigned int features[] = {
VIRTIO_CONSOLE_F_SIZE, VIRTIO_CONSOLE_F_SIZE,
...@@ -2167,6 +2168,7 @@ static struct virtio_device_id rproc_serial_id_table[] = { ...@@ -2167,6 +2168,7 @@ static struct virtio_device_id rproc_serial_id_table[] = {
#endif #endif
{ 0 }, { 0 },
}; };
MODULE_DEVICE_TABLE(virtio, rproc_serial_id_table);
static unsigned int rproc_serial_features[] = { static unsigned int rproc_serial_features[] = {
}; };
...@@ -2319,6 +2321,5 @@ static void __exit fini(void) ...@@ -2319,6 +2321,5 @@ static void __exit fini(void)
module_init(init); module_init(init);
module_exit(fini); module_exit(fini);
MODULE_DEVICE_TABLE(virtio, id_table);
MODULE_DESCRIPTION("Virtio console driver"); MODULE_DESCRIPTION("Virtio console driver");
MODULE_LICENSE("GPL"); MODULE_LICENSE("GPL");
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment