Commit f65363cf authored by Lars Ellenberg's avatar Lars Ellenberg Committed by Philipp Reisner

drbd: fix possible access after free

If we release the page pointed to by md_io_tmpp, we need to zero out the
pointer, too, as that may be used later to decide whether we need to
allocate a new page again.

Impact: a previously freed page may be used and clobbered.  Depending on
what that particular page is being used for meanwhile, this may result
in silent data corruption of completely unrelated things.

Only of concern on devices with logical_block_size != 512 byte,
if you re-attach after becoming diskless once.
Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
parent 8979d9c9
...@@ -1407,8 +1407,10 @@ static void after_state_ch(struct drbd_conf *mdev, union drbd_state os, ...@@ -1407,8 +1407,10 @@ static void after_state_ch(struct drbd_conf *mdev, union drbd_state os,
drbd_free_bc(mdev->ldev); drbd_free_bc(mdev->ldev);
mdev->ldev = NULL;); mdev->ldev = NULL;);
if (mdev->md_io_tmpp) if (mdev->md_io_tmpp) {
__free_page(mdev->md_io_tmpp); __free_page(mdev->md_io_tmpp);
mdev->md_io_tmpp = NULL;
}
} }
/* Disks got bigger while they were detached */ /* Disks got bigger while they were detached */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment