Commit f7398509 authored by Ian Abbott's avatar Ian Abbott Committed by Greg Kroah-Hartman

staging: comedi: don't allow write() on async command set up for "read"

If a Comedi asynchronous command has been set up for data transfer in
the "read" direction on the current "write" subdevice (for those
subdevices that support both directions), don't allow the "write" file
operation as that would mess with the data in the comedi data buffer
that is written by the low-level comedi hardware driver.
Signed-off-by: default avatarIan Abbott <abbotti@mev.co.uk>
Reviewed-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f025ab9e
...@@ -2075,6 +2075,10 @@ static ssize_t comedi_write(struct file *file, const char __user *buf, ...@@ -2075,6 +2075,10 @@ static ssize_t comedi_write(struct file *file, const char __user *buf,
retval = -EACCES; retval = -EACCES;
goto out; goto out;
} }
if (!(async->cmd.flags & CMDF_WRITE)) {
retval = -EINVAL;
goto out;
}
add_wait_queue(&async->wait_head, &wait); add_wait_queue(&async->wait_head, &wait);
on_wait_queue = true; on_wait_queue = true;
...@@ -2146,6 +2150,10 @@ static ssize_t comedi_write(struct file *file, const char __user *buf, ...@@ -2146,6 +2150,10 @@ static ssize_t comedi_write(struct file *file, const char __user *buf,
retval = -EACCES; retval = -EACCES;
break; break;
} }
if (!(async->cmd.flags & CMDF_WRITE)) {
retval = -EINVAL;
break;
}
continue; continue;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment