Commit f876d213 authored by Yinghai Lu's avatar Yinghai Lu Committed by Ingo Molnar

x86: make 64 handle sis_apic_bug like the 32 bit

do we have 64bit system with sis chipset?

[ mingo@elte.hu: nope, the problem chipset was 32-bit only.
                 The code symmetry is good nevertheless. ]
Signed-off-by: default avatarYinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent d4057bdb
...@@ -65,7 +65,11 @@ ...@@ -65,7 +65,11 @@
int ioapic_force; int ioapic_force;
int sis_apic_bug; /* not actually supported, dummy for compile */ /*
* Is the SiS APIC rmw bug present ?
* -1 = don't know, 0 = no, 1 = yes
*/
int sis_apic_bug = -1;
static DEFINE_SPINLOCK(ioapic_lock); static DEFINE_SPINLOCK(ioapic_lock);
static DEFINE_SPINLOCK(vector_lock); static DEFINE_SPINLOCK(vector_lock);
...@@ -373,9 +377,11 @@ static inline void io_apic_write(unsigned int apic, unsigned int reg, unsigned i ...@@ -373,9 +377,11 @@ static inline void io_apic_write(unsigned int apic, unsigned int reg, unsigned i
* Re-write a value: to be used for read-modify-write * Re-write a value: to be used for read-modify-write
* cycles where the read already set up the index register. * cycles where the read already set up the index register.
*/ */
static inline void io_apic_modify(unsigned int apic, unsigned int value) static inline void io_apic_modify(unsigned int apic, unsigned int reg, unsigned int value)
{ {
struct io_apic __iomem *io_apic = io_apic_base(apic); struct io_apic __iomem *io_apic = io_apic_base(apic);
if (sis_apic_bug)
writel(reg, &io_apic->index);
writel(value, &io_apic->data); writel(value, &io_apic->data);
} }
...@@ -494,7 +500,7 @@ static void __target_IO_APIC_irq(unsigned int irq, unsigned int dest, u8 vector) ...@@ -494,7 +500,7 @@ static void __target_IO_APIC_irq(unsigned int irq, unsigned int dest, u8 vector)
reg = io_apic_read(apic, 0x10 + pin*2); reg = io_apic_read(apic, 0x10 + pin*2);
reg &= ~IO_APIC_REDIR_VECTOR_MASK; reg &= ~IO_APIC_REDIR_VECTOR_MASK;
reg |= vector; reg |= vector;
io_apic_modify(apic, reg); io_apic_modify(apic, 0x10 + pin*2, reg);
if (!entry->next) if (!entry->next)
break; break;
entry = entry->next; entry = entry->next;
...@@ -624,7 +630,7 @@ static inline void io_apic_sync(unsigned int apic) ...@@ -624,7 +630,7 @@ static inline void io_apic_sync(unsigned int apic)
pin = entry->pin; \ pin = entry->pin; \
reg = io_apic_read(entry->apic, 0x10 + R + pin*2); \ reg = io_apic_read(entry->apic, 0x10 + R + pin*2); \
reg ACTION; \ reg ACTION; \
io_apic_modify(entry->apic, reg); \ io_apic_modify(entry->apic, 0x10 + R + pin*2, reg); \
FINAL; \ FINAL; \
if (!entry->next) \ if (!entry->next) \
break; \ break; \
...@@ -2450,6 +2456,20 @@ void __init setup_IO_APIC(void) ...@@ -2450,6 +2456,20 @@ void __init setup_IO_APIC(void)
check_timer(); check_timer();
} }
/*
* Called after all the initialization is done. If we didnt find any
* APIC bugs then we can allow the modify fast path
*/
static int __init io_apic_bug_finalize(void)
{
if (sis_apic_bug == -1)
sis_apic_bug = 0;
return 0;
}
late_initcall(io_apic_bug_finalize);
struct sysfs_ioapic_data { struct sysfs_ioapic_data {
struct sys_device dev; struct sys_device dev;
struct IO_APIC_route_entry entry[0]; struct IO_APIC_route_entry entry[0];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment