Commit fecdf8be authored by Oleg Nesterov's avatar Oleg Nesterov Committed by David S. Miller

net: pktgen: fix race between pktgen_thread_worker() and kthread_stop()

pktgen_thread_worker() is obviously racy, kthread_stop() can come
between the kthread_should_stop() check and set_current_state().
Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Reported-by: default avatarJan Stancek <jstancek@redhat.com>
Reported-by: default avatarMarcelo Leitner <mleitner@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4a0e3e98
...@@ -3572,8 +3572,10 @@ static int pktgen_thread_worker(void *arg) ...@@ -3572,8 +3572,10 @@ static int pktgen_thread_worker(void *arg)
pktgen_rem_thread(t); pktgen_rem_thread(t);
/* Wait for kthread_stop */ /* Wait for kthread_stop */
while (!kthread_should_stop()) { for (;;) {
set_current_state(TASK_INTERRUPTIBLE); set_current_state(TASK_INTERRUPTIBLE);
if (kthread_should_stop())
break;
schedule(); schedule();
} }
__set_current_state(TASK_RUNNING); __set_current_state(TASK_RUNNING);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment