Commit fff69fd0 authored by Kevin Hao's avatar Kevin Hao Committed by Scott Wood

powerpc/83xx: factor out the common codes of setup arch functions

Factor out the common codes of setup arch functions to a separate
function. It does make no sense to print a board specific info
in setup arch functions, so use a more general one.

For ASP8347E board, there is no pci device node. So it is safe to
invoke mpc83xx_setup_pci() in its setup arch function even there is
no such invocation in its original setup arch function.
Signed-off-by: default avatarKevin Hao <haokexin@gmail.com>
Signed-off-by: default avatarScott Wood <oss@buserror.net>
parent 4d486e00
...@@ -30,9 +30,7 @@ ...@@ -30,9 +30,7 @@
*/ */
static void __init asp834x_setup_arch(void) static void __init asp834x_setup_arch(void)
{ {
if (ppc_md.progress) mpc83xx_setup_arch();
ppc_md.progress("asp834x_setup_arch()", 0);
mpc834x_usb_cfg(); mpc834x_usb_cfg();
} }
......
...@@ -130,10 +130,7 @@ static void __init mpc83xx_km_setup_arch(void) ...@@ -130,10 +130,7 @@ static void __init mpc83xx_km_setup_arch(void)
struct device_node *np; struct device_node *np;
#endif #endif
if (ppc_md.progress) mpc83xx_setup_arch();
ppc_md.progress("kmpbec83xx_setup_arch()", 0);
mpc83xx_setup_pci();
#ifdef CONFIG_QUICC_ENGINE #ifdef CONFIG_QUICC_ENGINE
np = of_find_node_by_name(NULL, "par_io"); np = of_find_node_by_name(NULL, "par_io");
......
...@@ -142,3 +142,11 @@ void __init mpc83xx_setup_pci(void) ...@@ -142,3 +142,11 @@ void __init mpc83xx_setup_pci(void)
mpc83xx_add_bridge(np); mpc83xx_add_bridge(np);
} }
#endif #endif
void __init mpc83xx_setup_arch(void)
{
if (ppc_md.progress)
ppc_md.progress("mpc83xx_setup_arch()", 0);
mpc83xx_setup_pci();
}
...@@ -27,10 +27,7 @@ ...@@ -27,10 +27,7 @@
*/ */
static void __init mpc830x_rdb_setup_arch(void) static void __init mpc830x_rdb_setup_arch(void)
{ {
if (ppc_md.progress) mpc83xx_setup_arch();
ppc_md.progress("mpc830x_rdb_setup_arch()", 0);
mpc83xx_setup_pci();
mpc831x_usb_cfg(); mpc831x_usb_cfg();
} }
......
...@@ -28,10 +28,7 @@ ...@@ -28,10 +28,7 @@
*/ */
static void __init mpc831x_rdb_setup_arch(void) static void __init mpc831x_rdb_setup_arch(void)
{ {
if (ppc_md.progress) mpc83xx_setup_arch();
ppc_md.progress("mpc831x_rdb_setup_arch()", 0);
mpc83xx_setup_pci();
mpc831x_usb_cfg(); mpc831x_usb_cfg();
} }
......
...@@ -58,8 +58,7 @@ static void __init mpc832x_sys_setup_arch(void) ...@@ -58,8 +58,7 @@ static void __init mpc832x_sys_setup_arch(void)
struct device_node *np; struct device_node *np;
u8 __iomem *bcsr_regs = NULL; u8 __iomem *bcsr_regs = NULL;
if (ppc_md.progress) mpc83xx_setup_arch();
ppc_md.progress("mpc832x_sys_setup_arch()", 0);
/* Map BCSR area */ /* Map BCSR area */
np = of_find_node_by_name(NULL, "bcsr"); np = of_find_node_by_name(NULL, "bcsr");
...@@ -71,8 +70,6 @@ static void __init mpc832x_sys_setup_arch(void) ...@@ -71,8 +70,6 @@ static void __init mpc832x_sys_setup_arch(void)
of_node_put(np); of_node_put(np);
} }
mpc83xx_setup_pci();
#ifdef CONFIG_QUICC_ENGINE #ifdef CONFIG_QUICC_ENGINE
if ((np = of_find_node_by_name(NULL, "par_io")) != NULL) { if ((np = of_find_node_by_name(NULL, "par_io")) != NULL) {
par_io_init(np); par_io_init(np);
......
...@@ -197,10 +197,7 @@ static void __init mpc832x_rdb_setup_arch(void) ...@@ -197,10 +197,7 @@ static void __init mpc832x_rdb_setup_arch(void)
struct device_node *np; struct device_node *np;
#endif #endif
if (ppc_md.progress) mpc83xx_setup_arch();
ppc_md.progress("mpc832x_rdb_setup_arch()", 0);
mpc83xx_setup_pci();
#ifdef CONFIG_QUICC_ENGINE #ifdef CONFIG_QUICC_ENGINE
if ((np = of_find_node_by_name(NULL, "par_io")) != NULL) { if ((np = of_find_node_by_name(NULL, "par_io")) != NULL) {
......
...@@ -57,10 +57,7 @@ machine_device_initcall(mpc834x_itx, mpc834x_itx_declare_of_platform_devices); ...@@ -57,10 +57,7 @@ machine_device_initcall(mpc834x_itx, mpc834x_itx_declare_of_platform_devices);
*/ */
static void __init mpc834x_itx_setup_arch(void) static void __init mpc834x_itx_setup_arch(void)
{ {
if (ppc_md.progress) mpc83xx_setup_arch();
ppc_md.progress("mpc834x_itx_setup_arch()", 0);
mpc83xx_setup_pci();
mpc834x_usb_cfg(); mpc834x_usb_cfg();
} }
......
...@@ -76,10 +76,7 @@ static int mpc834xemds_usb_cfg(void) ...@@ -76,10 +76,7 @@ static int mpc834xemds_usb_cfg(void)
*/ */
static void __init mpc834x_mds_setup_arch(void) static void __init mpc834x_mds_setup_arch(void)
{ {
if (ppc_md.progress) mpc83xx_setup_arch();
ppc_md.progress("mpc834x_mds_setup_arch()", 0);
mpc83xx_setup_pci();
mpc834xemds_usb_cfg(); mpc834xemds_usb_cfg();
} }
......
...@@ -66,8 +66,7 @@ static void __init mpc836x_mds_setup_arch(void) ...@@ -66,8 +66,7 @@ static void __init mpc836x_mds_setup_arch(void)
struct device_node *np; struct device_node *np;
u8 __iomem *bcsr_regs = NULL; u8 __iomem *bcsr_regs = NULL;
if (ppc_md.progress) mpc83xx_setup_arch();
ppc_md.progress("mpc836x_mds_setup_arch()", 0);
/* Map BCSR area */ /* Map BCSR area */
np = of_find_node_by_name(NULL, "bcsr"); np = of_find_node_by_name(NULL, "bcsr");
...@@ -79,8 +78,6 @@ static void __init mpc836x_mds_setup_arch(void) ...@@ -79,8 +78,6 @@ static void __init mpc836x_mds_setup_arch(void)
of_node_put(np); of_node_put(np);
} }
mpc83xx_setup_pci();
#ifdef CONFIG_QUICC_ENGINE #ifdef CONFIG_QUICC_ENGINE
if ((np = of_find_node_by_name(NULL, "par_io")) != NULL) { if ((np = of_find_node_by_name(NULL, "par_io")) != NULL) {
par_io_init(np); par_io_init(np);
......
...@@ -31,10 +31,7 @@ machine_device_initcall(mpc836x_rdk, mpc83xx_declare_of_platform_devices); ...@@ -31,10 +31,7 @@ machine_device_initcall(mpc836x_rdk, mpc83xx_declare_of_platform_devices);
static void __init mpc836x_rdk_setup_arch(void) static void __init mpc836x_rdk_setup_arch(void)
{ {
if (ppc_md.progress) mpc83xx_setup_arch();
ppc_md.progress("mpc836x_rdk_setup_arch()", 0);
mpc83xx_setup_pci();
} }
/* /*
......
...@@ -79,10 +79,7 @@ static int mpc837xmds_usb_cfg(void) ...@@ -79,10 +79,7 @@ static int mpc837xmds_usb_cfg(void)
*/ */
static void __init mpc837x_mds_setup_arch(void) static void __init mpc837x_mds_setup_arch(void)
{ {
if (ppc_md.progress) mpc83xx_setup_arch();
ppc_md.progress("mpc837x_mds_setup_arch()", 0);
mpc83xx_setup_pci();
mpc837xmds_usb_cfg(); mpc837xmds_usb_cfg();
} }
......
...@@ -50,10 +50,7 @@ static void mpc837x_rdb_sd_cfg(void) ...@@ -50,10 +50,7 @@ static void mpc837x_rdb_sd_cfg(void)
*/ */
static void __init mpc837x_rdb_setup_arch(void) static void __init mpc837x_rdb_setup_arch(void)
{ {
if (ppc_md.progress) mpc83xx_setup_arch();
ppc_md.progress("mpc837x_rdb_setup_arch()", 0);
mpc83xx_setup_pci();
mpc837x_usb_cfg(); mpc837x_usb_cfg();
mpc837x_rdb_sd_cfg(); mpc837x_rdb_sd_cfg();
} }
......
...@@ -86,5 +86,6 @@ extern void mpc83xx_setup_pci(void); ...@@ -86,5 +86,6 @@ extern void mpc83xx_setup_pci(void);
#endif #endif
extern int mpc83xx_declare_of_platform_devices(void); extern int mpc83xx_declare_of_platform_devices(void);
extern void mpc83xx_setup_arch(void);
#endif /* __MPC83XX_H__ */ #endif /* __MPC83XX_H__ */
...@@ -47,10 +47,7 @@ ...@@ -47,10 +47,7 @@
*/ */
static void __init sbc834x_setup_arch(void) static void __init sbc834x_setup_arch(void)
{ {
if (ppc_md.progress) mpc83xx_setup_arch();
ppc_md.progress("sbc834x_setup_arch()", 0);
mpc83xx_setup_pci();
} }
machine_device_initcall(sbc834x, mpc83xx_declare_of_platform_devices); machine_device_initcall(sbc834x, mpc83xx_declare_of_platform_devices);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment