Fixed large DoS vector in the middleware implementation

07c8d2ee · Tj Holowaychuk · indexzero · 5575bcf6 · 07c8d2ee
Commit 07c8d2ee authored Sep 01, 2011 by Tj Holowaychuk Committed by indexzero Sep 08, 2011
Show whitespace changes
Inline Side-by-side

Showing with 9 additions and 5 deletions

lib/node-http-proxy.js lib/node-http-proxy.js +9 -5

No files found.
--- a/lib/node-http-proxy.js
+++ b/lib/node-http-proxy.js
@@ -125,11 +125,15 @@ exports.stack = function stack (middlewares, proxy) {
    handle = function (req, res) {
      var next = function (err) {
        if (err) {
-          throw err;
-          //
-          // TODO: figure out where to send errors.
-          // return error(req, res, err);
-          //
+          console.error(err.stack);
+          if (res._headerSent) {
+            res.destroy();
+          } else {
+            res.statusCode = 500;
+            res.setHeader('Content-Type', 'text/plain');
+            res.end('Internal Server Error');
+          }
+          return;
        }
        child(req, res);
      }