Skip to content
  • This project
    • Loading...
  • Sign in

nexedi / renderjs

Go to a project
Toggle navigation
Toggle navigation pinning
  • Projects
  • Groups
  • Snippets
  • Help
  • Project
  • Activity
  • Repository
  • Graphs
  • Merge Requests 1
  • Network
  • Create a new issue
  • Commits
  • Issue Boards
Closed
Merge Request !1 opened 2015-12-01 19:46:25 UTC by Boris Kocherov@bk

prevent loading render.js and rsvp.js twice from different url

@romain /cc @cedric.leninivin

Patch for spreadsheet gadget works in classic erp5 standard ui too and for @jerome gadget works in renderjs_ui as well as in erp5 standard ui.

https://lab.nexedi.com/bk/erp5/blob/master/bt5/erp5_graph_editor/SkinTemplateItem/portal_skins/erp5_graph_editor/dream_graph_editor/jsplumb/index.html.xml#L32

Edited 2016-03-09 14:23:21 UTC
Request to merge bk:master into master
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://lab.nexedi.com/bk/renderjs.git master
git checkout -b bk/renderjs-master FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff bk/renderjs-master

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Closed

The changes were not merged into master.

  • Discussion 1
  • Commits 1
  • Changes 1
  • {{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • @romain Romain Courteaud
    @romain commented 2015-12-02 09:32:58 UTC
    Owner

    URL are meaningless and only describe location of a ressource.

    It is possible to host renderjs in a server with a completely different kind of URL (shacache for example) and this patch will not prevent conflict to happen.

    For now, I consider the application developper should be responsible to prevent such issue. RenderJS can not alone prevent it currently.

    One easy way is to embed the "uncontrolled" into an iframe sandbox. This will prevent any conflict.

    A cleaner but more difficult solution would be to start using SRI and handle it also in renderJS. But I'm afraid of updating all gadget HTML when renderJS is updated. We could start using ERP5 template functionnality to calculate the SHA dynamically.

    In short, I reject the merge request.

  • @romain Romain Courteaud
    @romain

    Status changed to closed

    2015-12-02 09:32:58 UTC

    Status changed to closed

    Toggle commit list
  • @bk Boris Kocherov
    @bk

    mentioned in commit erp5@b1e8b649

    2016-03-09 14:23:21 UTC

    mentioned in commit erp5@b1e8b649

    Toggle commit list
  • Write
  • Preview
Styling with Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
  • Please register or sign in to post a comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
4
4 participants
Reference: nexedi/renderjs!1
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备14008524号